Fix OverlayEntry.remove to work even after the Overlay is disposed. (#3412)

fffbf6e9 · Matt Perry · 9aeeb158 · fffbf6e9
Commit fffbf6e9 authored Apr 20, 2016 by Matt Perry
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

overlay.dart packages/flutter/lib/src/widgets/overlay.dart +3 -3

No files found.
--- a/packages/flutter/lib/src/widgets/overlay.dart
+++ b/packages/flutter/lib/src/widgets/overlay.dart
@@ -215,9 +215,9 @@ class OverlayState extends State<Overlay> {
  }

  void _remove(OverlayEntry entry) {
-    setState(() {
-      _entries.remove(entry);
-    });
+    _entries.remove(entry);
+    if (mounted)
+      setState(() { /* entry was removed */ });
  }

  /// (DEBUG ONLY) Check whether a given entry is visible (i.e., not behind an opaque entry).