Commit fddab5d8 authored by pq's avatar pq

Back out SDK summaries.

Net-net: SDK summaries are not safe in the presence of SDK library embedders.

Context (and bug to track re-enablement) here: https://github.com/dart-lang/sdk/issues/26467.
parent e1e773af
...@@ -92,7 +92,9 @@ class AnalysisDriver { ...@@ -92,7 +92,9 @@ class AnalysisDriver {
Map<String, List<file_system.Folder>> packageMap) { Map<String, List<file_system.Folder>> packageMap) {
DirectoryBasedDartSdk sdk = new DirectoryBasedDartSdk(new JavaFile(sdkDir)); DirectoryBasedDartSdk sdk = new DirectoryBasedDartSdk(new JavaFile(sdkDir));
sdk.analysisOptions = context.analysisOptions; sdk.analysisOptions = context.analysisOptions;
sdk.useSummary = true; // TODO(pq): re-enable once we have a proper story for SDK summaries
// in the presence of embedders (https://github.com/dart-lang/sdk/issues/26467).
sdk.useSummary = false;
List<UriResolver> resolvers = <UriResolver>[]; List<UriResolver> resolvers = <UriResolver>[];
EmbedderYamlLocator yamlLocator = context.embedderYamlLocator; EmbedderYamlLocator yamlLocator = context.embedderYamlLocator;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment