Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
fdae7bb8
Unverified
Commit
fdae7bb8
authored
Apr 25, 2019
by
Jonah Williams
Committed by
GitHub
Apr 25, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
add check that xcode project configuration is not missing (#31621)
parent
0acd3e6b
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
14 additions
and
1 deletion
+14
-1
application_package.dart
packages/flutter_tools/lib/src/application_package.dart
+5
-1
application_package_test.dart
packages/flutter_tools/test/application_package_test.dart
+9
-0
No files found.
packages/flutter_tools/lib/src/application_package.dart
View file @
fdae7bb8
...
...
@@ -319,7 +319,7 @@ abstract class IOSApp extends ApplicationPackage {
return
null
;
}
if
(!
project
.
exists
)
{
// If the project doesn't exist at all the
existing
hint to run flutter
// If the project doesn't exist at all the
current
hint to run flutter
// create is accurate.
return
null
;
}
...
...
@@ -327,6 +327,10 @@ abstract class IOSApp extends ApplicationPackage {
printError
(
'Expected ios/Runner.xcodeproj but this file is missing.'
);
return
null
;
}
if
(!
project
.
xcodeProjectInfoFile
.
existsSync
())
{
printError
(
'Expected ios/Runner.xcodeproj/project.pbxproj but this file is missing.'
);
return
null
;
}
return
BuildableIOSApp
(
project
);
}
...
...
packages/flutter_tools/test/application_package_test.dart
View file @
fdae7bb8
...
...
@@ -294,6 +294,15 @@ void main() {
expect
(
iosApp
,
null
);
},
overrides:
overrides
);
testUsingContext
(
'returns null when there is no Runner.xcodeproj/project.pbxproj'
,
()
async
{
fs
.
file
(
'pubspec.yaml'
).
createSync
();
fs
.
file
(
'.packages'
).
createSync
();
fs
.
file
(
'ios/Runner.xcodeproj'
).
createSync
(
recursive:
true
);
final
BuildableIOSApp
iosApp
=
IOSApp
.
fromIosProject
((
await
FlutterProject
.
fromDirectory
(
fs
.
currentDirectory
)).
ios
);
expect
(
iosApp
,
null
);
},
overrides:
overrides
);
});
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment