Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
fc99e7c0
Unverified
Commit
fc99e7c0
authored
Mar 02, 2021
by
Michael Goderbauer
Committed by
GitHub
Mar 02, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Enable missing_whitespace_between_adjacent_strings (#77027)
parent
995bd989
Changes
24
Hide whitespace changes
Inline
Side-by-side
Showing
24 changed files
with
64 additions
and
69 deletions
+64
-69
analysis_options.yaml
analysis_options.yaml
+1
-1
fullscreenTextField.dart
...nchmarks/macrobenchmarks/lib/src/fullscreenTextField.dart
+10
-10
recorder.dart
dev/benchmarks/macrobenchmarks/lib/src/web/recorder.dart
+3
-3
frame_policy_test.dart
...hmarks/macrobenchmarks/test_driver/frame_policy_test.dart
+2
-2
deprecation.dart
...est/analyze-test-input/root/packages/foo/deprecation.dart
+1
-1
adb.dart
dev/devicelab/lib/framework/adb.dart
+1
-2
cocoon_test.dart
dev/devicelab/test/cocoon_test.dart
+1
-1
text_editing_integration.dart
...s/web_e2e_tests/test_driver/text_editing_integration.dart
+1
-3
velocity_tracker.dart
packages/flutter/lib/src/gestures/velocity_tracker.dart
+1
-1
scaffold.dart
packages/flutter/lib/src/material/scaffold.dart
+6
-6
proxy_box.dart
packages/flutter/lib/src/rendering/proxy_box.dart
+1
-1
actions.dart
packages/flutter/lib/src/widgets/actions.dart
+7
-5
elevated_button_test.dart
packages/flutter/test/material/elevated_button_test.dart
+1
-1
outlined_button_test.dart
packages/flutter/test/material/outlined_button_test.dart
+1
-1
snack_bar_test.dart
packages/flutter/test/material/snack_bar_test.dart
+1
-2
text_button_test.dart
packages/flutter/test/material/text_button_test.dart
+1
-1
autofill_test.dart
packages/flutter/test/services/autofill_test.dart
+1
-2
editable_text_test.dart
packages/flutter/test/widgets/editable_text_test.dart
+1
-2
cache.dart
packages/flutter_tools/lib/src/cache.dart
+1
-1
flutter_command.dart
packages/flutter_tools/lib/src/runner/flutter_command.dart
+3
-3
logger_test.dart
...es/flutter_tools/test/general.shard/base/logger_test.dart
+2
-0
github_template_test.dart
...lutter_tools/test/general.shard/github_template_test.dart
+13
-13
ios_device_logger_test.dart
..._tools/test/general.shard/ios/ios_device_logger_test.dart
+2
-2
project_file_invalidator_test.dart
...ols/test/general.shard/project_file_invalidator_test.dart
+2
-5
No files found.
analysis_options.yaml
View file @
fc99e7c0
...
@@ -125,7 +125,7 @@ linter:
...
@@ -125,7 +125,7 @@ linter:
# - lines_longer_than_80_chars # not required by flutter style
# - lines_longer_than_80_chars # not required by flutter style
-
list_remove_unrelated_type
-
list_remove_unrelated_type
# - literal_only_boolean_expressions # too many false positives: https://github.com/dart-lang/sdk/issues/34181
# - literal_only_boolean_expressions # too many false positives: https://github.com/dart-lang/sdk/issues/34181
# - missing_whitespace_between_adjacent_strings # not yet tested
-
missing_whitespace_between_adjacent_strings
-
no_adjacent_strings_in_list
-
no_adjacent_strings_in_list
# - no_default_cases # too many false positives
# - no_default_cases # too many false positives
-
no_duplicate_case_values
-
no_duplicate_case_values
...
...
dev/benchmarks/macrobenchmarks/lib/src/fullscreenTextField.dart
View file @
fc99e7c0
...
@@ -16,7 +16,7 @@ const String textLotsOfText = 'Lorem ipsum dolor sit amet, consectetur '
...
@@ -16,7 +16,7 @@ const String textLotsOfText = 'Lorem ipsum dolor sit amet, consectetur '
'eleifend. Sagittis aliquam malesuada bibendum arcu vitae elementum. Massa sed '
'eleifend. Sagittis aliquam malesuada bibendum arcu vitae elementum. Massa sed '
'elementum tempus egestas sed sed risus. Amet consectetur adipiscing elit ut '
'elementum tempus egestas sed sed risus. Amet consectetur adipiscing elit ut '
'aliquam purus sit amet luctus. Elementum nisi quis eleifend quam adipiscing '
'aliquam purus sit amet luctus. Elementum nisi quis eleifend quam adipiscing '
'vitae. Aliquam sem fringilla ut morbi tincidunt augue.'
'vitae. Aliquam sem fringilla ut morbi tincidunt augue.
'
'👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦'
'👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦'
'👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦'
'👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦'
'👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦'
'👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦'
...
@@ -32,19 +32,19 @@ const String textLotsOfText = 'Lorem ipsum dolor sit amet, consectetur '
...
@@ -32,19 +32,19 @@ const String textLotsOfText = 'Lorem ipsum dolor sit amet, consectetur '
'👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦'
'👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦'
'👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦'
'👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦'
'👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦'
'👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦'
'👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦'
'👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦👨👩👦
'
'😀 😃 😄 😁 😆 😅 😂 🤣 🥲 ☺️ 😊 😇 🙂 🙃 😉 😌 😍 🥰 😘 😗 😙'
'😀 😃 😄 😁 😆 😅 😂 🤣 🥲 ☺️ 😊 😇 🙂 🙃 😉 😌 😍 🥰 😘 😗 😙
'
'😚 😋 😛 😝 😜 🤪 🤨 🧐 🤓 😎 🥸 🤩 🥳 😏 😒 😞 😔 😟 😕 🙁 ☹'
'😚 😋 😛 😝 😜 🤪 🤨 🧐 🤓 😎 🥸 🤩 🥳 😏 😒 😞 😔 😟 😕 🙁 ☹
'
'️
😣 😖 😫 😩 🥺 😢 😭 😤 😠 😡 🤬 🤯 😳 🥵 🥶 😱 😨 😰 😥 😓 '
'️😣 😖 😫 😩 🥺 😢 😭 😤 😠 😡 🤬 🤯 😳 🥵 🥶 😱 😨 😰 😥 😓 '
'🤗 🤔 🤭 🤫 🤥 😶 😐 😑 😬 🙄 😯 😦 😧 😮 😲 🥱 😴 🤤 😪 😵 '
'🤗 🤔 🤭 🤫 🤥 😶 😐 😑 😬 🙄 😯 😦 😧 😮 😲 🥱 😴 🤤 😪 😵 '
'🤐 🥴 🤢 🤮 🤧 😷 🤒 🤕 🤑 🤠 😈 👿 👹 👺 🤡 💩 👻 💀 ☠️ 👽 '
'🤐 🥴 🤢 🤮 🤧 😷 🤒 🤕 🤑 🤠 😈 👿 👹 👺 🤡 💩 👻 💀 ☠️ 👽 '
'👾 🤖 🎃 😺 😸 😹 😻 😼 😽 🙀 😿 😾'
'👾 🤖 🎃 😺 😸 😹 😻 😼 😽 🙀 😿 😾
'
'️
😣 😖 😫 😩 🥺 😢 😭 😤 😠 😡 🤬 🤯 😳 🥵 🥶 😱 😨 😰 😥 😓 '
'️😣 😖 😫 😩 🥺 😢 😭 😤 😠 😡 🤬 🤯 😳 🥵 🥶 😱 😨 😰 😥 😓 '
'🤗 🤔 🤭 🤫 🤥 😶 😐 😑 😬 🙄 😯 😦 😧 😮 😲 🥱 😴 🤤 😪 😵 '
'🤗 🤔 🤭 🤫 🤥 😶 😐 😑 😬 🙄 😯 😦 😧 😮 😲 🥱 😴 🤤 😪 😵 '
'🤐 🥴 🤢 🤮 🤧 😷 🤒 🤕 🤑 🤠 😈 👿 👹 👺 🤡 💩 👻 💀 ☠️ 👽 '
'🤐 🥴 🤢 🤮 🤧 😷 🤒 🤕 🤑 🤠 😈 👿 👹 👺 🤡 💩 👻 💀 ☠️ 👽 '
'👾 🤖 🎃 😺 😸 😹 😻 😼 😽 🙀 😿 😾'
'👾 🤖 🎃 😺 😸 😹 😻 😼 😽 🙀 😿 😾
'
'👋 🤚 🖐 ✋ 🖖 👌 🤌 🤏 ✌️ 🤞 🤟 🤘 🤙 👈 👉 👆 🖕 👇 ☝️ 👍 👎'
'👋 🤚 🖐 ✋ 🖖 👌 🤌 🤏 ✌️ 🤞 🤟 🤘 🤙 👈 👉 👆 🖕 👇 ☝️ 👍 👎
'
'
✊ 👊 🤛 🤜 👏 🙌 👐 🤲 🤝 🙏 ✍️ 💅 🤳 💪 🦾 🦵 🦿 🦶 👣 👂 '
'✊ 👊 🤛 🤜 👏 🙌 👐 🤲 🤝 🙏 ✍️ 💅 🤳 💪 🦾 🦵 🦿 🦶 👣 👂 '
'🦻 👃 🫀 🫁 🧠 🦷 🦴 👀 👁 👅 👄 💋 🩸'
;
'🦻 👃 🫀 🫁 🧠 🦷 🦴 👀 👁 👅 👄 💋 🩸'
;
class
TextFieldPage
extends
StatelessWidget
{
class
TextFieldPage
extends
StatelessWidget
{
...
...
dev/benchmarks/macrobenchmarks/lib/src/web/recorder.dart
View file @
fc99e7c0
...
@@ -750,9 +750,9 @@ class TimeseriesStats {
...
@@ -750,9 +750,9 @@ class TimeseriesStats {
String
toString
()
{
String
toString
()
{
final
StringBuffer
buffer
=
StringBuffer
();
final
StringBuffer
buffer
=
StringBuffer
();
buffer
.
writeln
(
buffer
.
writeln
(
'
$name
: (samples:
$cleanSampleCount
clean/
$outlierSampleCount
outliers/
'
'
$name
: (samples:
$cleanSampleCount
clean/
$outlierSampleCount
'
'
${cleanSampleCount + outlierSampleCount}
measured/
'
'
outliers/
${cleanSampleCount + outlierSampleCount}
'
'
${samples.length}
total)'
);
'
measured/
${samples.length}
total)'
);
buffer
.
writeln
(
' | average:
$average
μs'
);
buffer
.
writeln
(
' | average:
$average
μs'
);
buffer
.
writeln
(
' | outlier average:
$outlierAverage
μs'
);
buffer
.
writeln
(
' | outlier average:
$outlierAverage
μs'
);
buffer
.
writeln
(
' | outlier/clean ratio:
${outlierRatio}
x'
);
buffer
.
writeln
(
' | outlier/clean ratio:
${outlierRatio}
x'
);
...
...
dev/benchmarks/macrobenchmarks/test_driver/frame_policy_test.dart
View file @
fc99e7c0
...
@@ -16,8 +16,8 @@ Future<void> main() => driver.integrationDriver(
...
@@ -16,8 +16,8 @@ Future<void> main() => driver.integrationDriver(
if
(
benchmarkLiveResult
[
'frame_count'
]
as
int
<
10
if
(
benchmarkLiveResult
[
'frame_count'
]
as
int
<
10
||
fullyLiveResult
[
'frame_count'
]
as
int
<
10
)
{
||
fullyLiveResult
[
'frame_count'
]
as
int
<
10
)
{
print
(
'Failure Details:
\n
Not Enough frames collected:'
print
(
'Failure Details:
\n
Not Enough frames collected:
'
'benchmarkLive
${benchmarkLiveResult['frameCount']}
,'
'benchmarkLive
${benchmarkLiveResult['frameCount']}
,
'
'
${fullyLiveResult['frameCount']}
.'
);
'
${fullyLiveResult['frameCount']}
.'
);
exit
(
1
);
exit
(
1
);
}
}
...
...
dev/bots/test/analyze-test-input/root/packages/foo/deprecation.dart
View file @
fc99e7c0
...
@@ -9,7 +9,7 @@
...
@@ -9,7 +9,7 @@
void
test1
(
)
{
}
void
test1
(
)
{
}
@Deprecated
(
@Deprecated
(
'Missing space ->.'
'Missing space ->.'
//ignore: missing_whitespace_between_adjacent_strings
'This feature was deprecated after v1.2.3.'
'This feature was deprecated after v1.2.3.'
)
)
void
test2
(
)
{
}
void
test2
(
)
{
}
...
...
dev/devicelab/lib/framework/adb.dart
View file @
fc99e7c0
...
@@ -72,8 +72,7 @@ abstract class DeviceDiscovery {
...
@@ -72,8 +72,7 @@ abstract class DeviceDiscovery {
case
DeviceOperatingSystem
.
fuchsia
:
case
DeviceOperatingSystem
.
fuchsia
:
return
FuchsiaDeviceDiscovery
();
return
FuchsiaDeviceDiscovery
();
case
DeviceOperatingSystem
.
fake
:
case
DeviceOperatingSystem
.
fake
:
print
(
'Looking for fake devices!'
print
(
'Looking for fake devices! You should not see this in release builds.'
);
'You should not see this in release builds.'
);
return
FakeDeviceDiscovery
();
return
FakeDeviceDiscovery
();
default
:
default
:
throw
DeviceException
(
'Unsupported device operating system:
$deviceOperatingSystem
'
);
throw
DeviceException
(
'Unsupported device operating system:
$deviceOperatingSystem
'
);
...
...
dev/devicelab/test/cocoon_test.dart
View file @
fc99e7c0
...
@@ -126,7 +126,7 @@ void main() {
...
@@ -126,7 +126,7 @@ void main() {
const
String
updateTaskJson
=
'{'
const
String
updateTaskJson
=
'{'
'"CommitBranch":"master",'
'"CommitBranch":"master",'
'"CommitSha":"
$commitSha
",'
'"CommitSha":"
$commitSha
",'
'"BuilderName":"builder a b c",'
'"BuilderName":"builder a b c",'
//ignore: missing_whitespace_between_adjacent_strings
'"NewStatus":"Succeeded",'
'"NewStatus":"Succeeded",'
'"ResultData":{},'
'"ResultData":{},'
'"BenchmarkScoreKeys":[]}'
;
'"BenchmarkScoreKeys":[]}'
;
...
...
dev/integration_tests/web_e2e_tests/test_driver/text_editing_integration.dart
View file @
fc99e7c0
...
@@ -144,9 +144,7 @@ void main() {
...
@@ -144,9 +144,7 @@ void main() {
expect
(
input2
.
value
,
'Text2'
);
expect
(
input2
.
value
,
'Text2'
);
});
});
testWidgets
(
'Jump between TextFormFields with tab key after CapsLock is'
testWidgets
(
'Jump between TextFormFields with tab key after CapsLock is activated'
,
(
WidgetTester
tester
)
async
{
'activated'
,
(
WidgetTester
tester
)
async
{
app
.
main
();
app
.
main
();
await
tester
.
pumpAndSettle
();
await
tester
.
pumpAndSettle
();
...
...
packages/flutter/lib/src/gestures/velocity_tracker.dart
View file @
fc99e7c0
...
@@ -303,7 +303,7 @@ class IOSScrollViewFlingVelocityTracker extends VelocityTracker {
...
@@ -303,7 +303,7 @@ class IOSScrollViewFlingVelocityTracker extends VelocityTracker {
if
(
previousPoint
==
null
||
previousPoint
.
time
<=
time
)
if
(
previousPoint
==
null
||
previousPoint
.
time
<=
time
)
return
true
;
return
true
;
throw
FlutterError
(
throw
FlutterError
(
'The position being added (
$position
) has a smaller timestamp (
$time
)'
'The position being added (
$position
) has a smaller timestamp (
$time
)
'
'than its predecessor:
$previousPoint
.'
'than its predecessor:
$previousPoint
.'
);
);
}());
}());
...
...
packages/flutter/lib/src/material/scaffold.dart
View file @
fc99e7c0
...
@@ -2306,10 +2306,10 @@ class ScaffoldState extends State<Scaffold> with TickerProviderStateMixin, Resto
...
@@ -2306,10 +2306,10 @@ class ScaffoldState extends State<Scaffold> with TickerProviderStateMixin, Resto
assert
(
debugCheckHasScaffoldMessenger
(
context
));
assert
(
debugCheckHasScaffoldMessenger
(
context
));
assert
(
assert
(
_scaffoldMessenger
!=
null
,
_scaffoldMessenger
!=
null
,
'A SnackBar was shown by the ScaffoldMessenger, but has been called upon'
'A SnackBar was shown by the ScaffoldMessenger, but has been called upon
'
'to be removed from a Scaffold that is not registered with a '
'to be removed from a Scaffold that is not registered with a '
'ScaffoldMessenger, this can happen if a Scaffold has been rebuilt '
'ScaffoldMessenger, this can happen if a Scaffold has been rebuilt '
'without an ancestor ScaffoldMessenger.'
,
'without an ancestor ScaffoldMessenger.'
,
);
);
_scaffoldMessenger
!.
removeCurrentSnackBar
(
reason:
reason
);
_scaffoldMessenger
!.
removeCurrentSnackBar
(
reason:
reason
);
return
;
return
;
...
@@ -2350,8 +2350,8 @@ class ScaffoldState extends State<Scaffold> with TickerProviderStateMixin, Resto
...
@@ -2350,8 +2350,8 @@ class ScaffoldState extends State<Scaffold> with TickerProviderStateMixin, Resto
// ScaffoldMessenger is presenting SnackBars.
// ScaffoldMessenger is presenting SnackBars.
assert
(
debugCheckHasScaffoldMessenger
(
context
));
assert
(
debugCheckHasScaffoldMessenger
(
context
));
assert
(
assert
(
_scaffoldMessenger
!=
null
,
_scaffoldMessenger
!=
null
,
'A SnackBar was shown by the ScaffoldMessenger, but has been called upon
'
'A SnackBar was shown by the ScaffoldMessenger, but has been called upon
'
'to be removed from a Scaffold that is not registered with a '
'to be removed from a Scaffold that is not registered with a '
'ScaffoldMessenger, this can happen if a Scaffold has been rebuilt '
'ScaffoldMessenger, this can happen if a Scaffold has been rebuilt '
'without an ancestor ScaffoldMessenger.'
,
'without an ancestor ScaffoldMessenger.'
,
...
...
packages/flutter/lib/src/rendering/proxy_box.dart
View file @
fc99e7c0
...
@@ -5221,7 +5221,7 @@ class RenderFollowerLayer extends RenderProxyBox {
...
@@ -5221,7 +5221,7 @@ class RenderFollowerLayer extends RenderProxyBox {
assert
(
assert
(
link
.
leaderSize
!=
null
||
(
link
.
leader
==
null
||
leaderAnchor
==
Alignment
.
topLeft
),
link
.
leaderSize
!=
null
||
(
link
.
leader
==
null
||
leaderAnchor
==
Alignment
.
topLeft
),
'
$link
: layer is linked to
${link.leader}
but a valid leaderSize is not set. '
'
$link
: layer is linked to
${link.leader}
but a valid leaderSize is not set. '
'leaderSize is required when leaderAnchor is not Alignment.topLeft'
'leaderSize is required when leaderAnchor is not Alignment.topLeft
'
'(current value is
$leaderAnchor
).'
,
'(current value is
$leaderAnchor
).'
,
);
);
final
Offset
effectiveLinkedOffset
=
leaderSize
==
null
final
Offset
effectiveLinkedOffset
=
leaderSize
==
null
...
...
packages/flutter/lib/src/widgets/actions.dart
View file @
fc99e7c0
...
@@ -849,11 +849,13 @@ class Actions extends StatefulWidget {
...
@@ -849,11 +849,13 @@ class Actions extends StatefulWidget {
// This allows this function to be called by code that doesn't know the
// This allows this function to be called by code that doesn't know the
// concrete type of the intent at compile time.
// concrete type of the intent at compile time.
final
Type
type
=
intent
?.
runtimeType
??
T
;
final
Type
type
=
intent
?.
runtimeType
??
T
;
assert
(
type
!=
Intent
,
assert
(
'The type passed to "find" resolved to "Intent": either a non-Intent'
type
!=
Intent
,
'generic type argument or an example intent derived from Intent must be'
'The type passed to "find" resolved to "Intent": either a non-Intent '
'specified. Intent may be used as the generic type as long as the optional'
'generic type argument or an example intent derived from Intent must be '
'"intent" argument is passed.'
);
'specified. Intent may be used as the generic type as long as the optional '
'"intent" argument is passed.'
);
_visitActionsAncestors
(
context
,
(
InheritedElement
element
)
{
_visitActionsAncestors
(
context
,
(
InheritedElement
element
)
{
final
_ActionsMarker
actions
=
element
.
widget
as
_ActionsMarker
;
final
_ActionsMarker
actions
=
element
.
widget
as
_ActionsMarker
;
...
...
packages/flutter/test/material/elevated_button_test.dart
View file @
fc99e7c0
...
@@ -794,7 +794,7 @@ void main() {
...
@@ -794,7 +794,7 @@ void main() {
for
(
final
TextDirection
textDirection
in
textDirectionOptions
)
{
for
(
final
TextDirection
textDirection
in
textDirectionOptions
)
{
for
(
final
Widget
?
icon
in
iconOptions
)
{
for
(
final
Widget
?
icon
in
iconOptions
)
{
final
String
testName
=
'ElevatedButton'
final
String
testName
=
'ElevatedButton'
', text scale
$textScaleFactor
'
', text scale
$textScaleFactor
'
// ignore: missing_whitespace_between_adjacent_strings, https://github.com/dart-lang/linter/issues/2489
'
${icon != null ? ", with icon" : ""}
'
'
${icon != null ? ", with icon" : ""}
'
'
${textDirection == TextDirection.rtl ? ", RTL" : ""}
'
;
'
${textDirection == TextDirection.rtl ? ", RTL" : ""}
'
;
...
...
packages/flutter/test/material/outlined_button_test.dart
View file @
fc99e7c0
...
@@ -1039,7 +1039,7 @@ void main() {
...
@@ -1039,7 +1039,7 @@ void main() {
for
(
final
TextDirection
textDirection
in
textDirectionOptions
)
{
for
(
final
TextDirection
textDirection
in
textDirectionOptions
)
{
for
(
final
Widget
?
icon
in
iconOptions
)
{
for
(
final
Widget
?
icon
in
iconOptions
)
{
final
String
testName
=
'OutlinedButton'
final
String
testName
=
'OutlinedButton'
', text scale
$textScaleFactor
'
', text scale
$textScaleFactor
'
// ignore: missing_whitespace_between_adjacent_strings, https://github.com/dart-lang/linter/issues/2489
'
${icon != null ? ", with icon" : ""}
'
'
${icon != null ? ", with icon" : ""}
'
'
${textDirection == TextDirection.rtl ? ", RTL" : ""}
'
;
'
${textDirection == TextDirection.rtl ? ", RTL" : ""}
'
;
...
...
packages/flutter/test/material/snack_bar_test.dart
View file @
fc99e7c0
...
@@ -1981,8 +1981,7 @@ void main() {
...
@@ -1981,8 +1981,7 @@ void main() {
);
);
testWidgets
(
testWidgets
(
'
${SnackBarBehavior.floating}
should align SnackBar with the top of FloatingActionButton'
'
${SnackBarBehavior.floating}
should align SnackBar with the top of FloatingActionButton when Scaffold has a FloatingActionButton'
,
'when Scaffold has a FloatingActionButton'
,
(
WidgetTester
tester
)
async
{
(
WidgetTester
tester
)
async
{
await
tester
.
pumpWidget
(
MaterialApp
(
await
tester
.
pumpWidget
(
MaterialApp
(
home:
Scaffold
(
home:
Scaffold
(
...
...
packages/flutter/test/material/text_button_test.dart
View file @
fc99e7c0
...
@@ -832,7 +832,7 @@ void main() {
...
@@ -832,7 +832,7 @@ void main() {
for
(
final
TextDirection
textDirection
in
textDirectionOptions
)
{
for
(
final
TextDirection
textDirection
in
textDirectionOptions
)
{
for
(
final
Widget
?
icon
in
iconOptions
)
{
for
(
final
Widget
?
icon
in
iconOptions
)
{
final
String
testName
=
'TextButton'
final
String
testName
=
'TextButton'
', text scale
$textScaleFactor
'
', text scale
$textScaleFactor
'
// ignore: missing_whitespace_between_adjacent_strings, https://github.com/dart-lang/linter/issues/2489
'
${icon != null ? ", with icon" : ""}
'
'
${icon != null ? ", with icon" : ""}
'
'
${textDirection == TextDirection.rtl ? ", RTL" : ""}
'
;
'
${textDirection == TextDirection.rtl ? ", RTL" : ""}
'
;
...
...
packages/flutter/test/services/autofill_test.dart
View file @
fc99e7c0
...
@@ -43,8 +43,7 @@ void main() {
...
@@ -43,8 +43,7 @@ void main() {
});
});
test
(
test
(
'AutofillClients send the correct configuration to the platform'
'AutofillClients send the correct configuration to the platform and responds to updateEditingStateWithTag method correctly'
,
'and responds to updateEditingStateWithTag method correctly'
,
()
async
{
()
async
{
final
FakeAutofillClient
client1
=
FakeAutofillClient
(
const
TextEditingValue
(
text:
'test1'
));
final
FakeAutofillClient
client1
=
FakeAutofillClient
(
const
TextEditingValue
(
text:
'test1'
));
final
FakeAutofillClient
client2
=
FakeAutofillClient
(
const
TextEditingValue
(
text:
'test2'
));
final
FakeAutofillClient
client2
=
FakeAutofillClient
(
const
TextEditingValue
(
text:
'test2'
));
...
...
packages/flutter/test/widgets/editable_text_test.dart
View file @
fc99e7c0
...
@@ -1806,8 +1806,7 @@ void main() {
...
@@ -1806,8 +1806,7 @@ void main() {
});
});
testWidgets
(
testWidgets
(
'iOS autocorrection rectangle should appear on demand'
'iOS autocorrection rectangle should appear on demand and dismiss when the text changes or when focus is lost'
,
'and dismiss when the text changes or when focus is lost'
,
(
WidgetTester
tester
)
async
{
(
WidgetTester
tester
)
async
{
const
Color
rectColor
=
Color
(
0xFFFF0000
);
const
Color
rectColor
=
Color
(
0xFFFF0000
);
...
...
packages/flutter_tools/lib/src/cache.dart
View file @
fc99e7c0
...
@@ -1836,7 +1836,7 @@ class ArtifactUpdater {
...
@@ -1836,7 +1836,7 @@ class ArtifactUpdater {
if
(
retries
==
0
)
{
if
(
retries
==
0
)
{
throwToolExit
(
throwToolExit
(
'Flutter could not download and/or extract
$url
. Ensure you have '
'Flutter could not download and/or extract
$url
. Ensure you have '
'network connectivity and all of the required dependencies listed at'
'network connectivity and all of the required dependencies listed at
'
'flutter.dev/setup.
\n
The original exception was:
$err
.'
'flutter.dev/setup.
\n
The original exception was:
$err
.'
);
);
}
}
...
...
packages/flutter_tools/lib/src/runner/flutter_command.dart
View file @
fc99e7c0
...
@@ -448,8 +448,8 @@ abstract class FlutterCommand extends Command<void> {
...
@@ -448,8 +448,8 @@ abstract class FlutterCommand extends Command<void> {
argParser
.
addFlag
(
'publish-port'
,
argParser
.
addFlag
(
'publish-port'
,
negatable:
true
,
negatable:
true
,
hide:
!
verboseHelp
,
hide:
!
verboseHelp
,
help:
'Publish the VM service port over mDNS. Disable to prevent the'
help:
'Publish the VM service port over mDNS. Disable to prevent the
'
'local network permission app dialog in debug and profile build modes (iOS devices only.)'
,
'local network permission app dialog in debug and profile build modes (iOS devices only.)'
,
defaultsTo:
enabledByDefault
);
defaultsTo:
enabledByDefault
);
}
}
...
@@ -670,7 +670,7 @@ abstract class FlutterCommand extends Command<void> {
...
@@ -670,7 +670,7 @@ abstract class FlutterCommand extends Command<void> {
);
);
argParser
.
addMultiOption
(
useLegacyNames
?
kExtraGenSnapshotOptions
:
FlutterOptions
.
kExtraGenSnapshotOptions
,
argParser
.
addMultiOption
(
useLegacyNames
?
kExtraGenSnapshotOptions
:
FlutterOptions
.
kExtraGenSnapshotOptions
,
help:
'A comma-separated list of additional command line arguments that will be passed directly to the Dart native compiler. '
help:
'A comma-separated list of additional command line arguments that will be passed directly to the Dart native compiler. '
'(Only used in "--profile" or "--release" builds.)'
'(Only used in "--profile" or "--release" builds.)
'
'For example, "--
${FlutterOptions.kExtraGenSnapshotOptions}
=--no-strip".'
,
'For example, "--
${FlutterOptions.kExtraGenSnapshotOptions}
=--no-strip".'
,
valueHelp:
'--foo,--bar'
,
valueHelp:
'--foo,--bar'
,
splitCommas:
true
,
splitCommas:
true
,
...
...
packages/flutter_tools/test/general.shard/base/logger_test.dart
View file @
fc99e7c0
...
@@ -572,6 +572,7 @@ void main() {
...
@@ -572,6 +572,7 @@ void main() {
outputStdout
().
join
(
'
\n
'
),
outputStdout
().
join
(
'
\n
'
),
"Knock Knock, Who's There "
// initial message
"Knock Knock, Who's There "
// initial message
' '
// placeholder so that spinner can backspace on its first tick
' '
// placeholder so that spinner can backspace on its first tick
// ignore: missing_whitespace_between_adjacent_strings
'
\
b
\
b
\
b
\
b
\
b
\
b
\
b
\
b
$a
'
// first tick
'
\
b
\
b
\
b
\
b
\
b
\
b
\
b
\
b
$a
'
// first tick
'
\
b
\
b
\
b
\
b
\
b
\
b
\
b
\
b '
// clearing the spinner
'
\
b
\
b
\
b
\
b
\
b
\
b
\
b
\
b '
// clearing the spinner
'
\
b
\
b
\
b
\
b
\
b
\
b
\
b
\
b'
// clearing the clearing of the spinner
'
\
b
\
b
\
b
\
b
\
b
\
b
\
b
\
b'
// clearing the clearing of the spinner
...
@@ -580,6 +581,7 @@ void main() {
...
@@ -580,6 +581,7 @@ void main() {
'Rude Interrupting Cow
\n
'
// message
'Rude Interrupting Cow
\n
'
// message
"Knock Knock, Who's There "
// message restoration
"Knock Knock, Who's There "
// message restoration
' '
// placeholder so that spinner can backspace on its second tick
' '
// placeholder so that spinner can backspace on its second tick
// ignore: missing_whitespace_between_adjacent_strings
'
\
b
\
b
\
b
\
b
\
b
\
b
\
b
\
b
$b
'
// second tick
'
\
b
\
b
\
b
\
b
\
b
\
b
\
b
\
b
$b
'
// second tick
'
\
b
\
b
\
b
\
b
\
b
\
b
\
b
\
b '
// clearing the spinner to put the time
'
\
b
\
b
\
b
\
b
\
b
\
b
\
b
\
b '
// clearing the spinner to put the time
'
\
b
\
b
\
b
\
b
\
b
\
b
\
b
\
b'
// clearing the clearing of the spinner
'
\
b
\
b
\
b
\
b
\
b
\
b
\
b
\
b'
// clearing the clearing of the spinner
...
...
packages/flutter_tools/test/general.shard/github_template_test.dart
View file @
fc99e7c0
...
@@ -118,19 +118,19 @@ void main() {
...
@@ -118,19 +118,19 @@ void main() {
testWithoutContext
(
'String'
,
()
{
testWithoutContext
(
'String'
,
()
{
expect
(
expect
(
GitHubTemplateCreator
.
sanitizedCrashException
(
GitHubTemplateCreator
.
sanitizedCrashException
(
'May have non-tool-internal info, very long string, 0b8abb4724aa590dd0f429683339b'
'May have non-tool-internal info, very long string, 0b8abb4724aa590dd0f429683339b'
// ignore: missing_whitespace_between_adjacent_strings
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
'24aa590dd0f429683339b1e045a1594d0b8abb4724aa590dd0f429683339b1e045a1594d0b8abb'
),
),
'String: <1,016 characters>'
,
'String: <1,016 characters>'
,
);
);
...
...
packages/flutter_tools/test/general.shard/ios/ios_device_logger_test.dart
View file @
fc99e7c0
...
@@ -40,8 +40,8 @@ void main() {
...
@@ -40,8 +40,8 @@ void main() {
group
(
'syslog stream'
,
()
{
group
(
'syslog stream'
,
()
{
testWithoutContext
(
'decodeSyslog decodes a syslog-encoded line'
,
()
{
testWithoutContext
(
'decodeSyslog decodes a syslog-encoded line'
,
()
{
final
String
decoded
=
decodeSyslog
(
final
String
decoded
=
decodeSyslog
(
r'I \M-b\M^]\M-$\M-o\M-8\M^O syslog
\M-B\M-/\
'
r'I \M-b\M^]\M-$\M-o\M-8\M^O syslog '
r'134_(\M-c\M^C\M^D)_/\M-B\M-/ \M-l\M^F\240!'
);
r'
\M-B\M-/\
134_(\M-c\M^C\M^D)_/\M-B\M-/ \M-l\M^F\240!'
);
expect
(
decoded
,
r'I ❤️ syslog ¯\_(ツ)_/¯ 솠!'
);
expect
(
decoded
,
r'I ❤️ syslog ¯\_(ツ)_/¯ 솠!'
);
});
});
...
...
packages/flutter_tools/test/general.shard/project_file_invalidator_test.dart
View file @
fc99e7c0
...
@@ -82,8 +82,7 @@ void main() {
...
@@ -82,8 +82,7 @@ void main() {
);
);
});
});
testWithoutContext
(
'Picks up changes to the .packages file and updates package_config.json'
testWithoutContext
(
'Picks up changes to the .packages file and updates package_config.json, asyncScanning:
$asyncScanning
'
,
()
async
{
', asyncScanning:
$asyncScanning
'
,
()
async
{
final
DateTime
past
=
DateTime
.
now
().
subtract
(
const
Duration
(
seconds:
1
));
final
DateTime
past
=
DateTime
.
now
().
subtract
(
const
Duration
(
seconds:
1
));
final
FileSystem
fileSystem
=
MemoryFileSystem
.
test
();
final
FileSystem
fileSystem
=
MemoryFileSystem
.
test
();
const
PackageConfig
packageConfig
=
PackageConfig
.
empty
;
const
PackageConfig
packageConfig
=
PackageConfig
.
empty
;
...
@@ -124,9 +123,7 @@ void main() {
...
@@ -124,9 +123,7 @@ void main() {
]));
]));
});
});
testWithoutContext
(
'Picks up changes to the .packages file and updates PackageConfig, asyncScanning:
$asyncScanning
'
,
()
async
{
testWithoutContext
(
'Picks up changes to the .packages file and updates PackageConfig'
', asyncScanning:
$asyncScanning
'
,
()
async
{
final
FileSystem
fileSystem
=
MemoryFileSystem
.
test
();
final
FileSystem
fileSystem
=
MemoryFileSystem
.
test
();
const
PackageConfig
packageConfig
=
PackageConfig
.
empty
;
const
PackageConfig
packageConfig
=
PackageConfig
.
empty
;
final
ProjectFileInvalidator
projectFileInvalidator
=
ProjectFileInvalidator
(
final
ProjectFileInvalidator
projectFileInvalidator
=
ProjectFileInvalidator
(
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment