Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
fbbf3ec4
Unverified
Commit
fbbf3ec4
authored
Mar 07, 2022
by
Jesús S Guerrero
Committed by
GitHub
Mar 07, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Support route on ios (#99078)
parent
b0215078
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
46 additions
and
2 deletions
+46
-2
.ci.yaml
.ci.yaml
+11
-0
TESTOWNERS
TESTOWNERS
+3
-1
devices.dart
packages/flutter_tools/lib/src/ios/devices.dart
+1
-0
simulators.dart
packages/flutter_tools/lib/src/ios/simulators.dart
+2
-1
simulators_test.dart
...flutter_tools/test/general.shard/ios/simulators_test.dart
+29
-0
No files found.
.ci.yaml
View file @
fbbf3ec4
...
...
@@ -3450,6 +3450,17 @@ targets:
task_name
:
external_ui_integration_test_ios
scheduler
:
luci
-
name
:
Mac_ios routing_test
bringup
:
true
recipe
:
devicelab/devicelab_drone
presubmit
:
false
timeout
:
60
properties
:
tags
:
>
["devicelab","ios","mac"]
task_name
:
routing_test
scheduler
:
luci
-
name
:
Mac_ios flavors_test_ios
recipe
:
devicelab/devicelab_drone
presubmit
:
false
...
...
TESTOWNERS
View file @
fbbf3ec4
...
...
@@ -63,7 +63,6 @@
/dev/devicelab/bin/tasks/platform_channels_benchmarks.dart @gaaclarke @flutter/engine
/dev/devicelab/bin/tasks/platform_views_scroll_perf__timeline_summary.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/plugin_dependencies_test.dart @jmagman @flutter/tool
/dev/devicelab/bin/tasks/routing_test.dart @zanderso @flutter/tool
/dev/devicelab/bin/tasks/textfield_perf__e2e_summary.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/web_size__compile_test.dart @yjbanov @flutter/web
/dev/devicelab/bin/tasks/opacity_peephole_col_of_rows_perf__e2e_summary.dart @flar @flutter/engine
...
...
@@ -172,6 +171,9 @@
/dev/devicelab/bin/tasks/simple_animation_perf_ios.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/tiles_scroll_perf_ios__timeline_summary.dart @zanderso @flutter/engine
## Linux android and Mac iOS Devicelab tests
/dev/devicelab/bin/tasks/routing_test.dart @zanderso @flutter/tool
## Host only DeviceLab tests
/dev/devicelab/bin/tasks/build_aar_module_test.dart @zanderso @flutter/tool
/dev/devicelab/bin/tasks/gradle_desugar_classes_test.dart @zanderso @flutter/tool
...
...
packages/flutter_tools/lib/src/ios/devices.dart
View file @
fbbf3ec4
...
...
@@ -371,6 +371,7 @@ class IOSDevice extends Device {
if
(
debuggingOptions
.
verboseSystemLogs
)
'--verbose-logging'
,
if
(
debuggingOptions
.
cacheSkSL
)
'--cache-sksl'
,
if
(
debuggingOptions
.
purgePersistentCache
)
'--purge-persistent-cache'
,
if
(
route
!=
null
)
'--route=
$route
'
,
if
(
platformArgs
[
'trace-startup'
]
as
bool
?
??
false
)
'--trace-startup'
,
];
...
...
packages/flutter_tools/lib/src/ios/simulators.dart
View file @
fbbf3ec4
...
...
@@ -473,7 +473,8 @@ class IOSSimulator extends Device {
if
(
debuggingOptions
.
traceAllowlist
!=
null
)
'--trace-allowlist="
${debuggingOptions.traceAllowlist}
"'
,
if
(
debuggingOptions
.
traceSkiaAllowlist
!=
null
)
'--trace-skia-allowlist="
${debuggingOptions.traceSkiaAllowlist}
"'
,
if
(
dartVmFlags
.
isNotEmpty
)
'--dart-flags=
$dartVmFlags
'
,
'--observatory-port=
${debuggingOptions.hostVmServicePort ?? 0}
'
'--observatory-port=
${debuggingOptions.hostVmServicePort ?? 0}
'
,
if
(
route
!=
null
)
'--route=
$route
'
],
];
...
...
packages/flutter_tools/test/general.shard/ios/simulators_test.dart
View file @
fbbf3ec4
...
...
@@ -995,6 +995,35 @@ Dec 20 17:04:32 md32-11-vm1 Another App[88374]: Ignore this text'''
ProcessManager:
()
=>
FakeProcessManager
.
any
(),
Xcode:
()
=>
xcode
,
});
testUsingContext
(
'startApp using route'
,
()
async
{
final
IOSSimulator
device
=
IOSSimulator
(
'x'
,
name:
'iPhone SE'
,
simulatorCategory:
'iOS 11.2'
,
simControl:
simControl
,
);
testPlistParser
.
setProperty
(
'CFBundleIdentifier'
,
'correct'
);
final
Directory
mockDir
=
globals
.
fs
.
currentDirectory
;
final
IOSApp
package
=
PrebuiltIOSApp
(
projectBundleId:
'correct'
,
bundleName:
'name'
,
uncompressedBundle:
mockDir
,
applicationPackage:
mockDir
,
);
const
BuildInfo
mockInfo
=
BuildInfo
(
BuildMode
.
debug
,
'flavor'
,
treeShakeIcons:
false
);
final
DebuggingOptions
mockOptions
=
DebuggingOptions
.
enabled
(
mockInfo
,
enableSoftwareRendering:
true
);
await
device
.
startApp
(
package
,
prebuiltApplication:
true
,
debuggingOptions:
mockOptions
,
route:
'/animation'
);
expect
(
simControl
.
requests
.
single
.
launchArgs
,
contains
(
'--route=/animation'
));
},
overrides:
<
Type
,
Generator
>{
PlistParser:
()
=>
testPlistParser
,
FileSystem:
()
=>
fileSystem
,
ProcessManager:
()
=>
FakeProcessManager
.
any
(),
Xcode:
()
=>
xcode
,
});
});
group
(
'IOSDevice.isSupportedForProject'
,
()
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment