reassign jonahwilliams todos (#88707)

dev/bots/allowlist.dart

@@ -11,7 +11,7 @@
 /// the SDK pins to an exact version.
 ///
 /// Before adding a new Dart Team owned dependency to this set, please clear with natebosch@
-/// or jakemac53@. For other packages please contact hixie@ or jonahwilliams@ .
+/// or jakemac53@. For other packages please contact hixie@ or zanderso@ .
 const Set<String> kCorePackageAllowList = <String>{
   'characters',
   'clock',

packages/flutter/lib/src/animation/animation_controller.dart

@@ -693,7 +693,7 @@ class AnimationController extends Animation<double>
     if (SemanticsBinding.instance!.disableAnimations) {
       switch (behavior) {
         case AnimationBehavior.normal:
-          // TODO(jonahwilliams): determine a better process for setting velocity.
+          // TODO(zanderso): determine a better process for setting velocity.
           // the value below was arbitrarily chosen because it worked for the drawer widget.
           scale = 200.0;
           break;

packages/flutter/lib/src/rendering/editable.dart

@@ -2983,7 +2983,7 @@ class RenderEditable extends RenderBox with RelayoutWhenSystemFontsChangeMixin,
   //
   // Includes newline characters from ASCII and separators from the
   // [unicode separator category](https://www.compart.com/en/unicode/category/Zs)
-  // TODO(jonahwilliams): replace when we expose this ICU information.
+  // TODO(zanderso): replace when we expose this ICU information.
   bool _onlyWhitespace(TextRange range) {
     for (int i = range.start; i < range.end; i++) {
       final int codeUnit = text!.codeUnitAt(i)!;

packages/flutter/lib/src/semantics/binding.dart

@@ -11,7 +11,7 @@ import 'debug.dart';
 export 'dart:ui' show AccessibilityFeatures;
 
 /// The glue between the semantics layer and the Flutter engine.
-// TODO(jonahwilliams): move the remaining semantic related bindings here.
+// TODO(zanderso): move the remaining semantic related bindings here.
 mixin SemanticsBinding on BindingBase {
   /// The current [SemanticsBinding], if one has been created.
   static SemanticsBinding? get instance => _instance;

packages/flutter_test/lib/src/matchers.dart

@@ -1842,7 +1842,6 @@ class _MatchesSemanticsData extends Matcher {
 
   @override
   bool matches(dynamic node, Map<dynamic, dynamic> matchState) {
-    // TODO(jonahwilliams): remove dynamic once we have removed getSemanticsData.
     if (node == null)
       return failWithDescription(matchState, 'No SemanticsData provided. '
         'Maybe you forgot to enable semantics?');

packages/flutter_tools/bin/macos_assemble.sh

@@ -3,7 +3,7 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-# TODO(jonahwilliams): refactor this and xcode_backend.sh into one script
+# TODO(zanderso): refactor this and xcode_backend.sh into one script
 # once iOS is using 'assemble'.
 RunCommand() {
   if [[ -n "$VERBOSE_SCRIPT_LOGGING" ]]; then

packages/flutter_tools/lib/src/artifacts.dart

@@ -565,7 +565,7 @@ class CachedArtifacts implements Artifacts {
       case Artifact.windowsDesktopPath:
       case Artifact.flutterMacOSPodspec:
       case Artifact.linuxHeaders:
-        // TODO(jonahwilliams): remove once debug desktop artifacts are uploaded
+        // TODO(zanderso): remove once debug desktop artifacts are uploaded
         // under a separate directory from the host artifacts.
         // https://github.com/flutter/flutter/issues/38935
         String platformDirName = _enginePlatformDirectoryName(platform);
@@ -610,7 +610,7 @@ class CachedArtifacts implements Artifacts {
       case TargetPlatform.linux_arm64:
       case TargetPlatform.darwin:
       case TargetPlatform.windows_x64:
-        // TODO(jonahwilliams): remove once debug desktop artifacts are uploaded
+        // TODO(zanderso): remove once debug desktop artifacts are uploaded
         // under a separate directory from the host artifacts.
         // https://github.com/flutter/flutter/issues/38935
         if (mode == BuildMode.debug || mode == null) {

packages/flutter_tools/lib/src/build_info.dart

@@ -36,7 +36,7 @@ class BuildInfo {
     List<String>? dartExperiments,
     required this.treeShakeIcons,
     this.performanceMeasurementFile,
-    this.packagesPath = '.packages', // TODO(jonahwilliams): make this required and remove the default.
+    this.packagesPath = '.packages', // TODO(zanderso): make this required and remove the default.
     this.nullSafetyMode = NullSafetyMode.sound,
     this.codeSizeDirectory,
     this.androidGradleDaemon = true,
@@ -534,7 +534,7 @@ enum DarwinArch {
   x86_64,
 }
 
-// TODO(jonahwilliams): replace all android TargetPlatform usage with AndroidArch.
+// TODO(zanderso): replace all android TargetPlatform usage with AndroidArch.
 enum AndroidArch {
   armeabi_v7a,
   arm64_v8a,

packages/flutter_tools/lib/src/build_system/build_system.dart

@@ -860,7 +860,7 @@ class _BuildInstance {
         ErrorHandlingFileSystem.deleteIfExists(previousFile);
       }
     } on Exception catch (exception, stackTrace) {
-      // TODO(jonahwilliams): throw specific exception for expected errors to mark
+      // TODO(zanderso): throw specific exception for expected errors to mark
       // as non-fatal. All others should be fatal.
       node.target.clearStamp(environment);
       succeeded = false;

packages/flutter_tools/lib/src/build_system/targets/ios.dart

@@ -140,7 +140,7 @@ class AotAssemblyRelease extends AotAssemblyBase {
     Source.pattern('{BUILD_DIR}/app.dill'),
     Source.hostArtifact(HostArtifact.engineDartBinary),
     Source.artifact(Artifact.skyEnginePath),
-    // TODO(jonahwilliams): cannot reference gen_snapshot with artifacts since
+    // TODO(zanderso): cannot reference gen_snapshot with artifacts since
     // it resolves to a file (ios/gen_snapshot) that never exists. This was
     // split into gen_snapshot_arm64 and gen_snapshot_armv7.
     // Source.artifact(Artifact.genSnapshot,
@@ -175,7 +175,7 @@ class AotAssemblyProfile extends AotAssemblyBase {
     Source.pattern('{BUILD_DIR}/app.dill'),
     Source.hostArtifact(HostArtifact.engineDartBinary),
     Source.artifact(Artifact.skyEnginePath),
-    // TODO(jonahwilliams): cannot reference gen_snapshot with artifacts since
+    // TODO(zanderso): cannot reference gen_snapshot with artifacts since
     // it resolves to a file (ios/gen_snapshot) that never exists. This was
     // split into gen_snapshot_arm64 and gen_snapshot_armv7.
     // Source.artifact(Artifact.genSnapshot,
@@ -502,7 +502,7 @@ abstract class IosAssetBundle extends Target {
     );
 
     // Copy the plist from either the project or module.
-    // TODO(jonahwilliams): add plist to inputs
+    // TODO(zanderso): add plist to inputs
     final FlutterProject flutterProject = FlutterProject.fromDirectory(environment.projectDir);
     flutterProject.ios.appFrameworkInfoPlist
       .copySync(environment.outputDir

packages/flutter_tools/lib/src/build_system/targets/web.dart

@@ -100,7 +100,7 @@ class WebEntrypointTarget extends Target {
     final String targetFile = environment.defines[kTargetFile];
     final bool hasPlugins = environment.defines[kHasWebPlugins] == 'true';
     final Uri importUri = environment.fileSystem.file(targetFile).absolute.uri;
-    // TODO(jonahwilliams): support configuration of this file.
+    // TODO(zanderso): support configuration of this file.
     const String packageFile = '.packages';
     final PackageConfig packageConfig = await loadPackageConfigWithLogging(
       environment.fileSystem.file(packageFile),

packages/flutter_tools/lib/src/commands/run.dart

@@ -324,7 +324,7 @@ class RunCommand extends RunCommandBase {
               'results out to "refresh_benchmark.json", and exit. This flag is '
               'intended for use in generating automated flutter benchmarks.',
       )
-      // TODO(jonahwilliams): Off by default with investigating whether this
+      // TODO(zanderso): Off by default with investigating whether this
       // is slower for certain use cases.
       // See: https://github.com/flutter/flutter/issues/49499
       ..addFlag('fast-start',

packages/flutter_tools/lib/src/commands/test.dart

@@ -373,7 +373,6 @@ class TestCommand extends FlutterCommand with DeviceBasedDevelopmentArtifacts {
       collector = CoverageCollector(
         verbose: !machine,
         libraryPredicate: (String libraryName) => libraryName.contains(projectName),
-        // TODO(jonahwilliams): file bug for incorrect URI handling on windows
         packagesPath: globals.fs.file(buildInfo.packagesPath)
           .parent.parent.childFile('.packages').path
       );

packages/flutter_tools/lib/src/compile.dart

@@ -450,7 +450,7 @@ abstract class ResidentCompiler {
     String librariesSpec,
   }) = DefaultResidentCompiler;
 
-  // TODO(jonahwilliams): find a better way to configure additional file system
+  // TODO(zanderso): find a better way to configure additional file system
   // roots from the runner.
   // See: https://github.com/flutter/flutter/issues/50494
   void addFileSystemRoot(String root);
@@ -708,7 +708,7 @@ class DefaultResidentCompiler implements ResidentCompiler {
       if (testCompilation)
         '--no-print-incremental-dependencies',
       '--target=$targetModel',
-      // TODO(jonahwilliams): remove once this becomes the default behavior
+      // TODO(zanderso): remove once this becomes the default behavior
       // in the frontend_server.
       // https://github.com/flutter/flutter/issues/52693
       '--debugger-module-names',

packages/flutter_tools/lib/src/dart/pub.dart

@@ -412,7 +412,7 @@ class _DefaultPub implements Pub {
 
   /// The command used for running pub.
   List<String> _pubCommand(List<String> arguments) {
-    // TODO(jonahwilliams): refactor to use artifacts.
+    // TODO(zanderso): refactor to use artifacts.
     final String sdkPath = _fileSystem.path.joinAll(<String>[
       Cache.flutterRoot!,
       'bin',

packages/flutter_tools/lib/src/flutter_cache.dart

@@ -843,7 +843,7 @@ class IosUsbArtifacts extends CachedArtifact {
   Uri get archiveUri => Uri.parse('${cache.storageBaseUrl}/flutter_infra_release/ios-usb-dependencies${cache.useUnsignedMacBinaries ? '/unsigned' : ''}/$name/$version/$name.zip');
 }
 
-// TODO(jonahwilliams): upload debug desktop artifacts to host-debug and
+// TODO(zanderso): upload debug desktop artifacts to host-debug and
 // remove from existing host folder.
 // https://github.com/flutter/flutter/issues/38935
 const List<List<String>> _windowsDesktopBinaryDirs = <List<String>>[

packages/flutter_tools/lib/src/fuchsia/application_package.dart

@@ -48,7 +48,7 @@ class PrebuiltFuchsiaApp extends FuchsiaApp {
   PrebuiltFuchsiaApp({
     required String farArchive,
   }) : _farArchive = farArchive,
-       // TODO(zra): Extract the archive and extract the id from meta/package.
+       // TODO(zanderso): Extract the archive and extract the id from meta/package.
        super(projectBundleId: farArchive);
 
   final String _farArchive;
@@ -68,7 +68,7 @@ class BuildableFuchsiaApp extends FuchsiaApp {
 
   @override
   File farArchive(BuildMode buildMode) {
-    // TODO(zra): Distinguish among build modes.
+    // TODO(zanderso): Distinguish among build modes.
     final String outDir = getFuchsiaBuildDirectory();
     final String pkgDir = globals.fs.path.join(outDir, 'pkg');
     final String appName = project.project.manifest.appName;

packages/flutter_tools/lib/src/fuchsia/fuchsia_build.dart

@@ -173,7 +173,7 @@ void _rewriteCmx(BuildMode mode, String runnerPackageSource, File src, File dst)
   dst.writeAsStringSync(json.encode(cmx));
 }
 
-// TODO(zra): Allow supplying a signing key.
+// TODO(zanderso): Allow supplying a signing key.
 Future<void> _buildPackage(
   FuchsiaProject fuchsiaProject,
   String target, // lib/main.dart

packages/flutter_tools/lib/src/fuchsia/fuchsia_kernel_compiler.dart

@@ -25,7 +25,7 @@ class FuchsiaKernelCompiler {
     @required String target, // E.g., lib/main.dart
     BuildInfo buildInfo = BuildInfo.debug,
   }) async {
-    // TODO(zra): Use filesystem root and scheme information from buildInfo.
+    // TODO(zanderso): Use filesystem root and scheme information from buildInfo.
     const String multiRootScheme = 'main-root';
     final String packagesFile = fuchsiaProject.project.packagesFile.path;
     final String outDir = getFuchsiaBuildDirectory();

packages/flutter_tools/lib/src/fuchsia/fuchsia_sdk.dart

@@ -144,7 +144,7 @@ class FuchsiaArtifacts {
     }
     // If FUCHSIA_BUILD_DIR is defined, then look for the ssh_config dir
     // relative to it. Next, if FUCHSIA_SSH_CONFIG is defined, then use it.
-    // TODO(zra): Consider passing the ssh config path in with a flag.
+    // TODO(zanderso): Consider passing the ssh config path in with a flag.
     File sshConfig;
     if (globals.platform.environment.containsKey(_kFuchsiaBuildDir)) {
       sshConfig = globals.fs.file(globals.fs.path.join(

packages/flutter_tools/lib/src/isolated/devfs_web.dart

@@ -824,7 +824,7 @@ class WebDevFS implements DevFS {
           nativeNullAssertions: nativeNullAssertions,
         ),
       );
-      // TODO(jonahwilliams): refactor the asset code in this and the regular devfs to
+      // TODO(zanderso): refactor the asset code in this and the regular devfs to
       // be shared.
       if (bundle != null) {
         await writeBundle(

packages/flutter_tools/lib/src/macos/build_macos.dart

@@ -21,7 +21,7 @@ import 'migrations/remove_macos_framework_link_and_embedding_migration.dart';
 final RegExp _anyOutput = RegExp('.*');
 
 /// Builds the macOS project through xcodebuild.
-// TODO(jonahwilliams): refactor to share code with the existing iOS code.
+// TODO(zanderso): refactor to share code with the existing iOS code.
 Future<void> buildMacOS({
   required FlutterProject flutterProject,
   required BuildInfo buildInfo,

packages/flutter_tools/lib/src/platform_plugins.dart

@@ -182,7 +182,7 @@ class IOSPlugin extends PluginPlatform {
   });
 
   factory IOSPlugin.fromYaml(String name, YamlMap yaml) {
-    assert(validate(yaml)); // TODO(jonahwilliams): https://github.com/flutter/flutter/issues/67241
+    assert(validate(yaml)); // TODO(zanderso): https://github.com/flutter/flutter/issues/67241
     return IOSPlugin(
       name: name,
       classPrefix: '',

packages/flutter_tools/lib/src/resident_runner.dart

@@ -96,7 +96,7 @@ class FlutterDevice {
     // a warning message and dump some debug information which can be
     // used to file a bug, but the compiler will still start up correctly.
     if (targetPlatform == TargetPlatform.web_javascript) {
-      // TODO(jonahwilliams): consistently provide these flags across platforms.
+      // TODO(zanderso): consistently provide these flags across platforms.
       HostArtifact platformDillArtifact;
       final List<String> extraFrontEndOptions = List<String>.of(buildInfo.extraFrontEndOptions ?? <String>[]);
       if (buildInfo.nullSafetyMode == NullSafetyMode.unsound) {
@@ -335,7 +335,7 @@ class FlutterDevice {
   Future<void> exitApps({
     @visibleForTesting Duration timeoutDelay = const Duration(seconds: 10),
   }) async {
-    // TODO(jonahwilliams): https://github.com/flutter/flutter/issues/83127
+    // TODO(zanderso): https://github.com/flutter/flutter/issues/83127
     // When updating `flutter attach` to support running without a device,
     // this will need to be changed to fall back to io exit.
     return device.stopApp(package, userIdentifier: userIdentifier);

packages/flutter_tools/lib/src/run_hot.dart

@@ -1453,7 +1453,7 @@ class ProjectFileInvalidator {
       packageConfig = await _createPackageConfig(packagesPath);
       // The frontend_server might be monitoring the package_config.json file,
       // Pub should always produce both files.
-      // TODO(jonahwilliams): remove after https://github.com/flutter/flutter/issues/55249
+      // TODO(zanderso): remove after https://github.com/flutter/flutter/issues/55249
       if (_fileSystem.path.basename(packagesPath) == '.packages') {
         final File packageConfigFile = _fileSystem.file(packagesPath)
           .parent.childDirectory('.dart_tool')

packages/flutter_tools/lib/src/runner/local_engine.dart

@@ -105,7 +105,7 @@ class LocalEngineLocator {
   Future<String?> _findEngineSourceByPackageConfig(String? packagePath) async {
     final PackageConfig packageConfig = await loadPackageConfigWithLogging(
       _fileSystem.file(
-        // TODO(jonahwilliams): update to package_config
+        // TODO(zanderso): update to package_config
         packagePath ?? _fileSystem.path.join('.packages'),
       ),
       logger: _logger,

packages/flutter_tools/lib/src/test/web_test_compiler.dart

@@ -51,7 +51,7 @@ class WebTestCompiler {
   }) async {
     LanguageVersion languageVersion = LanguageVersion(2, 8);
     HostArtifact platformDillArtifact = HostArtifact.webPlatformSoundKernelDill;
-    // TODO(jonahwilliams): to support autodetect this would need to partition the source code into a
+    // TODO(zanderso): to support autodetect this would need to partition the source code into a
     // a sound and unsound set and perform separate compilations.
     final List<String> extraFrontEndOptions = List<String>.of(buildInfo.extraFrontEndOptions);
     if (buildInfo.nullSafetyMode == NullSafetyMode.unsound || buildInfo.nullSafetyMode == NullSafetyMode.autodetect) {

packages/flutter_tools/test/general.shard/android/android_device_start_test.dart

@@ -191,8 +191,6 @@ void main() {
     processManager.addCommand(const FakeCommand(
       command: <String>['adb', '-s', '1234', 'shell', 'pm', 'list', 'packages', '--user', '10', 'FlutterApp'],
     ));
-    // TODO(jonahwilliams): investigate why this doesn't work.
-    // This doesn't work with the current Android log reader implementation.
     processManager.addCommand(const FakeCommand(
       command: <String>[
         'adb',

packages/flutter_tools/test/general.shard/android/gradle_test.dart

@@ -703,7 +703,7 @@ flutter:
       legacySettingsDotGradleFiles.readAsStringSync().split(';EOF').map<String>((String body) => body.trim()),
       contains(templateSettingsDotGradle.readAsStringSync().trim()),
     );
-    // TODO(jonahwilliams): This is an integration test and should be moved to the integration shard.
+    // TODO(zanderso): This is an integration test and should be moved to the integration shard.
   }, skip: true); // https://github.com/flutter/flutter/issues/87922
 }
 

packages/flutter_tools/test/general.shard/cache_test.dart

@@ -94,7 +94,7 @@ void main() {
       } finally {
         Cache.flutterRoot = oldRoot;
       }
-      // TODO(jonahwilliams): implement support for lock so this can be tested with the memory file system.
+      // TODO(zanderso): implement support for lock so this can be tested with the memory file system.
     }, skip: true); // https://github.com/flutter/flutter/issues/87923
 
     testWithoutContext('throws tool exit when lockfile open fails', () async {
@@ -104,7 +104,7 @@ void main() {
         .createSync(recursive: true);
 
       expect(() async => cache.lock(), throwsToolExit());
-      // TODO(jonahwilliams): implement support for lock so this can be tested with the memory file system.
+      // TODO(zanderso): implement support for lock so this can be tested with the memory file system.
     }, skip: true); // https://github.com/flutter/flutter/issues/87923
 
     testWithoutContext('should not throw when FLUTTER_ALREADY_LOCKED is set', () {

packages/flutter_tools/test/general.shard/ios/ios_device_start_nonprebuilt_test.dart

@@ -214,7 +214,7 @@ void main() {
       Platform: () => macPlatform,
       XcodeProjectInterpreter: () => fakeXcodeProjectInterpreter,
       Xcode: () => xcode,
-    }, skip: true); // TODO(jonahwilliams): clean up with https://github.com/flutter/flutter/issues/60675
+    }, skip: true); // TODO(zanderso): clean up with https://github.com/flutter/flutter/issues/60675
   });
 }
 

packages/flutter_tools/test/general.shard/project_test.dart

@@ -26,7 +26,7 @@ import '../src/context.dart';
 import '../src/fakes.dart';
 
 void main() {
-  // TODO(jonahwilliams): remove once FlutterProject is fully refactored.
+  // TODO(zanderso): remove once FlutterProject is fully refactored.
   // this is safe since no tests have expectations on the test logger.
   final BufferLogger logger = BufferLogger.test();
 

packages/flutter_tools/test/integration.shard/overall_experience_test.dart

@@ -622,5 +622,5 @@ void main() {
       '',
       'Application finished.',
     ]);
-  }, skip: Platform.isWindows); // TODO(jonahwilliams): Re-enable when this test is reliable on device lab, https://github.com/flutter/flutter/issues/81556
+  }, skip: Platform.isWindows); // TODO(zanderso): Re-enable when this test is reliable on device lab, https://github.com/flutter/flutter/issues/81556
 }