Unverified Commit f9df1935 authored by Anna Gringauze's avatar Anna Gringauze Committed by GitHub

[flutter_tools] Add bot configuration to run web_tool_tests for linux, mac, and windows (#70412)

* Move web integration tool tests to web.shard

Web integration tool tests depend on DDC changes in SDK. This change
moves them to a separate shard and subshard so CI bot configurations
can run them separately.

In particular, with will allow running those tests on dart CI flutter
HHH web bot instead of a non-web one, allowing early detection and easy
classification of issues caused by SDK changes as VM- or Web related.

* Enabled verbose mode for flaky web_tool_tests

* fixed local engine crash with --enable-asserts

* Disable failing tests, fix local engine with asserts

* Removed mac web_tool_tests bot

* Addressed CR comments

* Add disabled mac web_tool_tests and disable win web_tool_tests
parent 6cff3383
...@@ -114,6 +114,12 @@ ...@@ -114,6 +114,12 @@
"task_name": "linux_tool_tests", "task_name": "linux_tool_tests",
"flaky": false "flaky": false
}, },
{
"name": "Linux web_tool_tests",
"repo": "flutter",
"task_name": "linux_web_tool_tests",
"flaky": true
},
{ {
"name": "Linux web_benchmarks_html", "name": "Linux web_benchmarks_html",
"repo": "flutter", "repo": "flutter",
...@@ -329,6 +335,12 @@ ...@@ -329,6 +335,12 @@
"repo": "flutter", "repo": "flutter",
"task_name": "win_tool_tests", "task_name": "win_tool_tests",
"flaky": false "flaky": false
},
{
"name": "Windows web_tool_tests",
"repo": "flutter",
"task_name": "win_web_tool_tests",
"flaky": true
} }
] ]
} }
...@@ -132,6 +132,13 @@ ...@@ -132,6 +132,13 @@
"enabled":true, "enabled":true,
"run_if":["dev/", "packages/flutter_tools/", "bin/"] "run_if":["dev/", "packages/flutter_tools/", "bin/"]
}, },
{
"name":"Linux web_tool_tests",
"repo":"flutter",
"task_name":"linux_web_tool_tests",
"enabled":true,
"run_if":["dev/", "packages/flutter_tools/", "bin/"]
},
{ {
"name":"Linux web_benchmarks_html", "name":"Linux web_benchmarks_html",
"repo":"flutter", "repo":"flutter",
...@@ -290,6 +297,13 @@ ...@@ -290,6 +297,13 @@
"enabled":true, "enabled":true,
"run_if":["dev/**", "packages/flutter_tools/**", "bin/**"] "run_if":["dev/**", "packages/flutter_tools/**", "bin/**"]
}, },
{
"name":"Mac web_tool_tests",
"repo":"flutter",
"task_name":"mac_web_tool_tests",
"enabled":false,
"run_if":["dev/**", "packages/flutter_tools/**", "bin/**"]
},
{ {
"name": "Windows build_aar_module_test", "name": "Windows build_aar_module_test",
"repo": "flutter", "repo": "flutter",
...@@ -370,6 +384,12 @@ ...@@ -370,6 +384,12 @@
"repo": "flutter", "repo": "flutter",
"task_name": "win_tool_tests", "task_name": "win_tool_tests",
"enabled":true "enabled":true
},
{
"name": "Windows web_tool_tests",
"repo": "flutter",
"task_name": "win_web_tool_tests",
"enabled":false
} }
] ]
} }
...@@ -536,7 +536,8 @@ class LocalEngineArtifacts implements Artifacts { ...@@ -536,7 +536,8 @@ class LocalEngineArtifacts implements Artifacts {
@override @override
String getArtifactPath(Artifact artifact, { TargetPlatform platform, BuildMode mode }) { String getArtifactPath(Artifact artifact, { TargetPlatform platform, BuildMode mode }) {
platform ??= _currentHostPlatform(_platform); platform ??= _currentHostPlatform(_platform);
final String artifactFileName = _artifactToFileName(artifact, platform, mode); final bool isDirectoryArtifact = artifact == Artifact.flutterWebSdk || artifact == Artifact.flutterPatchedSdkPath;
final String artifactFileName = isDirectoryArtifact ? null : _artifactToFileName(artifact, platform, mode);
switch (artifact) { switch (artifact) {
case Artifact.genSnapshot: case Artifact.genSnapshot:
return _genSnapshotPath(); return _genSnapshotPath();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment