Unverified Commit f945ad99 authored by Ivan Dlugos's avatar Ivan Dlugos Committed by GitHub

Resolve dwarf paths to enable source-code mapping of stacktraces (#114767)

* feat: add "--resolve-dwarf-paths" to gen_snapshot

* chore: update tests
parent fecd5c96
...@@ -205,11 +205,11 @@ class AOTSnapshotter { ...@@ -205,11 +205,11 @@ class AOTSnapshotter {
.createSync(recursive: true); .createSync(recursive: true);
} }
// Optimization arguments. // Debugging information.
genSnapshotArgs.addAll(<String>[ genSnapshotArgs.addAll(<String>[
// Faster async/await
if (shouldSplitDebugInfo) ...<String>[ if (shouldSplitDebugInfo) ...<String>[
'--dwarf-stack-traces', '--dwarf-stack-traces',
'--resolve-dwarf-paths',
'--save-debugging-info=${_fileSystem.path.join(splitDebugInfo!, debugFilename)}', '--save-debugging-info=${_fileSystem.path.join(splitDebugInfo!, debugFilename)}',
], ],
if (dartObfuscation) if (dartObfuscation)
......
...@@ -209,6 +209,7 @@ void main() { ...@@ -209,6 +209,7 @@ void main() {
'--snapshot_kind=app-aot-assembly', '--snapshot_kind=app-aot-assembly',
'--assembly=$assembly', '--assembly=$assembly',
'--dwarf-stack-traces', '--dwarf-stack-traces',
'--resolve-dwarf-paths',
'--save-debugging-info=$debugPath', '--save-debugging-info=$debugPath',
'main.dill', 'main.dill',
]), ]),
...@@ -444,6 +445,7 @@ void main() { ...@@ -444,6 +445,7 @@ void main() {
'--no-sim-use-hardfp', '--no-sim-use-hardfp',
'--no-use-integer-division', '--no-use-integer-division',
'--dwarf-stack-traces', '--dwarf-stack-traces',
'--resolve-dwarf-paths',
'--save-debugging-info=$debugPath', '--save-debugging-info=$debugPath',
'main.dill', 'main.dill',
] ]
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment