Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
f82794c9
Unverified
Commit
f82794c9
authored
May 09, 2021
by
Dan Field
Committed by
GitHub
May 09, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix missing logger (#82064)
parent
b3f7ebe0
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
6 deletions
+7
-6
drive_service.dart
packages/flutter_tools/lib/src/drive/drive_service.dart
+1
-1
vmservice.dart
packages/flutter_tools/lib/src/vmservice.dart
+4
-4
drive_service_test.dart
...er_tools/test/general.shard/drive/drive_service_test.dart
+2
-1
No files found.
packages/flutter_tools/lib/src/drive/drive_service.dart
View file @
f82794c9
...
@@ -220,7 +220,7 @@ class FlutterDriverService extends DriverService {
...
@@ -220,7 +220,7 @@ class FlutterDriverService extends DriverService {
// This can be ignored to continue to use the existing remote DDS instance.
// This can be ignored to continue to use the existing remote DDS instance.
}
}
}
}
_vmService
=
await
_vmServiceConnector
(
uri
,
device:
_device
);
_vmService
=
await
_vmServiceConnector
(
uri
,
device:
_device
,
logger:
_logger
);
final
DeviceLogReader
logReader
=
await
device
.
getLogReader
(
app:
_applicationPackage
);
final
DeviceLogReader
logReader
=
await
device
.
getLogReader
(
app:
_applicationPackage
);
logReader
.
logLines
.
listen
(
_logger
.
printStatus
);
logReader
.
logLines
.
listen
(
_logger
.
printStatus
);
...
...
packages/flutter_tools/lib/src/vmservice.dart
View file @
f82794c9
...
@@ -168,7 +168,7 @@ typedef VMServiceConnector = Future<FlutterVmService> Function(Uri httpUri, {
...
@@ -168,7 +168,7 @@ typedef VMServiceConnector = Future<FlutterVmService> Function(Uri httpUri, {
PrintStructuredErrorLogMethod
printStructuredErrorLogMethod
,
PrintStructuredErrorLogMethod
printStructuredErrorLogMethod
,
io
.
CompressionOptions
compression
,
io
.
CompressionOptions
compression
,
Device
device
,
Device
device
,
Logger
logger
,
@required
Logger
logger
,
});
});
/// Set up the VM Service client by attaching services for each of the provided
/// Set up the VM Service client by attaching services for each of the provided
...
@@ -330,7 +330,7 @@ Future<vm_service.VmService> createVmServiceDelegate(
...
@@ -330,7 +330,7 @@ Future<vm_service.VmService> createVmServiceDelegate(
Uri
wsUri
,
{
Uri
wsUri
,
{
io
.
CompressionOptions
compression
=
io
.
CompressionOptions
.
compressionDefault
,
io
.
CompressionOptions
compression
=
io
.
CompressionOptions
.
compressionDefault
,
@required
Logger
logger
,
@required
Logger
logger
,
})
async
{
})
async
{
final
io
.
WebSocket
channel
=
await
_openChannel
(
wsUri
.
toString
(),
compression:
compression
,
logger:
logger
);
final
io
.
WebSocket
channel
=
await
_openChannel
(
wsUri
.
toString
(),
compression:
compression
,
logger:
logger
);
return
vm_service
.
VmService
(
return
vm_service
.
VmService
(
channel
,
channel
,
...
...
packages/flutter_tools/test/general.shard/drive/drive_service_test.dart
View file @
f82794c9
...
@@ -395,8 +395,9 @@ FlutterDriverService setUpDriverService({
...
@@ -395,8 +395,9 @@ FlutterDriverService setUpDriverService({
PrintStructuredErrorLogMethod
printStructuredErrorLogMethod
,
PrintStructuredErrorLogMethod
printStructuredErrorLogMethod
,
Object
compression
,
Object
compression
,
Device
device
,
Device
device
,
Logger
logger
,
@required
Logger
logger
,
})
async
{
})
async
{
assert
(
logger
!=
null
);
if
(
httpUri
.
scheme
!=
'http'
)
{
if
(
httpUri
.
scheme
!=
'http'
)
{
fail
(
'Expected an HTTP scheme, found
$httpUri
'
);
fail
(
'Expected an HTTP scheme, found
$httpUri
'
);
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment