Unverified Commit f82794c9 authored by Dan Field's avatar Dan Field Committed by GitHub

Fix missing logger (#82064)

parent b3f7ebe0
...@@ -220,7 +220,7 @@ class FlutterDriverService extends DriverService { ...@@ -220,7 +220,7 @@ class FlutterDriverService extends DriverService {
// This can be ignored to continue to use the existing remote DDS instance. // This can be ignored to continue to use the existing remote DDS instance.
} }
} }
_vmService = await _vmServiceConnector(uri, device: _device); _vmService = await _vmServiceConnector(uri, device: _device, logger: _logger);
final DeviceLogReader logReader = await device.getLogReader(app: _applicationPackage); final DeviceLogReader logReader = await device.getLogReader(app: _applicationPackage);
logReader.logLines.listen(_logger.printStatus); logReader.logLines.listen(_logger.printStatus);
......
...@@ -168,7 +168,7 @@ typedef VMServiceConnector = Future<FlutterVmService> Function(Uri httpUri, { ...@@ -168,7 +168,7 @@ typedef VMServiceConnector = Future<FlutterVmService> Function(Uri httpUri, {
PrintStructuredErrorLogMethod printStructuredErrorLogMethod, PrintStructuredErrorLogMethod printStructuredErrorLogMethod,
io.CompressionOptions compression, io.CompressionOptions compression,
Device device, Device device,
Logger logger, @required Logger logger,
}); });
/// Set up the VM Service client by attaching services for each of the provided /// Set up the VM Service client by attaching services for each of the provided
...@@ -328,9 +328,9 @@ Future<FlutterVmService> connectToVmService( ...@@ -328,9 +328,9 @@ Future<FlutterVmService> connectToVmService(
Future<vm_service.VmService> createVmServiceDelegate( Future<vm_service.VmService> createVmServiceDelegate(
Uri wsUri, { Uri wsUri, {
io.CompressionOptions compression = io.CompressionOptions.compressionDefault, io.CompressionOptions compression = io.CompressionOptions.compressionDefault,
@required Logger logger, @required Logger logger,
}) async { }) async {
final io.WebSocket channel = await _openChannel(wsUri.toString(), compression: compression, logger: logger); final io.WebSocket channel = await _openChannel(wsUri.toString(), compression: compression, logger: logger);
return vm_service.VmService( return vm_service.VmService(
channel, channel,
......
...@@ -395,8 +395,9 @@ FlutterDriverService setUpDriverService({ ...@@ -395,8 +395,9 @@ FlutterDriverService setUpDriverService({
PrintStructuredErrorLogMethod printStructuredErrorLogMethod, PrintStructuredErrorLogMethod printStructuredErrorLogMethod,
Object compression, Object compression,
Device device, Device device,
Logger logger, @required Logger logger,
}) async { }) async {
assert(logger != null);
if (httpUri.scheme != 'http') { if (httpUri.scheme != 'http') {
fail('Expected an HTTP scheme, found $httpUri'); fail('Expected an HTTP scheme, found $httpUri');
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment