Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
f7d0aa03
Commit
f7d0aa03
authored
Mar 28, 2017
by
Jason Simmons
Committed by
GitHub
Mar 28, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Throw an exception if flutter run fails during a microbenchmark (#9061)
parent
0ec3ffb4
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
0 deletions
+8
-0
microbenchmarks.dart
dev/devicelab/lib/tasks/microbenchmarks.dart
+8
-0
No files found.
dev/devicelab/lib/tasks/microbenchmarks.dart
View file @
f7d0aa03
...
...
@@ -79,6 +79,7 @@ Future<Map<String, double>> _readJsonResults(Process process) {
StreamSubscription
<
String
>
stdoutSub
;
int
prefixLength
=
0
;
bool
processKilled
=
false
;
stdoutSub
=
process
.
stdout
.
transform
(
const
Utf8Decoder
())
.
transform
(
const
LineSplitter
())
...
...
@@ -94,6 +95,7 @@ Future<Map<String, double>> _readJsonResults(Process process) {
if
(
line
.
contains
(
jsonEnd
))
{
jsonStarted
=
false
;
stdoutSub
.
cancel
();
processKilled
=
true
;
process
.
kill
(
ProcessSignal
.
SIGINT
);
// flutter run doesn't quit automatically
completer
.
complete
(
JSON
.
decode
(
jsonBuf
.
toString
()));
return
;
...
...
@@ -103,5 +105,11 @@ Future<Map<String, double>> _readJsonResults(Process process) {
jsonBuf
.
writeln
(
line
.
substring
(
prefixLength
));
});
process
.
exitCode
.
then
<
int
>((
int
code
)
{
if
(!
processKilled
&&
code
!=
0
)
{
completer
.
completeError
(
'flutter run failed: exit code=
$code
'
);
}
});
return
completer
.
future
;
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment