Unverified Commit f570e046 authored by Chris Bracken's avatar Chris Bracken Committed by GitHub

Inline buildScriptSnapshot calls (#16940)

parent 993f3947
...@@ -375,15 +375,6 @@ void main() { ...@@ -375,15 +375,6 @@ void main() {
})); }));
} }
Future<Null> buildScriptSnapshot({ String mainPath = 'main.dart' }) {
return snapshotter.buildScriptSnapshot(
mainPath: mainPath,
snapshotPath: 'output.snapshot',
depfilePath: 'output.snapshot.d',
packagesPath: '.packages',
);
}
void expectFingerprintHas({ void expectFingerprintHas({
String entryPoint: 'main.dart', String entryPoint: 'main.dart',
Map<String, String> checksums = const <String, String>{}, Map<String, String> checksums = const <String, String>{},
...@@ -402,7 +393,12 @@ void main() { ...@@ -402,7 +393,12 @@ void main() {
await fs.file('main.dart').writeAsString('void main() {}'); await fs.file('main.dart').writeAsString('void main() {}');
await fs.file('output.snapshot').create(); await fs.file('output.snapshot').create();
await fs.file('output.snapshot.d').writeAsString('snapshot : main.dart'); await fs.file('output.snapshot.d').writeAsString('snapshot : main.dart');
await buildScriptSnapshot(); await snapshotter.buildScriptSnapshot(
mainPath: 'main.dart',
snapshotPath: 'output.snapshot',
depfilePath: 'output.snapshot.d',
packagesPath: '.packages',
);
expect(genSnapshot.callCount, 1); expect(genSnapshot.callCount, 1);
expect(genSnapshot.snapshotType.platform, isNull); expect(genSnapshot.snapshotType.platform, isNull);
...@@ -431,7 +427,12 @@ void main() { ...@@ -431,7 +427,12 @@ void main() {
'main.dart': '27f5ebf0f8c559b2af9419d190299a5e', 'main.dart': '27f5ebf0f8c559b2af9419d190299a5e',
'output.snapshot': 'deadbeef000b204e9800998ecaaaaa', 'output.snapshot': 'deadbeef000b204e9800998ecaaaaa',
}); });
await buildScriptSnapshot(); await snapshotter.buildScriptSnapshot(
mainPath: 'main.dart',
snapshotPath: 'output.snapshot',
depfilePath: 'output.snapshot.d',
packagesPath: '.packages',
);
expect(genSnapshot.callCount, 1); expect(genSnapshot.callCount, 1);
expectFingerprintHas(checksums: <String, String>{ expectFingerprintHas(checksums: <String, String>{
...@@ -447,7 +448,12 @@ void main() { ...@@ -447,7 +448,12 @@ void main() {
'main.dart': '27f5ebf0f8c559b2af9419d190299a5e', 'main.dart': '27f5ebf0f8c559b2af9419d190299a5e',
'output.snapshot': 'd41d8cd98f00b204e9800998ecf8427e', 'output.snapshot': 'd41d8cd98f00b204e9800998ecf8427e',
}); });
await buildScriptSnapshot(); await snapshotter.buildScriptSnapshot(
mainPath: 'main.dart',
snapshotPath: 'output.snapshot',
depfilePath: 'output.snapshot.d',
packagesPath: '.packages',
);
expect(genSnapshot.callCount, 1); expect(genSnapshot.callCount, 1);
expectFingerprintHas(checksums: <String, String>{ expectFingerprintHas(checksums: <String, String>{
...@@ -476,7 +482,12 @@ void main() { ...@@ -476,7 +482,12 @@ void main() {
'other.dart': 'e0c35f083f0ad76b2d87100ec678b516', 'other.dart': 'e0c35f083f0ad76b2d87100ec678b516',
'output.snapshot': 'd41d8cd98f00b204e9800998ecf8427e', 'output.snapshot': 'd41d8cd98f00b204e9800998ecf8427e',
}); });
await buildScriptSnapshot(mainPath: 'other.dart'); await snapshotter.buildScriptSnapshot(
mainPath: 'other.dart',
snapshotPath: 'output.snapshot',
depfilePath: 'output.snapshot.d',
packagesPath: '.packages',
);
expect(genSnapshot.callCount, 1); expect(genSnapshot.callCount, 1);
expectFingerprintHas( expectFingerprintHas(
...@@ -499,7 +510,12 @@ void main() { ...@@ -499,7 +510,12 @@ void main() {
'main.dart': '27f5ebf0f8c559b2af9419d190299a5e', 'main.dart': '27f5ebf0f8c559b2af9419d190299a5e',
'output.snapshot': 'd41d8cd98f00b204e9800998ecf8427e', 'output.snapshot': 'd41d8cd98f00b204e9800998ecf8427e',
}); });
await buildScriptSnapshot(); await snapshotter.buildScriptSnapshot(
mainPath: 'main.dart',
snapshotPath: 'output.snapshot',
depfilePath: 'output.snapshot.d',
packagesPath: '.packages',
);
expect(genSnapshot.callCount, 0); expect(genSnapshot.callCount, 0);
expectFingerprintHas(checksums: <String, String>{ expectFingerprintHas(checksums: <String, String>{
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment