Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
f534aa00
Unverified
Commit
f534aa00
authored
Apr 26, 2021
by
Ian Hickson
Committed by
GitHub
Apr 26, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix race condition in overall_experience_test (#81091)
parent
5e2f8631
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
7 additions
and
5 deletions
+7
-5
overall_experience_test.dart
...tools/test/integration.shard/overall_experience_test.dart
+7
-5
No files found.
packages/flutter_tools/test/integration.shard/overall_experience_test.dart
View file @
f534aa00
...
...
@@ -331,13 +331,13 @@ void main() {
processManager
.
killPid
(
pid
,
ProcessSignal
.
sigusr1
);
return
null
;
}),
Barrier
(
RegExp
(
r'^Performing hot reload\.\.\.'
),
logging:
true
),
Barrier
(
RegExp
(
r'^Performing hot reload\.\.\.'
),
logging:
true
),
// sometimes this includes the "called reassemble" message
Multiple
(<
Pattern
>[
RegExp
(
r'^Reloaded 0 libraries in [0-9]+ms\.$'
),
/*'called reassemble', (see TODO below)*/
'called paint'
],
handler:
(
String
line
)
{
processManager
.
killPid
(
pid
,
ProcessSignal
.
sigusr2
);
return
null
;
}),
Barrier
(
RegExp
(
r'^Performing hot restart\.\.\.'
)),
Multiple
(<
Pattern
>[
RegExp
(
r'^Restarted application in [0-9]+ms.$'
),
'called main'
,
'called paint'
],
handler:
(
String
line
)
{
Barrier
(
RegExp
(
r'^Performing hot restart\.\.\.'
)),
// sametimes this includes the "called main" message
Multiple
(<
Pattern
>[
RegExp
(
r'^Restarted application in [0-9]+ms.$'
),
/*'called main', (see TODO below)*/
'called paint'
],
handler:
(
String
line
)
{
return
'q'
;
}),
const
Barrier
(
'Application finished.'
),
...
...
@@ -349,13 +349,15 @@ void main() {
// is verified by the expected transitions above.
// TODO(ianh): Fix the tool so that the output isn't garbled (right now we're putting debug output from
// the app on the line where we're spinning the busy signal, rather than adding a newline).
expect
(
result
.
stdout
.
where
((
String
line
)
=>
line
.
startsWith
(
'called '
)
&&
line
!=
'called reassemble'
/* see todo above*/
),
<
Object
>[
expect
(
result
.
stdout
.
where
((
String
line
)
=>
line
.
startsWith
(
'called '
)
&&
line
!=
'called reassemble'
/* see todo above*/
&&
line
!=
'called main'
/* see todo above*/
),
<
Object
>[
// logs start after we receive the response to sending SIGUSR1
// SIGUSR1:
// 'called reassemble', // see todo above, this only sometimes gets included, other times it's on the "performing..." line
'called paint'
,
// SIGUSR2:
'called main'
,
// 'called main', // see todo above, this is sometimes on the "performing..." line
'called paint'
,
]);
expect
(
result
.
stdout
.
where
((
String
line
)
=>
!
line
.
startsWith
(
'called '
)),
<
Object
>[
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment