Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
f51d3d7e
Unverified
Commit
f51d3d7e
authored
Nov 19, 2021
by
sigmundch
Committed by
GitHub
Nov 19, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[Web] Detect when running under Dart HHH Web and skip tests under investigation (#93692)
parent
7d098177
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
4 deletions
+9
-4
test.dart
dev/bots/test.dart
+6
-3
editable_test.dart
packages/flutter/test/rendering/editable_test.dart
+3
-1
No files found.
dev/bots/test.dart
View file @
f51d3d7e
...
...
@@ -220,17 +220,19 @@ Future<void> main(List<String> args) async {
print
(
'
$clock
${bold}
Test successful.
$reset
'
);
}
final
String
_luciBotId
=
Platform
.
environment
[
'SWARMING_BOT_ID'
]
??
''
;
final
bool
_runningInDartHHHBot
=
_luciBotId
.
startsWith
(
'luci-dart-'
);
/// Verify the Flutter Engine is the revision in
/// bin/cache/internal/engine.version.
Future
<
void
>
_validateEngineHash
()
async
{
final
String
luciBotId
=
Platform
.
environment
[
'SWARMING_BOT_ID'
]
??
''
;
if
(
luciBotId
.
startsWith
(
'luci-dart-'
))
{
if
(
_runningInDartHHHBot
)
{
// The Dart HHH bots intentionally modify the local artifact cache
// and then use this script to run Flutter's test suites.
// Because the artifacts have been changed, this particular test will return
// a false positive and should be skipped.
print
(
'
${yellow}
Skipping Flutter Engine Version Validation for swarming '
'bot
$luciBotId
.'
);
'bot
$
_
luciBotId
.'
);
return
;
}
final
String
expectedVersion
=
File
(
engineVersionFile
).
readAsStringSync
().
trim
();
...
...
@@ -1506,6 +1508,7 @@ Future<void> _runFlutterWebTest(String webRenderer, String workingDirectory, Lis
'-v'
,
'--platform=chrome'
,
'--web-renderer=
$webRenderer
'
,
'--dart-define=DART_HHH_BOT=
$_runningInDartHHHBot
'
,
'--sound-null-safety'
,
...
flutterTestArgs
,
...
tests
,
...
...
packages/flutter/test/rendering/editable_test.dart
View file @
f51d3d7e
...
...
@@ -883,7 +883,9 @@ void main() {
editable
.
layout
(
BoxConstraints
.
loose
(
const
Size
(
1000.0
,
1000.0
)));
expect
(
editable
.
maxScrollExtent
,
equals
(
10
));
});
// TODO(yjbanov): This test is failing in the Dart HHH-web bot and
// needs additional investigation before it can be reenabled.
},
skip:
const
bool
.
fromEnvironment
(
'DART_HHH_BOT'
));
// https://github.com/flutter/flutter/issues/93691
test
(
'getEndpointsForSelection handles empty characters'
,
()
{
final
TextSelectionDelegate
delegate
=
_FakeEditableTextState
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment