Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
f0c97104
Unverified
Commit
f0c97104
authored
Apr 14, 2021
by
Christopher Casey
Committed by
GitHub
Apr 14, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add --dart-define to build bundle (#80333)
parent
36daea2d
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
30 additions
and
0 deletions
+30
-0
build_bundle.dart
packages/flutter_tools/lib/src/commands/build_bundle.dart
+1
-0
build_bundle_test.dart
...ools/test/commands.shard/permeable/build_bundle_test.dart
+29
-0
No files found.
packages/flutter_tools/lib/src/commands/build_bundle.dart
View file @
f0c97104
...
...
@@ -21,6 +21,7 @@ class BuildBundleCommand extends BuildSubCommand {
usesFilesystemOptions
(
hide:
!
verboseHelp
);
usesBuildNumberOption
();
addBuildModeFlags
(
verboseHelp:
verboseHelp
,
defaultToRelease:
false
);
usesDartDefineOption
();
usesExtraDartFlagOptions
(
verboseHelp:
verboseHelp
);
argParser
..
addOption
(
'depfile'
,
...
...
packages/flutter_tools/test/commands.shard/permeable/build_bundle_test.dart
View file @
f0c97104
...
...
@@ -7,6 +7,7 @@
import
'package:args/command_runner.dart'
;
import
'package:file/memory.dart'
;
import
'package:flutter_tools/src/base/file_system.dart'
;
import
'package:flutter_tools/src/build_info.dart'
;
import
'package:flutter_tools/src/build_system/build_system.dart'
;
import
'package:flutter_tools/src/build_system/targets/common.dart'
;
import
'package:flutter_tools/src/build_system/targets/icon_tree_shaker.dart'
;
...
...
@@ -232,6 +233,34 @@ void main() {
FileSystem:
()
=>
MemoryFileSystem
.
test
(),
ProcessManager:
()
=>
FakeProcessManager
.
any
(),
});
testUsingContext
(
'passes dart-define through'
,
()
async
{
globals
.
fs
.
file
(
'lib/main.dart'
).
createSync
(
recursive:
true
);
globals
.
fs
.
file
(
'pubspec.yaml'
).
createSync
();
globals
.
fs
.
file
(
'.packages'
).
createSync
();
final
CommandRunner
<
void
>
runner
=
createTestCommandRunner
(
BuildBundleCommand
());
await
runner
.
run
(<
String
>[
'bundle'
,
'--no-pub'
,
'--debug'
,
'--target-platform=android-arm'
,
'--dart-define=foo=bar'
]);
},
overrides:
<
Type
,
Generator
>{
BuildSystem:
()
=>
TestBuildSystem
.
all
(
BuildResult
(
success:
true
),
(
Target
target
,
Environment
environment
)
{
expect
(
environment
.
defines
,
<
String
,
String
>{
kTargetFile:
globals
.
fs
.
path
.
join
(
'lib'
,
'main.dart'
),
kBuildMode:
'debug'
,
kTargetPlatform:
'android-arm'
,
kTrackWidgetCreation:
'true'
,
kIconTreeShakerFlag:
null
,
kDartDefines:
'Zm9vPWJhcg=='
,
});
}),
FileSystem:
()
=>
MemoryFileSystem
.
test
(),
ProcessManager:
()
=>
FakeProcessManager
.
any
(),
});
}
class
MockBundleBuilder
extends
Mock
implements
BundleBuilder
{}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment