Support for overriding Gallery feedback menu item behavior (#7091)

examples/flutter_gallery/lib/gallery/app.dart

@@ -31,6 +31,7 @@ class GalleryApp extends StatefulWidget {
     this.updateUrlFetcher,
     this.enablePerformanceOverlay: true,
     this.checkerboardRasterCacheImages: true,
+    this.onSendFeedback,
     Key key}
   ) : super(key: key);
 
@@ -40,6 +41,8 @@ class GalleryApp extends StatefulWidget {
 
   final bool checkerboardRasterCacheImages;
 
+  final VoidCallback onSendFeedback;
+
   @override
   GalleryAppState createState() => new GalleryAppState();
 }
@@ -83,6 +86,7 @@ class GalleryAppState extends State<GalleryApp> {
           timeDilation = value;
         });
       },
+      onSendFeedback: config.onSendFeedback,
     );
 
     if (config.updateUrlFetcher != null) {

examples/flutter_gallery/lib/gallery/drawer.dart

@@ -97,6 +97,7 @@ class GalleryDrawer extends StatelessWidget {
     this.checkerboardRasterCacheImages,
     this.onCheckerboardRasterCacheImagesChanged,
     this.onPlatformChanged,
+    this.onSendFeedback,
   }) : super(key: key) {
     assert(onThemeChanged != null);
     assert(onTimeDilationChanged != null);
@@ -116,6 +117,8 @@ class GalleryDrawer extends StatelessWidget {
 
   final ValueChanged<TargetPlatform> onPlatformChanged;
 
+  final VoidCallback onSendFeedback;
+
   @override
   Widget build(BuildContext context) {
     final ThemeData themeData = Theme.of(context);
@@ -203,12 +206,12 @@ class GalleryDrawer extends StatelessWidget {
       )
     );
 
-    final Widget fileAnIssueItem = new DrawerItem(
+    final Widget sendFeedbackItem = new DrawerItem(
       icon: new Icon(Icons.report),
-      onPressed: () {
+      onPressed: onSendFeedback ?? () {
         UrlLauncher.launch('https://github.com/flutter/flutter/issues/new');
       },
-      child: new Text('File an issue')
+      child: new Text('Send feedback'),
     );
 
     final Widget aboutItem = new AboutDrawerItem(
@@ -264,7 +267,7 @@ class GalleryDrawer extends StatelessWidget {
       new Divider(),
       animateSlowlyItem,
       // index 8, optional: Performance Overlay
-      fileAnIssueItem,
+      sendFeedbackItem,
       aboutItem
     ];
 

examples/flutter_gallery/lib/gallery/home.dart

@@ -79,6 +79,7 @@ class GalleryHome extends StatefulWidget {
     this.checkerboardRasterCacheImages,
     this.onCheckerboardRasterCacheImagesChanged,
     this.onPlatformChanged,
+    this.onSendFeedback,
   }) : super(key: key) {
     assert(onThemeChanged != null);
     assert(onTimeDilationChanged != null);
@@ -98,6 +99,8 @@ class GalleryHome extends StatefulWidget {
 
   final ValueChanged<TargetPlatform> onPlatformChanged;
 
+  final VoidCallback onSendFeedback;
+
   @override
   GalleryHomeState createState() => new GalleryHomeState();
 }
@@ -164,6 +167,7 @@ class GalleryHomeState extends State<GalleryHome> with SingleTickerProviderState
         checkerboardRasterCacheImages: config.checkerboardRasterCacheImages,
         onCheckerboardRasterCacheImagesChanged: config.onCheckerboardRasterCacheImagesChanged,
         onPlatformChanged: config.onPlatformChanged,
+        onSendFeedback: config.onSendFeedback,
       ),
       appBar: new AppBar(
         expandedHeight: _kFlexibleSpaceMaxHeight,

examples/flutter_gallery/test/smoke_test.dart

@@ -49,7 +49,12 @@ Future<Null> smokeDemo(WidgetTester tester, String routeName) async {
 }
 
 Future<Null> runSmokeTest(WidgetTester tester) async {
-  await tester.pumpWidget(new GalleryApp());
+  bool hasFeedback = false;
+  void mockOnSendFeedback() {
+    hasFeedback = true;
+  }
+
+  await tester.pumpWidget(new GalleryApp(onSendFeedback: mockOnSendFeedback));
   await tester.pump(); // see https://github.com/flutter/flutter/issues/1865
   await tester.pump(); // triggers a frame
 
@@ -89,6 +94,12 @@ Future<Null> runSmokeTest(WidgetTester tester) async {
   await tester.tap(find.text('Light'));
   await tester.pump();
   await tester.pump(const Duration(seconds: 1)); // Wait until it's changed.
+
+  // send feedback
+  expect(hasFeedback, false);
+  await tester.tap(find.text('Send feedback'));
+  await tester.pump();
+  expect(hasFeedback, true);
 }
 
 void main() {