Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
f0b0b284
Unverified
Commit
f0b0b284
authored
Sep 16, 2022
by
Kate Lovett
Committed by
GitHub
Sep 16, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Reset missing deprecation for ScrollbarThemeData.copyWith(showTrackOnHover) (#111706)
parent
7f17098f
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
82 additions
and
5 deletions
+82
-5
fix_data.yaml
packages/flutter/lib/fix_data.yaml
+58
-0
scrollbar.dart
packages/flutter/lib/src/material/scrollbar.dart
+2
-2
scrollbar_theme.dart
packages/flutter/lib/src/material/scrollbar_theme.dart
+8
-3
material.dart
packages/flutter/test_fixes/material.dart
+7
-0
material.dart.expect
packages/flutter/test_fixes/material.dart.expect
+7
-0
No files found.
packages/flutter/lib/fix_data.yaml
View file @
f0b0b284
...
...
@@ -17,6 +17,64 @@
version
:
1
transforms
:
# Changes made in https://github.com/flutter/flutter/pull/111706
-
title
:
"
Migrate
to
'trackVisibility'"
date
:
2022-09-15
element
:
uris
:
[
'
material.dart'
]
field
:
'
showTrackOnHover'
inClass
:
'
Scrollbar'
changes
:
-
kind
:
'
rename'
newName
:
'
trackVisibility'
# Changes made in https://github.com/flutter/flutter/pull/111706
-
title
:
"
Migrate
to
'trackVisibility'"
date
:
2022-09-15
element
:
uris
:
[
'
material.dart'
]
constructor
:
'
'
inClass
:
'
Scrollbar'
changes
:
-
kind
:
'
renameParameter'
oldName
:
'
showTrackOnHover'
newName
:
'
trackVisibility'
# Changes made in https://github.com/flutter/flutter/pull/111706
-
title
:
"
Migrate
to
'trackVisibility'"
date
:
2022-09-15
element
:
uris
:
[
'
material.dart'
]
field
:
'
showTrackOnHover'
inClass
:
'
ScrollbarThemeData'
changes
:
-
kind
:
'
rename'
newName
:
'
trackVisibility'
# Changes made in https://github.com/flutter/flutter/pull/111706
-
title
:
"
Migrate
to
'thumbVisibility'"
date
:
2022-09-15
element
:
uris
:
[
'
material.dart'
]
constructor
:
'
'
inClass
:
'
ScrollbarThemeData'
changes
:
-
kind
:
'
renameParameter'
oldName
:
'
showTrackOnHover'
newName
:
'
trackVisibility'
# Changes made in https://github.com/flutter/flutter/pull/111706
-
title
:
"
Migrate
to
'trackVisibility'"
date
:
2022-09-15
element
:
uris
:
[
'
material.dart'
]
method
:
'
copyWith'
inClass
:
'
ScrollbarThemeData'
changes
:
-
kind
:
'
renameParameter'
oldName
:
'
showTrackOnHover'
newName
:
'
trackVisibility'
# Changes made in https://github.com/flutter/flutter/pull/111080
-
title
:
"
Migrate
to
'BottomAppBarTheme.color'"
date
:
2022-09-07
...
...
packages/flutter/lib/src/material/scrollbar.dart
View file @
f0b0b284
...
...
@@ -102,7 +102,7 @@ class Scrollbar extends StatelessWidget {
this
.
isAlwaysShown
,
@Deprecated
(
'Use ScrollbarThemeData.trackVisibility to resolve based on the current state instead. '
'This feature was deprecated after v
2.9.0-1
.0.pre.'
,
'This feature was deprecated after v
3.4.0-19
.0.pre.'
,
)
this
.
showTrackOnHover
,
@Deprecated
(
...
...
@@ -168,7 +168,7 @@ class Scrollbar extends StatelessWidget {
/// should be used instead.
@Deprecated
(
'Use ScrollbarThemeData.trackVisibility to resolve based on the current state instead. '
'This feature was deprecated after v
2.9.0-1
.0.pre.'
,
'This feature was deprecated after v
3.4.0-19
.0.pre.'
,
)
final
bool
?
showTrackOnHover
;
...
...
packages/flutter/lib/src/material/scrollbar_theme.dart
View file @
f0b0b284
...
...
@@ -52,7 +52,7 @@ class ScrollbarThemeData with Diagnosticable {
this
.
isAlwaysShown
,
@Deprecated
(
'Use ScrollbarThemeData.trackVisibility to resolve based on the current state instead. '
'This feature was deprecated after v
2.9.0-1
.0.pre.'
,
'This feature was deprecated after v
3.4.0-19
.0.pre.'
,
)
this
.
showTrackOnHover
,
})
:
assert
(
...
...
@@ -82,7 +82,7 @@ class ScrollbarThemeData with Diagnosticable {
/// descendant [Scrollbar] widgets.
@Deprecated
(
'Use ScrollbarThemeData.trackVisibility to resolve based on the current state instead. '
'This feature was deprecated after v
2.9.0-1
.0.pre.'
,
'This feature was deprecated after v
3.4.0-19
.0.pre.'
,
)
final
bool
?
showTrackOnHover
;
...
...
@@ -161,7 +161,6 @@ class ScrollbarThemeData with Diagnosticable {
MaterialStateProperty
<
bool
?>?
thumbVisibility
,
MaterialStateProperty
<
double
?>?
thickness
,
MaterialStateProperty
<
bool
?>?
trackVisibility
,
bool
?
showTrackOnHover
,
bool
?
interactive
,
Radius
?
radius
,
MaterialStateProperty
<
Color
?>?
thumbColor
,
...
...
@@ -175,6 +174,12 @@ class ScrollbarThemeData with Diagnosticable {
'This feature was deprecated after v2.9.0-1.0.pre.'
,
)
bool
?
isAlwaysShown
,
@Deprecated
(
'Use ScrollbarThemeData.trackVisibility to resolve based on the current state instead. '
'This feature was deprecated after v3.4.0-19.0.pre.'
,
)
bool
?
showTrackOnHover
,
})
{
return
ScrollbarThemeData
(
thumbVisibility:
thumbVisibility
??
this
.
thumbVisibility
,
...
...
packages/flutter/test_fixes/material.dart
View file @
f0b0b284
...
...
@@ -694,4 +694,11 @@ void main() {
themeData
=
ThemeData
(
bottomAppBarColor:
Colors
.
green
);
themeData
=
ThemeData
.
raw
(
bottomAppBarColor:
Colors
.
green
);
themeData
=
ThemeData
.
copyWith
(
bottomAppBarColor:
Colors
.
green
);
// Changes made in https://github.com/flutter/flutter/pull/111706
Scrollbar
scrollbar
=
Scrollbar
(
showTrackOnHover:
true
);
bool
nowShowing
=
scrollbar
.
showTrackOnHover
;
ScrollbarThemeData
scrollbarTheme
=
ScrollbarThemeData
(
showTrackOnHover:
nowShowing
);
scrollbarTheme
.
copyWith
(
showTrackOnHover:
nowShowing
);
scrollbarTheme
.
showTrackOnHover
;
}
packages/flutter/test_fixes/material.dart.expect
View file @
f0b0b284
...
...
@@ -898,4 +898,11 @@ void main() {
themeData = ThemeData(bottomAppBarTheme: BottomAppBarTheme(color: Colors.green));
themeData = ThemeData.raw(bottomAppBarTheme: BottomAppBarTheme(color: Colors.green));
themeData = ThemeData.copyWith(bottomAppBarTheme: BottomAppBarTheme(color: Colors.green));
// Changes made in https://github.com/flutter/flutter/pull/111706
Scrollbar scrollbar = Scrollbar(trackVisibility: true);
bool nowShowing = scrollbar.trackVisibility;
ScrollbarThemeData scrollbarTheme = ScrollbarThemeData(trackVisibility: nowShowing);
scrollbarTheme.copyWith(trackVisibility: nowShowing);
scrollbarTheme.trackVisibility;
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment