Skip to content

F
Front-End
Commit ecc590f9 authored by Chris Bracken's avatar Chris Bracken Committed by GitHub
Browse files
Options

Eliminate WidgetTester.idle() after enterText() (#9290) 

enterText() now includes a call to idle().
parent a7a95daa
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 14 deletions
packages/flutter/test/material/text_field_test.dart
View file @ ecc590f9
...@@ -103,7 +103,6 @@ void main() { ...@@ -103,7 +103,6 @@ void main() {
Future<Null> checkText(String testValue) async { Future<Null> checkText(String testValue) async {
await tester.enterText(find.byType(EditableText), testValue); await tester.enterText(find.byType(EditableText), testValue);
await tester.idle();
// Check that the onChanged event handler fired. // Check that the onChanged event handler fired.
expect(textFieldValue, equals(testValue)); expect(textFieldValue, equals(testValue));
...@@ -210,7 +209,6 @@ void main() { ...@@ -210,7 +209,6 @@ void main() {
final String testValue = 'abc def ghi'; final String testValue = 'abc def ghi';
await tester.enterText(find.byType(EditableText), testValue); await tester.enterText(find.byType(EditableText), testValue);
await tester.idle();
await tester.pumpWidget(builder()); await tester.pumpWidget(builder());
...@@ -249,7 +247,6 @@ void main() { ...@@ -249,7 +247,6 @@ void main() {
final String testValue = 'abc def ghi'; final String testValue = 'abc def ghi';
await tester.enterText(find.byType(EditableText), testValue); await tester.enterText(find.byType(EditableText), testValue);
await tester.idle();
expect(controller.value.text, testValue); expect(controller.value.text, testValue);
await tester.pumpWidget(builder()); await tester.pumpWidget(builder());
...@@ -285,7 +282,6 @@ void main() { ...@@ -285,7 +282,6 @@ void main() {
final String testValue = 'abc def ghi'; final String testValue = 'abc def ghi';
await tester.enterText(find.byType(EditableText), testValue); await tester.enterText(find.byType(EditableText), testValue);
await tester.idle();
await tester.pumpWidget(builder()); await tester.pumpWidget(builder());
...@@ -349,7 +345,6 @@ void main() { ...@@ -349,7 +345,6 @@ void main() {
final String testValue = 'abc def ghi'; final String testValue = 'abc def ghi';
await tester.enterText(find.byType(EditableText), testValue); await tester.enterText(find.byType(EditableText), testValue);
await tester.idle();
await tester.pumpWidget(builder()); await tester.pumpWidget(builder());
// Tap the selection handle to bring up the "paste / select all" menu. // Tap the selection handle to bring up the "paste / select all" menu.
...@@ -403,7 +398,6 @@ void main() { ...@@ -403,7 +398,6 @@ void main() {
final String testValue = 'abc def ghi'; final String testValue = 'abc def ghi';
await tester.enterText(find.byType(EditableText), testValue); await tester.enterText(find.byType(EditableText), testValue);
await tester.idle();
await tester.pumpWidget(builder()); await tester.pumpWidget(builder());
// Tap the selection handle to bring up the "paste / select all" menu. // Tap the selection handle to bring up the "paste / select all" menu.
...@@ -456,13 +450,11 @@ void main() { ...@@ -456,13 +450,11 @@ void main() {
final Size emptyInputSize = inputBox.size; final Size emptyInputSize = inputBox.size;
await tester.enterText(find.byType(EditableText), 'No wrapping here.'); await tester.enterText(find.byType(EditableText), 'No wrapping here.');
await tester.idle();
await tester.pumpWidget(builder(3)); await tester.pumpWidget(builder(3));
expect(findInputBox(), equals(inputBox)); expect(findInputBox(), equals(inputBox));
expect(inputBox.size, equals(emptyInputSize)); expect(inputBox.size, equals(emptyInputSize));
await tester.enterText(find.byType(EditableText), kThreeLines); await tester.enterText(find.byType(EditableText), kThreeLines);
await tester.idle();
await tester.pumpWidget(builder(3)); await tester.pumpWidget(builder(3));
expect(findInputBox(), equals(inputBox)); expect(findInputBox(), equals(inputBox));
expect(inputBox.size, greaterThan(emptyInputSize)); expect(inputBox.size, greaterThan(emptyInputSize));
...@@ -471,14 +463,12 @@ void main() { ...@@ -471,14 +463,12 @@ void main() {
// An extra line won't increase the size because we max at 3. // An extra line won't increase the size because we max at 3.
await tester.enterText(find.byType(EditableText), kFourLines); await tester.enterText(find.byType(EditableText), kFourLines);
await tester.idle();
await tester.pumpWidget(builder(3)); await tester.pumpWidget(builder(3));
expect(findInputBox(), equals(inputBox)); expect(findInputBox(), equals(inputBox));
expect(inputBox.size, threeLineInputSize); expect(inputBox.size, threeLineInputSize);
// But now it will. // But now it will.
await tester.enterText(find.byType(EditableText), kFourLines); await tester.enterText(find.byType(EditableText), kFourLines);
await tester.idle();
await tester.pumpWidget(builder(4)); await tester.pumpWidget(builder(4));
expect(findInputBox(), equals(inputBox)); expect(findInputBox(), equals(inputBox));
expect(inputBox.size, greaterThan(threeLineInputSize)); expect(inputBox.size, greaterThan(threeLineInputSize));
...@@ -504,7 +494,6 @@ void main() { ...@@ -504,7 +494,6 @@ void main() {
final String testValue = kThreeLines; final String testValue = kThreeLines;
final String cutValue = 'First line of stuff keeps going until abcdef ghijk. '; final String cutValue = 'First line of stuff keeps going until abcdef ghijk. ';
await tester.enterText(find.byType(EditableText), testValue); await tester.enterText(find.byType(EditableText), testValue);
await tester.idle();
await tester.pumpWidget(builder()); await tester.pumpWidget(builder());
...@@ -584,7 +573,6 @@ void main() { ...@@ -584,7 +573,6 @@ void main() {
await tester.pumpWidget(builder()); await tester.pumpWidget(builder());
await tester.enterText(find.byType(EditableText), kFourLines); await tester.enterText(find.byType(EditableText), kFourLines);
await tester.idle();
await tester.pumpWidget(builder()); await tester.pumpWidget(builder());
...@@ -672,7 +660,6 @@ void main() { ...@@ -672,7 +660,6 @@ void main() {
Future<Null> checkText(String testValue) async { Future<Null> checkText(String testValue) async {
await tester.enterText(find.byType(EditableText), testValue); await tester.enterText(find.byType(EditableText), testValue);
await tester.idle();
// Check that the onChanged event handler fired. // Check that the onChanged event handler fired.
expect(textFieldValue, equals(testValue)); expect(textFieldValue, equals(testValue));
...@@ -705,7 +692,6 @@ void main() { ...@@ -705,7 +692,6 @@ void main() {
Future<Null> checkText(String testValue) async { Future<Null> checkText(String testValue) async {
await tester.enterText(find.byType(EditableText), testValue); await tester.enterText(find.byType(EditableText), testValue);
await tester.idle();
// Check that the onChanged event handler fired. // Check that the onChanged event handler fired.
expect(textFieldValue, equals(testValue)); expect(textFieldValue, equals(testValue));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment

HIAST - GitLab