Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
eba2d44f
Commit
eba2d44f
authored
Mar 08, 2016
by
Adam Barth
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #2492 from abarth/intrinsics
Remove bogus intrinsic size assert
parents
4ff879b4
501b948e
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
4 additions
and
9 deletions
+4
-9
block.dart
packages/flutter/lib/src/rendering/block.dart
+0
-5
box.dart
packages/flutter/lib/src/rendering/box.dart
+2
-2
grid.dart
packages/flutter/lib/src/rendering/grid.dart
+2
-2
No files found.
packages/flutter/lib/src/rendering/block.dart
View file @
eba2d44f
...
...
@@ -151,11 +151,6 @@ class RenderBlock extends RenderBlockBase {
double
childExtent
=
isVertical
?
child
.
getMinIntrinsicHeight
(
innerConstraints
)
:
child
.
getMinIntrinsicWidth
(
innerConstraints
);
assert
(()
{
if
(
isVertical
)
return
childExtent
==
child
.
getMaxIntrinsicHeight
(
innerConstraints
);
return
childExtent
==
child
.
getMaxIntrinsicWidth
(
innerConstraints
);
});
extent
+=
childExtent
;
final
BlockParentData
childParentData
=
child
.
parentData
;
child
=
childParentData
.
nextSibling
;
...
...
packages/flutter/lib/src/rendering/box.dart
View file @
eba2d44f
...
...
@@ -419,7 +419,7 @@ abstract class RenderBox extends RenderObject {
}
/// Returns the smallest width beyond which increasing the width never
/// decreases the height.
/// decreases the
preferred
height.
///
/// Override in subclasses that implement [performLayout].
double
getMaxIntrinsicWidth
(
BoxConstraints
constraints
)
{
...
...
@@ -437,7 +437,7 @@ abstract class RenderBox extends RenderObject {
}
/// Returns the smallest height beyond which increasing the height never
/// decreases the width.
/// decreases the
preferred
width.
///
/// If the layout algorithm used is width-in-height-out, i.e. the height
/// depends on the width and not vice versa, then this will return the same
...
...
packages/flutter/lib/src/rendering/grid.dart
View file @
eba2d44f
...
...
@@ -166,7 +166,7 @@ abstract class GridDelegate {
}
/// Returns the smallest width beyond which increasing the width never
/// decreases the height.
/// decreases the
preferred
height.
double
getMaxIntrinsicWidth
(
BoxConstraints
constraints
,
int
childCount
)
{
return
constraints
.
constrainWidth
(
_getGridSize
(
constraints
,
childCount
).
width
);
}
...
...
@@ -178,7 +178,7 @@ abstract class GridDelegate {
}
/// Returns the smallest height beyond which increasing the height never
/// decreases the width.
/// decreases the
preferred
width.
double
getMaxIntrinsicHeight
(
BoxConstraints
constraints
,
int
childCount
)
{
return
constraints
.
constrainHeight
(
_getGridSize
(
constraints
,
childCount
).
height
);
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment