Unverified Commit e9e2ca16 authored by Jonah Williams's avatar Jonah Williams Committed by GitHub

Don't use dense dropdown buttons in the Gallery date/time picker demo (#21693)

parent dd1c22e3
...@@ -181,15 +181,16 @@ class _DateAndTimePickerDemoState extends State<DateAndTimePickerDemo> { ...@@ -181,15 +181,16 @@ class _DateAndTimePickerDemoState extends State<DateAndTimePickerDemo> {
}); });
}, },
), ),
const SizedBox(height: 8.0),
InputDecorator( InputDecorator(
decoration: const InputDecoration( decoration: const InputDecoration(
labelText: 'Activity', labelText: 'Activity',
hintText: 'Choose an activity', hintText: 'Choose an activity',
contentPadding: EdgeInsets.zero,
), ),
isEmpty: _activity == null, isEmpty: _activity == null,
child: DropdownButton<String>( child: DropdownButton<String>(
value: _activity, value: _activity,
isDense: true,
onChanged: (String newValue) { onChanged: (String newValue) {
setState(() { setState(() {
_activity = newValue; _activity = newValue;
......
...@@ -58,7 +58,7 @@ void main() { ...@@ -58,7 +58,7 @@ void main() {
await tester.pumpWidget(MaterialApp(home: DateAndTimePickerDemo())); await tester.pumpWidget(MaterialApp(home: DateAndTimePickerDemo()));
expect(tester, meetsGuideline(androidTapTargetGuideline)); expect(tester, meetsGuideline(androidTapTargetGuideline));
handle.dispose(); handle.dispose();
}, skip: true); // https://github.com/flutter/flutter/issues/21578 });
testWidgets('dialog_demo', (WidgetTester tester) async { testWidgets('dialog_demo', (WidgetTester tester) async {
final SemanticsHandle handle = tester.ensureSemantics(); final SemanticsHandle handle = tester.ensureSemantics();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment