Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
e98acc7d
Commit
e98acc7d
authored
Dec 05, 2019
by
Zachary Anderson
Committed by
Todd Volkert
Dec 05, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tool] Print version info on a no-op upgrade. (#46109)
parent
6d848ebf
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
2 deletions
+3
-2
upgrade.dart
packages/flutter_tools/lib/src/commands/upgrade.dart
+2
-2
upgrade_test.dart
...ter_tools/test/commands.shard/permeable/upgrade_test.dart
+1
-0
No files found.
packages/flutter_tools/lib/src/commands/upgrade.dart
View file @
e98acc7d
...
...
@@ -63,7 +63,6 @@ class UpgradeCommand extends FlutterCommand {
}
}
@visibleForTesting
class
UpgradeCommandRunner
{
Future
<
FlutterCommandResult
>
runCommand
(
...
...
@@ -120,7 +119,8 @@ class UpgradeCommandRunner {
final
bool
alreadyUpToDate
=
await
attemptFastForward
(
flutterVersion
);
if
(
alreadyUpToDate
)
{
// If the upgrade was a no op, then do not continue with the second half.
printTrace
(
'Flutter is already up to date on channel
${flutterVersion.channel}
'
);
printStatus
(
'Flutter is already up to date on channel
${flutterVersion.channel}
'
);
printStatus
(
'
$flutterVersion
'
);
}
else
{
await
flutterUpgradeContinue
();
}
...
...
packages/flutter_tools/test/commands.shard/permeable/upgrade_test.dart
View file @
e98acc7d
...
...
@@ -140,6 +140,7 @@ void main() {
environment:
anyNamed
(
'environment'
),
workingDirectory:
anyNamed
(
'workingDirectory'
),
));
expect
(
testLogger
.
statusText
,
contains
(
'Flutter is already up to date'
));
},
overrides:
<
Type
,
Generator
>{
ProcessManager:
()
=>
processManager
,
Platform:
()
=>
fakePlatform
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment