Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
e963bfe1
Unverified
Commit
e963bfe1
authored
May 05, 2020
by
Chase Latta
Committed by
GitHub
May 05, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add package_root for fuchsia_tools (#56077)
parent
d6f6fc4d
Changes
6
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
81 additions
and
0 deletions
+81
-0
BUILD.gn
packages/flutter_tools/BUILD.gn
+4
-0
README.md
packages/flutter_tools/fuchsia_entrypoint_shim/README.md
+21
-0
pubspec.yaml
...uchsia_entrypoint_shim/fuchsia_asset_builder/pubspec.yaml
+14
-0
pubspec.yaml
...tools/fuchsia_entrypoint_shim/fuchsia_attach/pubspec.yaml
+14
-0
pubspec.yaml
...ools/fuchsia_entrypoint_shim/fuchsia_builder/pubspec.yaml
+14
-0
pubspec.yaml
...tools/fuchsia_entrypoint_shim/fuchsia_tester/pubspec.yaml
+14
-0
No files found.
packages/flutter_tools/BUILD.gn
View file @
e963bfe1
...
...
@@ -57,6 +57,7 @@ dart_library("flutter_tools") {
dart_tool("fuchsia_builder") {
main_dart = "bin/fuchsia_builder.dart"
package_root = "fuchsia_entrypoint_shim/fuchsia_builder"
disable_analysis = true
...
...
@@ -67,6 +68,7 @@ dart_tool("fuchsia_builder") {
dart_tool("fuchsia_asset_builder") {
main_dart = "bin/fuchsia_asset_builder.dart"
package_root = "fuchsia_entrypoint_shim/fuchsia_asset_builder"
disable_analysis = true
...
...
@@ -153,6 +155,7 @@ dart_tool("fuchsia_asset_builder") {
dart_tool("fuchsia_tester") {
main_dart = "bin/fuchsia_tester.dart"
package_root = "fuchsia_entrypoint_shim/tester"
disable_analysis = true
...
...
@@ -248,6 +251,7 @@ dart_tool("fuchsia_tester") {
dart_tool("fuchsia_attach") {
package_name = "fuchsia_attach"
main_dart = "bin/fuchsia_attach.dart"
package_root = "fuchsia_entrypoint_shim/attach"
# Can be left empty as analysis is disabled.
sources = []
...
...
packages/flutter_tools/fuchsia_entrypoint_shim/README.md
0 → 100644
View file @
e963bfe1
This directory serves as a placeholder directory for the package roots of
various fuchsia tools which use the flutter_tools library.
This is required to provide a workaround for the fuchsia build system.
When this directory is not present the various tools specified in the
`dart_tool`
directives in the flutter_tools/BUILD.gn file will end up
having the same package root entry written in the .packages file. This
causes the build to fail because the dart compiler has a requirement that
libraries must have a unique package uri. By specifying a package root which
is a subdirectory of this directory for these tools we avoid having the build
system create duplicate package roots for the generated libraries for these
tools.
Note that we cannot move the location of the main files for these tools because
the paths are hard coded in the fuchsia tree.
Tracking Bugs:
-
fxbug.dev/51373 (move flutter_tools/BUILD.gn to fuchsia repo)
-
fxbug.dev/51375 (do not refence fuchsia_tester.dart directly)
-
fxbug.dev/51375 (remove the fuchsia_entrypoint_shim directory)
packages/flutter_tools/fuchsia_entrypoint_shim/fuchsia_asset_builder/pubspec.yaml
0 → 100644
View file @
e963bfe1
name
:
flutter_asset_builder
description
:
Tools for building Flutter applications
homepage
:
https://flutter.dev
author
:
Flutter Authors <flutter-dev@googlegroups.com>
environment
:
# The pub client defaults to an <2.0.0 sdk constraint which we need to explicitly overwrite.
sdk
:
"
>=2.7.0
<3.0.0"
dartdoc
:
# Exclude this package from the hosted API docs.
nodoc
:
true
# PUBSPEC CHECKSUM: 0000
packages/flutter_tools/fuchsia_entrypoint_shim/fuchsia_attach/pubspec.yaml
0 → 100644
View file @
e963bfe1
name
:
flutter_attach
description
:
Tools for building Flutter applications
homepage
:
https://flutter.dev
author
:
Flutter Authors <flutter-dev@googlegroups.com>
environment
:
# The pub client defaults to an <2.0.0 sdk constraint which we need to explicitly overwrite.
sdk
:
"
>=2.7.0
<3.0.0"
dartdoc
:
# Exclude this package from the hosted API docs.
nodoc
:
true
# PUBSPEC CHECKSUM: 0000
packages/flutter_tools/fuchsia_entrypoint_shim/fuchsia_builder/pubspec.yaml
0 → 100644
View file @
e963bfe1
name
:
flutter_builder
description
:
Tools for building Flutter applications
homepage
:
https://flutter.dev
author
:
Flutter Authors <flutter-dev@googlegroups.com>
environment
:
# The pub client defaults to an <2.0.0 sdk constraint which we need to explicitly overwrite.
sdk
:
"
>=2.7.0
<3.0.0"
dartdoc
:
# Exclude this package from the hosted API docs.
nodoc
:
true
# PUBSPEC CHECKSUM: 0000
packages/flutter_tools/fuchsia_entrypoint_shim/fuchsia_tester/pubspec.yaml
0 → 100644
View file @
e963bfe1
name
:
flutter_tester
description
:
Tools for building Flutter applications
homepage
:
https://flutter.dev
author
:
Flutter Authors <flutter-dev@googlegroups.com>
environment
:
# The pub client defaults to an <2.0.0 sdk constraint which we need to explicitly overwrite.
sdk
:
"
>=2.7.0
<3.0.0"
dartdoc
:
# Exclude this package from the hosted API docs.
nodoc
:
true
# PUBSPEC CHECKSUM: 0000
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment