Unverified Commit e8c3ce6b authored by Anna Gringauze's avatar Anna Gringauze Committed by GitHub

Try fixing web tool tests on windows (#78386)

parent d7777580
......@@ -754,7 +754,8 @@
"name": "Windows web_tool_tests",
"repo": "flutter",
"task_name": "win_web_tool_tests",
"enabled": false
"enabled": true,
"run_if": ["dev/**", "packages/flutter_tools/**", "bin/**"]
}
]
}
......@@ -452,7 +452,8 @@ class WebAssetServer implements AssetReader {
}
/// Tear down the http server running.
Future<void> dispose() {
Future<void> dispose() async {
await dwds?.stop();
return _httpServer.close();
}
......
......@@ -173,7 +173,8 @@ class ChromiumLauncher {
final String chromeExecutable = _browserFinder(_platform, _fileSystem);
if (_logger.isVerbose) {
if (_logger.isVerbose && !_platform.isWindows) {
// Note: --version is not supported on windows.
final ProcessResult versionResult = await _processManager.run(<String>[chromeExecutable, '--version']);
_logger.printTrace('Using ${versionResult.stdout}');
}
......
......@@ -4,6 +4,7 @@
// @dart = 2.8
@Timeout(Duration(minutes: 3))
import 'package:file/file.dart';
import '../integration.shard/test_data/stepping_project.dart';
......@@ -48,7 +49,7 @@ void main() {
reason: 'After $i steps, debugger should stop at $expectedLine but stopped at $actualLine'
);
}
}, skip: platform.isWindows); // https://github.com/flutter/flutter/issues/70486
});
tearDown(() async {
await flutter.stop();
......
......@@ -4,6 +4,7 @@
// @dart = 2.8
@Timeout(Duration(minutes: 3))
import 'package:file/file.dart';
import 'package:matcher/matcher.dart';
import 'package:vm_service/vm_service.dart';
......@@ -168,7 +169,7 @@ void batch2() {
await breakInMethod(_flutter);
await evaluateComplexExpressions(_flutter);
await cleanProject();
}, skip: 'https://github.com/dart-lang/sdk/issues/41480');
});
}
Future<void> failToEvaluateExpression(FlutterTestDriver flutter) async {
......
......@@ -4,6 +4,7 @@
// @dart = 2.8
@Timeout(Duration(minutes: 3))
import 'dart:async';
import 'package:file/file.dart';
......
......@@ -4,6 +4,7 @@
// @dart = 2.8
@Timeout(Duration(minutes: 3))
import 'package:file/file.dart';
import 'package:flutter_tools/src/base/file_system.dart';
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment