Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
e8c3ce6b
Unverified
Commit
e8c3ce6b
authored
Mar 18, 2021
by
Anna Gringauze
Committed by
GitHub
Mar 18, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Try fixing web tool tests on windows (#78386)
parent
d7777580
Changes
7
Hide whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
12 additions
and
5 deletions
+12
-5
try_builders.json
dev/try_builders.json
+2
-1
devfs_web.dart
packages/flutter_tools/lib/src/isolated/devfs_web.dart
+2
-1
chrome.dart
packages/flutter_tools/lib/src/web/chrome.dart
+2
-1
debugger_stepping_web_test.dart
...tter_tools/test/web.shard/debugger_stepping_web_test.dart
+2
-1
expression_evaluation_web_test.dart
..._tools/test/web.shard/expression_evaluation_web_test.dart
+2
-1
hot_reload_web_test.dart
...ges/flutter_tools/test/web.shard/hot_reload_web_test.dart
+1
-0
web_run_test.dart
packages/flutter_tools/test/web.shard/web_run_test.dart
+1
-0
No files found.
dev/try_builders.json
View file @
e8c3ce6b
...
...
@@ -754,7 +754,8 @@
"name"
:
"Windows web_tool_tests"
,
"repo"
:
"flutter"
,
"task_name"
:
"win_web_tool_tests"
,
"enabled"
:
false
"enabled"
:
true
,
"run_if"
:
[
"dev/**"
,
"packages/flutter_tools/**"
,
"bin/**"
]
}
]
}
packages/flutter_tools/lib/src/isolated/devfs_web.dart
View file @
e8c3ce6b
...
...
@@ -452,7 +452,8 @@ class WebAssetServer implements AssetReader {
}
/// Tear down the http server running.
Future
<
void
>
dispose
()
{
Future
<
void
>
dispose
()
async
{
await
dwds
?.
stop
();
return
_httpServer
.
close
();
}
...
...
packages/flutter_tools/lib/src/web/chrome.dart
View file @
e8c3ce6b
...
...
@@ -173,7 +173,8 @@ class ChromiumLauncher {
final
String
chromeExecutable
=
_browserFinder
(
_platform
,
_fileSystem
);
if
(
_logger
.
isVerbose
)
{
if
(
_logger
.
isVerbose
&&
!
_platform
.
isWindows
)
{
// Note: --version is not supported on windows.
final
ProcessResult
versionResult
=
await
_processManager
.
run
(<
String
>[
chromeExecutable
,
'--version'
]);
_logger
.
printTrace
(
'Using
${versionResult.stdout}
'
);
}
...
...
packages/flutter_tools/test/web.shard/debugger_stepping_web_test.dart
View file @
e8c3ce6b
...
...
@@ -4,6 +4,7 @@
// @dart = 2.8
@Timeout
(
Duration
(
minutes:
3
))
import
'package:file/file.dart'
;
import
'../integration.shard/test_data/stepping_project.dart'
;
...
...
@@ -48,7 +49,7 @@ void main() {
reason:
'After
$i
steps, debugger should stop at
$expectedLine
but stopped at
$actualLine
'
);
}
}
,
skip:
platform
.
isWindows
);
// https://github.com/flutter/flutter/issues/70486
}
);
tearDown
(()
async
{
await
flutter
.
stop
();
...
...
packages/flutter_tools/test/web.shard/expression_evaluation_web_test.dart
View file @
e8c3ce6b
...
...
@@ -4,6 +4,7 @@
// @dart = 2.8
@Timeout
(
Duration
(
minutes:
3
))
import
'package:file/file.dart'
;
import
'package:matcher/matcher.dart'
;
import
'package:vm_service/vm_service.dart'
;
...
...
@@ -168,7 +169,7 @@ void batch2() {
await
breakInMethod
(
_flutter
);
await
evaluateComplexExpressions
(
_flutter
);
await
cleanProject
();
}
,
skip:
'https://github.com/dart-lang/sdk/issues/41480'
);
});
}
Future
<
void
>
failToEvaluateExpression
(
FlutterTestDriver
flutter
)
async
{
...
...
packages/flutter_tools/test/web.shard/hot_reload_web_test.dart
View file @
e8c3ce6b
...
...
@@ -4,6 +4,7 @@
// @dart = 2.8
@Timeout
(
Duration
(
minutes:
3
))
import
'dart:async'
;
import
'package:file/file.dart'
;
...
...
packages/flutter_tools/test/web.shard/web_run_test.dart
View file @
e8c3ce6b
...
...
@@ -4,6 +4,7 @@
// @dart = 2.8
@Timeout
(
Duration
(
minutes:
3
))
import
'package:file/file.dart'
;
import
'package:flutter_tools/src/base/file_system.dart'
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment