Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
e72e7f9f
Unverified
Commit
e72e7f9f
authored
Jun 03, 2020
by
Jenn Magder
Committed by
GitHub
Jun 03, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Don't elapse real time during IOSDevice.startApp tests (#58538) (#58622)
parent
98a77e2a
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
9 additions
and
2 deletions
+9
-2
devices.dart
packages/flutter_tools/lib/src/ios/devices.dart
+2
-0
fallback_discovery.dart
packages/flutter_tools/lib/src/ios/fallback_discovery.dart
+2
-2
ios_device_start_prebuilt_test.dart
...est/general.shard/ios/ios_device_start_prebuilt_test.dart
+5
-0
No files found.
packages/flutter_tools/lib/src/ios/devices.dart
View file @
e72e7f9f
...
...
@@ -300,6 +300,7 @@ class IOSDevice extends Device {
Map
<
String
,
dynamic
>
platformArgs
,
bool
prebuiltApplication
=
false
,
bool
ipv6
=
false
,
@visibleForTesting
Duration
fallbackPollingDelay
,
})
async
{
String
packageId
;
...
...
@@ -416,6 +417,7 @@ class IOSDevice extends Device {
portForwarder:
portForwarder
,
protocolDiscovery:
observatoryDiscovery
,
flutterUsage:
globals
.
flutterUsage
,
pollingDelay:
fallbackPollingDelay
,
);
final
Uri
localUri
=
await
fallbackDiscovery
.
discover
(
assumedDevicePort:
assumedObservatoryPort
,
...
...
packages/flutter_tools/lib/src/ios/fallback_discovery.dart
View file @
e72e7f9f
...
...
@@ -46,14 +46,14 @@ class FallbackDiscovery {
@required
Usage
flutterUsage
,
VmServiceConnector
vmServiceConnectUri
=
vm_service_io
.
vmServiceConnectUri
,
Duration
pollingDelay
=
const
Duration
(
seconds:
2
)
,
Duration
pollingDelay
,
})
:
_logger
=
logger
,
_mDnsObservatoryDiscovery
=
mDnsObservatoryDiscovery
,
_portForwarder
=
portForwarder
,
_protocolDiscovery
=
protocolDiscovery
,
_flutterUsage
=
flutterUsage
,
_vmServiceConnectUri
=
vmServiceConnectUri
,
_pollingDelay
=
pollingDelay
;
_pollingDelay
=
pollingDelay
??
const
Duration
(
seconds:
2
)
;
static
const
String
_kEventName
=
'ios-handshake'
;
...
...
packages/flutter_tools/test/general.shard/ios/ios_device_start_prebuilt_test.dart
View file @
e72e7f9f
...
...
@@ -129,6 +129,7 @@ void main() {
prebuiltApplication:
true
,
debuggingOptions:
DebuggingOptions
.
enabled
(
BuildInfo
.
debug
),
platformArgs:
<
String
,
dynamic
>{},
fallbackPollingDelay:
Duration
.
zero
,
);
verify
(
globals
.
flutterUsage
.
sendEvent
(
'ios-handshake'
,
'mdns-success'
)).
called
(
1
);
...
...
@@ -173,6 +174,7 @@ void main() {
prebuiltApplication:
true
,
debuggingOptions:
DebuggingOptions
.
enabled
(
BuildInfo
.
debug
),
platformArgs:
<
String
,
dynamic
>{},
fallbackPollingDelay:
Duration
.
zero
,
);
expect
(
launchResult
.
started
,
true
);
...
...
@@ -219,6 +221,7 @@ void main() {
prebuiltApplication:
true
,
debuggingOptions:
DebuggingOptions
.
enabled
(
BuildInfo
.
debug
),
platformArgs:
<
String
,
dynamic
>{},
fallbackPollingDelay:
Duration
.
zero
,
);
expect
(
launchResult
.
started
,
false
);
...
...
@@ -257,6 +260,7 @@ void main() {
prebuiltApplication:
true
,
debuggingOptions:
DebuggingOptions
.
disabled
(
BuildInfo
.
release
),
platformArgs:
<
String
,
dynamic
>{},
fallbackPollingDelay:
Duration
.
zero
,
);
expect
(
launchResult
.
started
,
true
);
...
...
@@ -347,6 +351,7 @@ void main() {
verboseSystemLogs:
true
,
),
platformArgs:
<
String
,
dynamic
>{},
fallbackPollingDelay:
Duration
.
zero
,
);
expect
(
launchResult
.
started
,
true
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment