Commit e6981244 authored by Ian Hickson's avatar Ian Hickson

Rename RowInkWell to TableRowInkWell

...so that people don't think it's for Row.
parent 80fabfd3
...@@ -337,7 +337,7 @@ class DataTable extends StatelessWidget { ...@@ -337,7 +337,7 @@ class DataTable extends StatelessWidget {
) )
); );
if (onRowTap != null) { if (onRowTap != null) {
contents = new RowInkWell( contents = new TableRowInkWell(
onTap: onRowTap, onTap: onRowTap,
child: contents child: contents
); );
...@@ -443,7 +443,7 @@ class DataTable extends StatelessWidget { ...@@ -443,7 +443,7 @@ class DataTable extends StatelessWidget {
child: label child: label
); );
} else if (onSelectChanged != null) { } else if (onSelectChanged != null) {
label = new RowInkWell( label = new TableRowInkWell(
onTap: onSelectChanged, onTap: onSelectChanged,
child: label child: label
); );
...@@ -555,15 +555,15 @@ class DataTable extends StatelessWidget { ...@@ -555,15 +555,15 @@ class DataTable extends StatelessWidget {
/// Must have an ancestor [Material] widget in which to cause ink /// Must have an ancestor [Material] widget in which to cause ink
/// reactions and an ancestor [Table] widget to establish a row. /// reactions and an ancestor [Table] widget to establish a row.
/// ///
/// The RowInkWell must be in the same coordinate space (modulo /// The TableRowInkWell must be in the same coordinate space (modulo
/// translations) as the [Table]. If it's rotated or scaled or /// translations) as the [Table]. If it's rotated or scaled or
/// otherwise transformed, it will not be able to describe the /// otherwise transformed, it will not be able to describe the
/// rectangle of the row in its own coordinate system as a [Rect], and /// rectangle of the row in its own coordinate system as a [Rect], and
/// thus the splash will not occur. (In general, this is easy to /// thus the splash will not occur. (In general, this is easy to
/// achieve: just put the RowInkWell as the direct child of the /// achieve: just put the TableRowInkWell as the direct child of the
/// [Table], and put the other contents of the cell inside it.) /// [Table], and put the other contents of the cell inside it.)
class RowInkWell extends InkResponse { class TableRowInkWell extends InkResponse {
RowInkWell({ TableRowInkWell({
Key key, Key key,
Widget child, Widget child,
GestureTapCallback onTap, GestureTapCallback onTap,
...@@ -599,7 +599,7 @@ class RowInkWell extends InkResponse { ...@@ -599,7 +599,7 @@ class RowInkWell extends InkResponse {
assert(cellParentData.y != null); assert(cellParentData.y != null);
Rect rect = table.getRowBox(cellParentData.y); Rect rect = table.getRowBox(cellParentData.y);
// The rect is in the table's coordinate space. We need to change it to the // The rect is in the table's coordinate space. We need to change it to the
// RowInkWell's coordinate space. // TableRowInkWell's coordinate space.
table.applyPaintTransform(cell, transform); table.applyPaintTransform(cell, transform);
Offset offset = MatrixUtils.getAsTranslation(transform); Offset offset = MatrixUtils.getAsTranslation(transform);
if (offset != null) if (offset != null)
......
...@@ -69,7 +69,7 @@ class InkResponse extends StatefulWidget { ...@@ -69,7 +69,7 @@ class InkResponse extends StatefulWidget {
/// ///
/// This method is intended to be overridden by descendants that /// This method is intended to be overridden by descendants that
/// specialize [InkResponse] for unusual cases. For example, /// specialize [InkResponse] for unusual cases. For example,
/// [RowInkWell] implements this method to return the rectangle /// [TableRowInkWell] implements this method to return the rectangle
/// corresponding to the row that the widget is in. /// corresponding to the row that the widget is in.
/// ///
/// The default behavior returns null, which is equivalent to /// The default behavior returns null, which is equivalent to
...@@ -82,7 +82,7 @@ class InkResponse extends StatefulWidget { ...@@ -82,7 +82,7 @@ class InkResponse extends StatefulWidget {
/// ///
/// This method is intended to be overridden by descendants that /// This method is intended to be overridden by descendants that
/// specialize [InkResponse] for unusual cases. For example, /// specialize [InkResponse] for unusual cases. For example,
/// [RowInkWell] implements this method to verify that the widget is /// [TableRowInkWell] implements this method to verify that the widget is
/// in a table. /// in a table.
bool debugCheckContext(BuildContext context) { bool debugCheckContext(BuildContext context) {
assert(debugCheckHasMaterial(context)); assert(debugCheckHasMaterial(context));
......
...@@ -72,7 +72,7 @@ bool debugItemsHaveDuplicateKeys(Iterable<Widget> items) { ...@@ -72,7 +72,7 @@ bool debugItemsHaveDuplicateKeys(Iterable<Widget> items) {
/// Asserts that the given context has a [Table] ancestor. /// Asserts that the given context has a [Table] ancestor.
/// ///
/// Used by [RowInkWell] to make sure that it is only used in an appropriate context. /// Used by [TableRowInkWell] to make sure that it is only used in an appropriate context.
/// ///
/// To invoke this function, use the following pattern, typically in the /// To invoke this function, use the following pattern, typically in the
/// relevant Widget's [build] method: /// relevant Widget's [build] method:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment