Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
e62a6451
Unverified
Commit
e62a6451
authored
Apr 26, 2018
by
Hans Muller
Committed by
GitHub
Apr 26, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed (#17010)
parent
d8f2f369
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
23 additions
and
1 deletion
+23
-1
text_field.dart
packages/flutter/lib/src/material/text_field.dart
+2
-1
text_field_focus_test.dart
packages/flutter/test/material/text_field_focus_test.dart
+21
-0
No files found.
packages/flutter/lib/src/material/text_field.dart
View file @
e62a6451
...
...
@@ -364,7 +364,8 @@ class _TextFieldState extends State<TextField> with AutomaticKeepAliveClientMixi
InteractiveInkFeature
_createInkFeature
(
TapDownDetails
details
)
{
final
MaterialInkController
inkController
=
Material
.
of
(
context
);
final
RenderBox
referenceBox
=
InputDecorator
.
containerOf
(
_editableTextKey
.
currentContext
);
final
BuildContext
editableContext
=
_editableTextKey
.
currentContext
;
final
RenderBox
referenceBox
=
InputDecorator
.
containerOf
(
editableContext
)
??
editableContext
.
findRenderObject
();
final
Offset
position
=
referenceBox
.
globalToLocal
(
details
.
globalPosition
);
final
Color
color
=
Theme
.
of
(
context
).
splashColor
;
...
...
packages/flutter/test/material/text_field_focus_test.dart
View file @
e62a6451
...
...
@@ -206,4 +206,25 @@ void main() {
await
tester
.
pump
();
// in case the AutomaticKeepAlive widget thinks it needs a cleanup frame
expect
(
find
.
byType
(
TextField
),
findsOneWidget
);
});
testWidgets
(
'TextField with decoration:null'
,
(
WidgetTester
tester
)
async
{
// Regression test for https://github.com/flutter/flutter/issues/16880
await
tester
.
pumpWidget
(
new
MaterialApp
(
home:
const
Material
(
child:
const
Center
(
child:
const
TextField
(
decoration:
null
),
),
),
),
);
expect
(
tester
.
testTextInput
.
isVisible
,
isFalse
);
await
tester
.
tap
(
find
.
byType
(
TextField
));
await
tester
.
idle
();
expect
(
tester
.
testTextInput
.
isVisible
,
isTrue
);
});
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment