Unverified Commit e599cdd4 authored by Jonah Williams's avatar Jonah Williams Committed by GitHub

[flutter_tools] fix web messaging (#74513)

parent 1d3f6971
...@@ -184,14 +184,7 @@ abstract class ResidentWebRunner extends ResidentRunner { ...@@ -184,14 +184,7 @@ abstract class ResidentWebRunner extends ResidentRunner {
fire + globals.terminal.bolden(rawMessage), fire + globals.terminal.bolden(rawMessage),
TerminalColor.red, TerminalColor.red,
); );
if (!flutterNext) { globals.printStatus(message);
globals.printStatus(
"Warning: Flutter's support for web development is not stable yet and hasn't");
globals.printStatus('been thoroughly tested in production environments.');
globals.printStatus('For more information see https://flutter.dev/web');
globals.printStatus('');
globals.printStatus(message);
}
const String quitMessage = 'To quit, press "q".'; const String quitMessage = 'To quit, press "q".';
if (device.device is! WebServerDevice) { if (device.device is! WebServerDevice) {
globals.printStatus('For a more detailed help message, press "h". $quitMessage'); globals.printStatus('For a more detailed help message, press "h". $quitMessage');
......
...@@ -891,6 +891,19 @@ void main() { ...@@ -891,6 +891,19 @@ void main() {
Platform: () => FakePlatform(operatingSystem: 'linux', environment: <String, String>{}), Platform: () => FakePlatform(operatingSystem: 'linux', environment: <String, String>{}),
}); });
testUsingContext('printHelp without details shows hot restart help message', () async {
final ResidentRunner residentWebRunner = setUpResidentRunner(mockFlutterDevice);
fakeVmServiceHost = FakeVmServiceHost(requests: <VmServiceExpectation>[]);
residentWebRunner.printHelp(details: false);
expect(testLogger.statusText, contains('To hot restart changes'));
}, overrides: <Type, Generator>{
FileSystem: () => fileSystem,
ProcessManager: () => processManager,
Pub: () => MockPub(),
Platform: () => FakePlatform(operatingSystem: 'linux', environment: <String, String>{}),
});
testUsingContext('debugDumpApp', () async { testUsingContext('debugDumpApp', () async {
final ResidentRunner residentWebRunner = setUpResidentRunner(mockFlutterDevice); final ResidentRunner residentWebRunner = setUpResidentRunner(mockFlutterDevice);
fakeVmServiceHost = FakeVmServiceHost(requests: <VmServiceExpectation>[ fakeVmServiceHost = FakeVmServiceHost(requests: <VmServiceExpectation>[
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment