Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
e2b8c86b
Commit
e2b8c86b
authored
Apr 19, 2018
by
Danny Tuppeny
Committed by
Danny Tuppeny
May 09, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add dantup to TODO comments
parent
259dd571
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
3 deletions
+3
-3
emulators.dart
packages/flutter_tools/lib/src/commands/emulators.dart
+1
-1
ios_emulators.dart
packages/flutter_tools/lib/src/ios/ios_emulators.dart
+2
-2
No files found.
packages/flutter_tools/lib/src/commands/emulators.dart
View file @
e2b8c86b
...
...
@@ -61,7 +61,7 @@ class EmulatorsCommand extends FlutterCommand {
if
(
emulators
.
isEmpty
)
{
printStatus
(
'No emulators available.
\n\n
'
// TODO: Change these when we support creation
// TODO
(dantup)
: Change these when we support creation
// 'You may need to create images using "flutter emulators --create"\n'
'You may need to create one using Android Studio '
'or visit https://flutter.io/setup/ for troubleshooting tips.'
);
...
...
packages/flutter_tools/lib/src/ios/ios_emulators.dart
View file @
e2b8c86b
...
...
@@ -11,7 +11,7 @@ import '../emulator.dart';
import
'../globals.dart'
;
import
'ios_workflow.dart'
;
// TODO: Is there a better name for this? We already have IOSSimulator classes
// TODO
(dantup)
: Is there a better name for this? We already have IOSSimulator classes
// that represent *running* simulators, but this is about "unlaunched images"...
class
IOSEmulators
extends
EmulatorDiscovery
{
@override
...
...
@@ -61,7 +61,7 @@ List<IOSEmulator> getEmulators() {
String
getSimulatorPath
(
)
{
final
List
<
String
>
searchPaths
=
<
String
>[
// TODO: Could this be anywhere else?
// TODO
(dantup)
: Could this be anywhere else?
'/Applications/Xcode.app/Contents/Developer/Applications/Simulator.app'
,
];
return
searchPaths
.
where
((
String
p
)
=>
p
!=
null
).
firstWhere
(
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment