Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
e1fd2ace
Unverified
Commit
e1fd2ace
authored
Aug 10, 2023
by
LongCatIsLooong
Committed by
GitHub
Aug 10, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
TextPainter migration cleanup (#132317)
Undo temporary changes made in #132094
parent
f9a578dd
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
11 deletions
+5
-11
test.dart
dev/bots/test.dart
+4
-4
text_painter.dart
packages/flutter/lib/src/painting/text_painter.dart
+1
-7
No files found.
dev/bots/test.dart
View file @
e1fd2ace
...
...
@@ -102,7 +102,7 @@ final String flutterTester = path.join(flutterRoot, 'bin', 'cache', 'artifacts',
/// The arguments to pass to `flutter test` (typically the local engine
/// configuration) -- prefilled with the arguments passed to test.dart.
final
List
<
String
>
flutterTestArgs
=
<
String
>[
'--dart-define=SKPARAGRAPH_REMOVE_ROUNDING_HACK=true'
];
final
List
<
String
>
flutterTestArgs
=
<
String
>[];
/// Environment variables to override the local engine when running `pub test`,
/// if such flags are provided to `test.dart`.
...
...
@@ -1309,8 +1309,8 @@ Future<void> _runFlutterDriverWebTest({
await
runCommand
(
flutter
,
<
String
>[
'drive'
,
...
flutterTestArgs
,
'drive'
,
if
(
driver
!=
null
)
'--driver=
$driver
'
,
'--target=
$target
'
,
'--browser-name=chrome'
,
...
...
@@ -1584,8 +1584,8 @@ Future<void> _runGalleryE2eWebTest(String buildMode, { bool canvasKit = false })
await
runCommand
(
flutter
,
<
String
>[
'drive'
,
...
flutterTestArgs
,
'drive'
,
if
(
canvasKit
)
'--dart-define=FLUTTER_WEB_USE_SKIA=true'
,
if
(!
canvasKit
)
...
...
@@ -1665,10 +1665,10 @@ Future<void> _runWebReleaseTest(String target, {
await
runCommand
(
flutter
,
<
String
>[
...
flutterTestArgs
,
'build'
,
'web'
,
'--release'
,
...
flutterTestArgs
,
...
additionalArguments
,
'-t'
,
target
,
...
...
packages/flutter/lib/src/painting/text_painter.dart
View file @
e1fd2ace
...
...
@@ -515,13 +515,7 @@ class TextPainter {
_locale
=
locale
,
_strutStyle
=
strutStyle
,
_textWidthBasis
=
textWidthBasis
,
_textHeightBehavior
=
textHeightBehavior
,
assert
(()
{
if
(
const
bool
.
fromEnvironment
(
'SKPARAGRAPH_REMOVE_ROUNDING_HACK'
))
{
ui
.
ParagraphBuilder
.
setDisableRoundingHack
(
true
);
}
return
true
;
}());
_textHeightBehavior
=
textHeightBehavior
;
/// Computes the width of a configured [TextPainter].
///
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment