Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
e0670412
Commit
e0670412
authored
Mar 29, 2017
by
Yegor
Committed by
GitHub
Mar 29, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
increase vmservice timeout; log stderr in microbenchmarks (#9088)
parent
72effdd2
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
14 additions
and
7 deletions
+14
-7
microbenchmarks.dart
dev/devicelab/lib/tasks/microbenchmarks.dart
+13
-6
vmservice.dart
packages/flutter_tools/lib/src/vmservice.dart
+1
-1
No files found.
dev/devicelab/lib/tasks/microbenchmarks.dart
View file @
e0670412
...
...
@@ -76,11 +76,17 @@ Future<Map<String, double>> _readJsonResults(Process process) {
bool
jsonStarted
=
false
;
final
StringBuffer
jsonBuf
=
new
StringBuffer
();
final
Completer
<
Map
<
String
,
double
>>
completer
=
new
Completer
<
Map
<
String
,
double
>>();
StreamSubscription
<
String
>
stdoutSub
;
final
StreamSubscription
<
String
>
stderrSub
=
process
.
stderr
.
transform
(
const
Utf8Decoder
())
.
transform
(
const
LineSplitter
())
.
listen
((
String
line
)
{
stderr
.
writeln
(
'[STDERR]
$line
'
);
});
int
prefixLength
=
0
;
bool
process
Killed
=
false
;
stdoutSub
=
process
.
stdout
bool
process
WasKilledIntentionally
=
false
;
final
StreamSubscription
<
String
>
stdoutSub
=
process
.
stdout
.
transform
(
const
Utf8Decoder
())
.
transform
(
const
LineSplitter
())
.
listen
((
String
line
)
{
...
...
@@ -94,8 +100,7 @@ Future<Map<String, double>> _readJsonResults(Process process) {
if
(
line
.
contains
(
jsonEnd
))
{
jsonStarted
=
false
;
stdoutSub
.
cancel
();
processKilled
=
true
;
processWasKilledIntentionally
=
true
;
process
.
kill
(
ProcessSignal
.
SIGINT
);
// flutter run doesn't quit automatically
completer
.
complete
(
JSON
.
decode
(
jsonBuf
.
toString
()));
return
;
...
...
@@ -106,7 +111,9 @@ Future<Map<String, double>> _readJsonResults(Process process) {
});
process
.
exitCode
.
then
<
int
>((
int
code
)
{
if
(!
processKilled
&&
code
!=
0
)
{
stdoutSub
.
cancel
();
stderrSub
.
cancel
();
if
(!
processWasKilledIntentionally
&&
code
!=
0
)
{
completer
.
completeError
(
'flutter run failed: exit code=
$code
'
);
}
});
...
...
packages/flutter_tools/lib/src/vmservice.dart
View file @
e0670412
...
...
@@ -28,7 +28,7 @@ StreamChannel<String> _defaultOpenChannel(Uri uri) =>
new
IOWebSocketChannel
.
connect
(
uri
.
toString
()).
cast
();
/// The default VM service request timeout.
const
Duration
kDefaultRequestTimeout
=
const
Duration
(
seconds:
1
0
);
const
Duration
kDefaultRequestTimeout
=
const
Duration
(
seconds:
3
0
);
/// Used for RPC requests that may take a long time.
const
Duration
kLongRequestTimeout
=
const
Duration
(
minutes:
1
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment