Commit e04de975 authored by Eric Seidel's avatar Eric Seidel

Merge pull request #922 from eseidelGoogle/pub_is_slow

Add nicer logging/reporting to dev/update_packages.dart
parents e1fefc06 d8e4fee9
......@@ -13,3 +13,6 @@ before_script:
- ./travis/setup.sh
script:
- ./travis/test.sh
cache:
directories:
- $HOME/.pub-cache
......@@ -6,27 +6,40 @@
import 'dart:io';
final String binaryName = Platform.isWindows ? 'pub.bat' : 'pub';
void update(Directory directory, bool upgrade) {
int runPub(Directory directory, List<String> pubArgs) {
int updateCount = 0;
for (FileSystemEntity dir in directory.listSync()) {
if (dir is Directory) {
print("Updating ${dir.path}...");
updateCount++;
Stopwatch timer = new Stopwatch()..start();
stdout.write("Updating ${dir.path}...");
ProcessResult result = Process.runSync(
binaryName,
[ upgrade ? 'upgrade' : 'get' ],
pubArgs,
workingDirectory: dir.path
);
timer.stop();
stdout.write(" (${timer.elapsedMilliseconds} ms)");
if (result.exitCode != 0) {
print("... failed with exit code ${result.exitCode}.");
print(result.stdout);
print(result.stderr);
} else {
stdout.write("\n");
}
}
}
return updateCount;
}
void main(List<String> arguments) {
Stopwatch timer = new Stopwatch()..start();
bool upgrade = arguments.length > 0 && arguments[0] == '--upgrade';
String FLUTTER_ROOT = new File(Platform.script.toFilePath()).parent.parent.path;
update(new Directory("$FLUTTER_ROOT/packages"), upgrade);
update(new Directory("$FLUTTER_ROOT/examples"), upgrade);
List<String> pubArgs = [ upgrade ? 'upgrade' : 'get' ];
int count = 0;
count += runPub(new Directory("$FLUTTER_ROOT/packages"), pubArgs);
count += runPub(new Directory("$FLUTTER_ROOT/examples"), pubArgs);
String command = "$binaryName ${pubArgs.join(' ')}";
print("Ran \"$command\" $count times in ${timer.elapsedMilliseconds} ms");
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment