Refactor BuildIOSFrameworkCommand with common darwin baseclass (#105194)

packages/flutter_tools/bin/podhelper.rb

@@ -177,9 +177,9 @@ def flutter_install_ios_engine_pod(ios_application_path = nil)
       Pod::Spec.new do |s|
         s.name             = 'Flutter'
         s.version          = '1.0.0'
-        s.summary          = 'High-performance, high-fidelity mobile apps.'
-        s.homepage         = 'https://flutter.io'
-        s.license          = { :type => 'MIT' }
+        s.summary          = 'A UI toolkit for beautiful and fast apps.'
+        s.homepage         = 'https://flutter.dev'
+        s.license          = { :type => 'BSD' }
         s.author           = { 'Flutter Dev Team' => 'flutter-dev@googlegroups.com' }
         s.source           = { :git => 'https://github.com/flutter/engine', :tag => s.version.to_s }
         s.ios.deployment_target = '11.0'
@@ -215,9 +215,9 @@ def flutter_install_macos_engine_pod(mac_application_path = nil)
       Pod::Spec.new do |s|
         s.name             = 'FlutterMacOS'
         s.version          = '1.0.0'
-        s.summary          = 'High-performance, high-fidelity mobile apps.'
-        s.homepage         = 'https://flutter.io'
-        s.license          = { :type => 'MIT' }
+        s.summary          = 'A UI toolkit for beautiful and fast apps.'
+        s.homepage         = 'https://flutter.dev'
+        s.license          = { :type => 'BSD' }
         s.author           = { 'Flutter Dev Team' => 'flutter-dev@googlegroups.com' }
         s.source           = { :git => 'https://github.com/flutter/engine', :tag => s.version.to_s }
         s.osx.deployment_target = '10.11'

packages/flutter_tools/test/commands.shard/hermetic/build_ios_framework_test.dart → packages/flutter_tools/test/commands.shard/hermetic/build_darwin_framework_test.dart

@@ -271,4 +271,83 @@ void main() {
       });
     });
   });
+
+  group('XCFrameworks', () {
+    MemoryFileSystem fileSystem;
+    FakeProcessManager fakeProcessManager;
+
+    setUp(() {
+      fileSystem = MemoryFileSystem.test();
+      fakeProcessManager = FakeProcessManager.empty();
+    });
+
+    testWithoutContext('created', () async {
+      final Directory frameworkA = fileSystem.directory('FrameworkA.framework')..createSync();
+      final Directory frameworkB = fileSystem.directory('FrameworkB.framework')..createSync();
+      final Directory output = fileSystem.directory('output');
+
+      fakeProcessManager.addCommand(FakeCommand(
+        command: <String>[
+          'xcrun',
+          'xcodebuild',
+          '-create-xcframework',
+          '-framework',
+          frameworkA.path,
+          '-framework',
+          frameworkB.path,
+          '-output',
+          output.childDirectory('Combine.xcframework').path,
+        ],
+      ));
+      await BuildFrameworkCommand.produceXCFramework(
+        <Directory>[frameworkA, frameworkB],
+        'Combine',
+        output,
+        fakeProcessManager,
+      );
+      expect(fakeProcessManager.hasRemainingExpectations, isFalse);
+    });
+
+    testWithoutContext('created with symbols', () async {
+      final Directory parentA = fileSystem.directory('FrameworkA')..createSync();
+      final File bcsymbolmapA = parentA.childFile('ABC123.bcsymbolmap')..createSync();
+      final File dSYMA = parentA.childFile('FrameworkA.framework.dSYM')..createSync();
+      final Directory frameworkA = parentA.childDirectory('FrameworkA.framework')..createSync();
+
+      final Directory parentB = fileSystem.directory('FrameworkB')..createSync();
+      final File bcsymbolmapB = parentB.childFile('ZYX987.bcsymbolmap')..createSync();
+      final File dSYMB = parentB.childFile('FrameworkB.framework.dSYM')..createSync();
+      final Directory frameworkB = parentB.childDirectory('FrameworkB.framework')..createSync();
+      final Directory output = fileSystem.directory('output');
+
+      fakeProcessManager.addCommand(FakeCommand(
+        command: <String>[
+          'xcrun',
+          'xcodebuild',
+          '-create-xcframework',
+          '-framework',
+          frameworkA.path,
+          '-debug-symbols',
+          bcsymbolmapA.path,
+          '-debug-symbols',
+          dSYMA.path,
+          '-framework',
+          frameworkB.path,
+          '-debug-symbols',
+          bcsymbolmapB.path,
+          '-debug-symbols',
+          dSYMB.path,
+          '-output',
+          output.childDirectory('Combine.xcframework').path,
+        ],
+      ));
+      await BuildFrameworkCommand.produceXCFramework(
+        <Directory>[frameworkA, frameworkB],
+        'Combine',
+        output,
+        fakeProcessManager,
+      );
+      expect(fakeProcessManager.hasRemainingExpectations, isFalse);
+    });
+  });
 }