Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
ddc9b40a
Unverified
Commit
ddc9b40a
authored
Oct 12, 2023
by
Victoria Ashworth
Committed by
GitHub
Oct 12, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix typo in function name (#136273)
Rename `removeIOSimulator` to `removeIOSSimulator`.
parent
f65dd3ba
Changes
5
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
6 additions
and
6 deletions
+6
-6
hot_mode_dev_cycle_ios_simulator.dart
...devicelab/bin/tasks/hot_mode_dev_cycle_ios_simulator.dart
+1
-1
module_test_ios.dart
dev/devicelab/bin/tasks/module_test_ios.dart
+1
-1
native_assets_ios_simulator.dart
dev/devicelab/bin/tasks/native_assets_ios_simulator.dart
+1
-1
ios.dart
dev/devicelab/lib/framework/ios.dart
+2
-2
plugin_tests.dart
dev/devicelab/lib/tasks/plugin_tests.dart
+1
-1
No files found.
dev/devicelab/bin/tasks/hot_mode_dev_cycle_ios_simulator.dart
View file @
ddc9b40a
...
@@ -19,7 +19,7 @@ Future<void> main() async {
...
@@ -19,7 +19,7 @@ Future<void> main() async {
await
createHotModeTest
(
deviceIdOverride:
deviceId
,
checkAppRunningOnLocalDevice:
true
)();
await
createHotModeTest
(
deviceIdOverride:
deviceId
,
checkAppRunningOnLocalDevice:
true
)();
});
});
}
finally
{
}
finally
{
await
removeIOSimulator
(
simulatorDeviceId
);
await
removeIOS
S
imulator
(
simulatorDeviceId
);
}
}
return
TaskResult
.
success
(
null
);
return
TaskResult
.
success
(
null
);
...
...
dev/devicelab/bin/tasks/module_test_ios.dart
View file @
ddc9b40a
...
@@ -663,7 +663,7 @@ end
...
@@ -663,7 +663,7 @@ end
}
catch
(
e
)
{
}
catch
(
e
)
{
return
TaskResult
.
failure
(
e
.
toString
());
return
TaskResult
.
failure
(
e
.
toString
());
}
finally
{
}
finally
{
unawaited
(
removeIOSimulator
(
simulatorDeviceId
));
unawaited
(
removeIOS
S
imulator
(
simulatorDeviceId
));
rmTree
(
tempDir
);
rmTree
(
tempDir
);
}
}
});
});
...
...
dev/devicelab/bin/tasks/native_assets_ios_simulator.dart
View file @
ddc9b40a
...
@@ -24,7 +24,7 @@ Future<void> main() async {
...
@@ -24,7 +24,7 @@ Future<void> main() async {
},
},
);
);
}
finally
{
}
finally
{
await
removeIOSimulator
(
simulatorDeviceId
);
await
removeIOS
S
imulator
(
simulatorDeviceId
);
}
}
return
TaskResult
.
success
(
null
);
return
TaskResult
.
success
(
null
);
});
});
...
...
dev/devicelab/lib/framework/ios.dart
View file @
ddc9b40a
...
@@ -50,7 +50,7 @@ Future<String?> minPhoneOSVersion(String pathToBinary) async {
...
@@ -50,7 +50,7 @@ Future<String?> minPhoneOSVersion(String pathToBinary) async {
/// Creates and boots a new simulator, passes the new simulator's identifier to
/// Creates and boots a new simulator, passes the new simulator's identifier to
/// `testFunction`.
/// `testFunction`.
///
///
/// Remember to call removeIOSimulator in the test teardown.
/// Remember to call removeIOS
S
imulator in the test teardown.
Future
<
void
>
testWithNewIOSSimulator
(
Future
<
void
>
testWithNewIOSSimulator
(
String
deviceName
,
String
deviceName
,
SimulatorFunction
testFunction
,
{
SimulatorFunction
testFunction
,
{
...
@@ -110,7 +110,7 @@ Future<void> testWithNewIOSSimulator(
...
@@ -110,7 +110,7 @@ Future<void> testWithNewIOSSimulator(
}
}
/// Shuts down and deletes simulator with deviceId.
/// Shuts down and deletes simulator with deviceId.
Future
<
void
>
removeIOSimulator
(
String
?
deviceId
)
async
{
Future
<
void
>
removeIOS
S
imulator
(
String
?
deviceId
)
async
{
if
(
deviceId
!=
null
&&
deviceId
!=
''
)
{
if
(
deviceId
!=
null
&&
deviceId
!=
''
)
{
await
eval
(
await
eval
(
'xcrun'
,
'xcrun'
,
...
...
dev/devicelab/lib/tasks/plugin_tests.dart
View file @
ddc9b40a
...
@@ -278,7 +278,7 @@ public class $pluginClass: NSObject, FlutterPlugin {
...
@@ -278,7 +278,7 @@ public class $pluginClass: NSObject, FlutterPlugin {
}
}
});
});
}
finally
{
}
finally
{
await
removeIOSimulator
(
simulatorDeviceId
);
await
removeIOS
S
imulator
(
simulatorDeviceId
);
}
}
case
'linux'
:
case
'linux'
:
if
(
await
exec
(
if
(
await
exec
(
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment