Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
dda17485
Unverified
Commit
dda17485
authored
Feb 26, 2021
by
Jonah Williams
Committed by
GitHub
Feb 26, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] remove all mock artifacts usage (#76884)
parent
71f3e886
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
24 deletions
+10
-24
analyze_continuously_test.dart
...st/commands.shard/hermetic/analyze_continuously_test.dart
+8
-17
source_test.dart
...er_tools/test/general.shard/build_system/source_test.dart
+2
-7
No files found.
packages/flutter_tools/test/commands.shard/hermetic/analyze_continuously_test.dart
View file @
dda17485
...
...
@@ -19,7 +19,6 @@ import 'package:flutter_tools/src/commands/analyze.dart';
import
'package:flutter_tools/src/dart/analysis.dart'
;
import
'package:flutter_tools/src/dart/pub.dart'
;
import
'package:flutter_tools/src/globals.dart'
as
globals
;
import
'package:mockito/mockito.dart'
;
import
'package:process/process.dart'
;
import
'../../src/common.dart'
;
...
...
@@ -179,23 +178,20 @@ void main() {
<
FakeCommand
>[
FakeCommand
(
command:
const
<
String
>[
'
custom-dart-sdk
/bin/dart'
,
'
Artifact.engineDartSdkPath
/bin/dart'
,
'--disable-dart-dev'
,
'
custom-dart-sdk
/bin/snapshots/analysis_server.dart.snapshot'
,
'
Artifact.engineDartSdkPath
/bin/snapshots/analysis_server.dart.snapshot'
,
'--disable-server-feature-completion'
,
'--disable-server-feature-search'
,
'--sdk'
,
'
custom-dart-sdk
'
,
'
Artifact.engineDartSdkPath
'
,
],
completer:
completer
,
stdin:
IOSink
(
stdin
.
sink
),
),
]);
final
Artifacts
artifacts
=
MockArtifacts
();
when
(
artifacts
.
getArtifactPath
(
Artifact
.
engineDartSdkPath
))
.
thenReturn
(
'custom-dart-sdk'
);
final
Artifacts
artifacts
=
Artifacts
.
test
();
final
AnalyzeCommand
command
=
AnalyzeCommand
(
terminal:
Terminal
.
test
(),
artifacts:
artifacts
,
...
...
@@ -220,23 +216,20 @@ void main() {
<
FakeCommand
>[
FakeCommand
(
command:
const
<
String
>[
'
custom-dart-sdk
/bin/dart'
,
'
Artifact.engineDartSdkPath
/bin/dart'
,
'--disable-dart-dev'
,
'
custom-dart-sdk
/bin/snapshots/analysis_server.dart.snapshot'
,
'
Artifact.engineDartSdkPath
/bin/snapshots/analysis_server.dart.snapshot'
,
'--disable-server-feature-completion'
,
'--disable-server-feature-search'
,
'--sdk'
,
'
custom-dart-sdk
'
,
'
Artifact.engineDartSdkPath
'
,
],
completer:
completer
,
stdin:
IOSink
(
stdin
.
sink
),
),
]);
final
Artifacts
artifacts
=
MockArtifacts
();
when
(
artifacts
.
getArtifactPath
(
Artifact
.
engineDartSdkPath
))
.
thenReturn
(
'custom-dart-sdk'
);
final
Artifacts
artifacts
=
Artifacts
.
test
();
final
AnalyzeCommand
command
=
AnalyzeCommand
(
terminal:
Terminal
.
test
(),
artifacts:
artifacts
,
...
...
@@ -254,5 +247,3 @@ void main() {
expect
(
processManager
.
hasRemainingExpectations
,
false
);
});
}
class
MockArtifacts
extends
Mock
implements
Artifacts
{}
packages/flutter_tools/test/general.shard/build_system/source_test.dart
View file @
dda17485
...
...
@@ -11,7 +11,6 @@ import 'package:flutter_tools/src/build_info.dart';
import
'package:flutter_tools/src/build_system/build_system.dart'
;
import
'package:flutter_tools/src/build_system/exceptions.dart'
;
import
'package:flutter_tools/src/globals.dart'
as
globals
;
import
'package:mockito/mockito.dart'
;
import
'../../src/common.dart'
;
import
'../../src/context.dart'
;
...
...
@@ -218,10 +217,10 @@ void main() {
}));
test
(
'Non-local engine builds use the engine.version file as an Artifact dependency'
,
()
=>
testbed
.
run
(()
{
final
MockArtifacts
artifacts
=
MockArtifacts
();
final
Artifacts
artifacts
=
Artifacts
.
test
();
final
Environment
environment
=
Environment
.
test
(
globals
.
fs
.
currentDirectory
,
artifacts:
artifacts
,
// using real artifacts
artifacts:
artifacts
,
processManager:
FakeProcessManager
.
any
(),
fileSystem:
globals
.
fs
,
logger:
globals
.
logger
,
...
...
@@ -233,9 +232,5 @@ void main() {
fizzSource
.
accept
(
visitor
);
expect
(
visitor
.
sources
.
single
.
path
,
contains
(
'engine.version'
));
verifyNever
(
artifacts
.
getArtifactPath
(
any
,
platform:
anyNamed
(
'platform'
),
mode:
anyNamed
(
'mode'
)));
}));
}
class
MockArtifacts
extends
Mock
implements
Artifacts
{}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment