Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
dcc4fdd5
Unverified
Commit
dcc4fdd5
authored
Jan 20, 2021
by
Nate Bosch
Committed by
GitHub
Jan 20, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Pass only Uri to package:http APIs (#74285)
parent
5318782a
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
6 additions
and
7 deletions
+6
-7
stock_data.dart
dev/benchmarks/test_apps/stocks/lib/stock_data.dart
+2
-3
cocoon.dart
dev/devicelab/lib/framework/cocoon.dart
+1
-1
java_and_objc_doc.dart
dev/tools/java_and_objc_doc.dart
+1
-1
devtools_launcher.dart
packages/flutter_tools/lib/src/devtools_launcher.dart
+2
-2
No files found.
dev/benchmarks/test_apps/stocks/lib/stock_data.dart
View file @
dcc4fdd5
...
@@ -68,9 +68,8 @@ class StockData extends ChangeNotifier {
...
@@ -68,9 +68,8 @@ class StockData extends ChangeNotifier {
static
const
int
_chunkCount
=
30
;
static
const
int
_chunkCount
=
30
;
int
_nextChunk
=
0
;
int
_nextChunk
=
0
;
String
_urlToFetch
(
int
chunk
)
{
Uri
_urlToFetch
(
int
chunk
)
=>
Uri
.
https
(
return
'https://domokit.github.io/examples/stocks/data/stock_data_
$chunk
.json'
;
'domokit.github.io'
,
'examples/stocks/data/stock_data_
$chunk
.json'
);
}
http
.
Client
_httpClient
;
http
.
Client
_httpClient
;
...
...
dev/devicelab/lib/framework/cocoon.dart
View file @
dcc4fdd5
...
@@ -170,7 +170,7 @@ class Cocoon {
...
@@ -170,7 +170,7 @@ class Cocoon {
/// Make an API request to Cocoon.
/// Make an API request to Cocoon.
Future
<
Map
<
String
,
dynamic
>>
_sendCocoonRequest
(
String
apiPath
,
[
dynamic
jsonData
])
async
{
Future
<
Map
<
String
,
dynamic
>>
_sendCocoonRequest
(
String
apiPath
,
[
dynamic
jsonData
])
async
{
final
String
url
=
'
$baseCocoonApiUrl
/
$apiPath
'
;
final
Uri
url
=
Uri
.
parse
(
'
$baseCocoonApiUrl
/
$apiPath
'
)
;
/// Retry requests to Cocoon as sometimes there are issues with the servers, such
/// Retry requests to Cocoon as sometimes there are issues with the servers, such
/// as version changes to the backend, datastore issues, or latency issues.
/// as version changes to the backend, datastore issues, or latency issues.
...
...
dev/tools/java_and_objc_doc.dart
View file @
dcc4fdd5
...
@@ -28,7 +28,7 @@ Future<void> main(List<String> args) async {
...
@@ -28,7 +28,7 @@ Future<void> main(List<String> args) async {
Future
<
Archive
>
fetchArchive
(
String
url
,
int
maxTries
)
async
{
Future
<
Archive
>
fetchArchive
(
String
url
,
int
maxTries
)
async
{
List
<
int
>
responseBytes
;
List
<
int
>
responseBytes
;
for
(
int
i
=
0
;
i
<
maxTries
;
i
++)
{
for
(
int
i
=
0
;
i
<
maxTries
;
i
++)
{
final
http
.
Response
response
=
await
http
.
get
(
url
);
final
http
.
Response
response
=
await
http
.
get
(
Uri
.
parse
(
url
)
);
if
(
response
.
statusCode
==
200
)
{
if
(
response
.
statusCode
==
200
)
{
responseBytes
=
response
.
bodyBytes
;
responseBytes
=
response
.
bodyBytes
;
break
;
break
;
...
...
packages/flutter_tools/lib/src/devtools_launcher.dart
View file @
dcc4fdd5
...
@@ -53,9 +53,9 @@ class DevtoolsServerLauncher extends DevtoolsLauncher {
...
@@ -53,9 +53,9 @@ class DevtoolsServerLauncher extends DevtoolsLauncher {
try
{
try
{
const
String
pubHostedUrlKey
=
'PUB_HOSTED_URL'
;
const
String
pubHostedUrlKey
=
'PUB_HOSTED_URL'
;
if
(
_platform
.
environment
.
containsKey
(
pubHostedUrlKey
))
{
if
(
_platform
.
environment
.
containsKey
(
pubHostedUrlKey
))
{
await
http
.
head
(
_platform
.
environment
[
pubHostedUrlKey
]
);
await
http
.
head
(
Uri
.
parse
(
_platform
.
environment
[
pubHostedUrlKey
])
);
}
else
{
}
else
{
await
http
.
head
(
'https://pub.dev'
);
await
http
.
head
(
Uri
.
https
(
'pub.dev'
,
''
)
);
}
}
}
on
Exception
{
}
on
Exception
{
offline
=
true
;
offline
=
true
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment