Unverified Commit dbddcf26 authored by Siva's avatar Siva Committed by GitHub

Turn off unused changes report during hot reload (#16520)

* A new UI is being designed to make the unused reload messaging clearer,
the UI will use the coverage data to highlight lines in the UI that were not executed during a reload.

In lieu of that we are turning off the unused reload messages experiment.

There were some issues in Dart2 also with this functionality
- source fingerprinting is not implemented in Dart2
- some additional synthetic functions are generated for invocation argument checking that are not appropriately filtered out.
parent 5129d8ff
...@@ -500,6 +500,7 @@ class HotRunner extends ResidentRunner { ...@@ -500,6 +500,7 @@ class HotRunner extends ResidentRunner {
// change from host path to a device path). Subsequent reloads will // change from host path to a device path). Subsequent reloads will
// not be affected, so we resume reporting reload times on the second // not be affected, so we resume reporting reload times on the second
// reload. // reload.
final bool reportUnused = !debuggingOptions.buildInfo.previewDart2;
final bool shouldReportReloadTime = !_runningFromSnapshot; final bool shouldReportReloadTime = !_runningFromSnapshot;
final Stopwatch reloadTimer = new Stopwatch()..start(); final Stopwatch reloadTimer = new Stopwatch()..start();
...@@ -660,7 +661,7 @@ class HotRunner extends ResidentRunner { ...@@ -660,7 +661,7 @@ class HotRunner extends ResidentRunner {
flutterUsage.sendTiming('hot', 'reload', reloadTimer.elapsed); flutterUsage.sendTiming('hot', 'reload', reloadTimer.elapsed);
String unusedElementMessage; String unusedElementMessage;
if (!reassembleAndScheduleErrors && !reassembleTimedOut) { if (reportUnused && !reassembleAndScheduleErrors && !reassembleTimedOut) {
final List<Future<List<ProgramElement>>> unusedReports = final List<Future<List<ProgramElement>>> unusedReports =
<Future<List<ProgramElement>>>[]; <Future<List<ProgramElement>>>[];
for (FlutterDevice device in flutterDevices) for (FlutterDevice device in flutterDevices)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment