Unverified Commit d968b7cf authored by Jonah Williams's avatar Jonah Williams Committed by GitHub

Revert "Dont update last compiled time when compilation is rejected (#41424)" (#41515)

parent b9d8918b
......@@ -465,6 +465,7 @@ class DevFS {
generator.reset();
}
printTrace('Compiling dart to kernel with ${invalidatedFiles.length} updated files');
lastCompiled = DateTime.now();
final CompilerOutput compilerOutput = await generator.recompile(
mainPath,
invalidatedFiles,
......@@ -474,8 +475,6 @@ class DevFS {
if (compilerOutput == null || compilerOutput.errorCount > 0) {
return UpdateFSReport(success: false);
}
// Only update the last compiled time if we successfully compiled.
lastCompiled = DateTime.now();
// list of sources that needs to be monitored are in [compilerOutput.sources]
sources = compilerOutput.sources;
//
......
......@@ -178,7 +178,6 @@ void main() {
testUsingContext('reports unsuccessful compile when errors are returned', () async {
devFS = DevFS(vmService, 'test', tempDir);
await devFS.create();
final DateTime previousCompile = devFS.lastCompiled;
final RealMockResidentCompiler residentCompiler = RealMockResidentCompiler();
when(residentCompiler.recompile(
......@@ -198,7 +197,6 @@ void main() {
);
expect(report.success, false);
expect(devFS.lastCompiled, previousCompile);
}, overrides: <Type, Generator>{
FileSystem: () => fs,
});
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment