Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
d5ba4df6
Commit
d5ba4df6
authored
Oct 05, 2017
by
Alexander Aprelev
Committed by
GitHub
Oct 05, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Skip over flutter sdk packages when upgrading dependencies. (#12405)
parent
5e7bcbac
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
2 deletions
+8
-2
update_packages.dart
packages/flutter_tools/lib/src/commands/update_packages.dart
+8
-2
No files found.
packages/flutter_tools/lib/src/commands/update_packages.dart
View file @
d5ba4df6
...
@@ -371,7 +371,6 @@ class PubspecYaml {
...
@@ -371,7 +371,6 @@ class PubspecYaml {
// dependency lines.
// dependency lines.
if
(!
data
.
isTransitive
)
{
if
(!
data
.
isTransitive
)
{
assert
(!
done
.
contains
(
data
.
name
));
assert
(!
done
.
contains
(
data
.
name
));
assert
(
versions
.
contains
(
data
.
name
));
if
(
data
.
kind
==
DependencyKind
.
normal
)
{
if
(
data
.
kind
==
DependencyKind
.
normal
)
{
// This is a regular dependency, so we need to update the
// This is a regular dependency, so we need to update the
// version number.
// version number.
...
@@ -379,6 +378,7 @@ class PubspecYaml {
...
@@ -379,6 +378,7 @@ class PubspecYaml {
// We output data that matches the format that
// We output data that matches the format that
// PubspecDependency.parse can handle. The data.suffix is any
// PubspecDependency.parse can handle. The data.suffix is any
// previously-specified trailing comment.
// previously-specified trailing comment.
assert
(
versions
.
contains
(
data
.
name
));
output
.
add
(
'
${data.name}
:
${versions.versionFor(data.name)}${data.suffix}
'
);
output
.
add
(
'
${data.name}
:
${versions.versionFor(data.name)}${data.suffix}
'
);
}
else
{
}
else
{
// If it wasn't a regular dependency, then we output the line
// If it wasn't a regular dependency, then we output the line
...
@@ -677,7 +677,8 @@ String _generateFakePubspec(Iterable<PubspecDependency> dependencies) {
...
@@ -677,7 +677,8 @@ String _generateFakePubspec(Iterable<PubspecDependency> dependencies) {
result
.
writeln
(
'dependencies:'
);
result
.
writeln
(
'dependencies:'
);
overrides
.
writeln
(
'dependency_overrides:'
);
overrides
.
writeln
(
'dependency_overrides:'
);
for
(
PubspecDependency
dependency
in
dependencies
)
for
(
PubspecDependency
dependency
in
dependencies
)
dependency
.
describeForFakePubspec
(
result
,
overrides
);
if
(
dependency
.
kind
!=
DependencyKind
.
sdk
)
dependency
.
describeForFakePubspec
(
result
,
overrides
);
result
.
write
(
overrides
.
toString
());
result
.
write
(
overrides
.
toString
());
return
result
.
toString
();
return
result
.
toString
();
}
}
...
@@ -756,6 +757,11 @@ class PubDependencyTree {
...
@@ -756,6 +757,11 @@ class PubDependencyTree {
/// excluding any listen in `seen`.
/// excluding any listen in `seen`.
Iterable
<
String
>
getTransitiveDependenciesFor
(
String
package
,
{
Set
<
String
>
seen
})
sync
*
{
Iterable
<
String
>
getTransitiveDependenciesFor
(
String
package
,
{
Set
<
String
>
seen
})
sync
*
{
seen
??=
new
Set
<
String
>();
seen
??=
new
Set
<
String
>();
if
(!
_dependencyTree
.
containsKey
(
package
))
{
// We have no transitive dependencies extracted for flutter_sdk packages
// because they were omitted from pubspec.yaml used for 'pub upgrade' run.
return
;
}
for
(
String
dependency
in
_dependencyTree
[
package
])
{
for
(
String
dependency
in
_dependencyTree
[
package
])
{
if
(!
seen
.
contains
(
dependency
))
{
if
(!
seen
.
contains
(
dependency
))
{
yield
dependency
;
yield
dependency
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment