Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
d4a01644
Commit
d4a01644
authored
Sep 18, 2019
by
Robin Jespersen
Committed by
Kate Lovett
Sep 18, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Adding onEnd callback to implicit animated widgets (#38979)
parent
4373a319
Changes
4
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
410 additions
and
34 deletions
+410
-34
theme.dart
packages/flutter/lib/src/material/theme.dart
+2
-1
implicit_animations.dart
packages/flutter/lib/src/widgets/implicit_animations.dart
+36
-9
tween_animation_builder.dart
...ages/flutter/lib/src/widgets/tween_animation_builder.dart
+2
-24
implicit_animations_test.dart
packages/flutter/test/widgets/implicit_animations_test.dart
+370
-0
No files found.
packages/flutter/lib/src/material/theme.dart
View file @
d4a01644
...
@@ -227,10 +227,11 @@ class AnimatedTheme extends ImplicitlyAnimatedWidget {
...
@@ -227,10 +227,11 @@ class AnimatedTheme extends ImplicitlyAnimatedWidget {
this
.
isMaterialAppTheme
=
false
,
this
.
isMaterialAppTheme
=
false
,
Curve
curve
=
Curves
.
linear
,
Curve
curve
=
Curves
.
linear
,
Duration
duration
=
kThemeAnimationDuration
,
Duration
duration
=
kThemeAnimationDuration
,
VoidCallback
onEnd
,
@required
this
.
child
,
@required
this
.
child
,
})
:
assert
(
child
!=
null
),
})
:
assert
(
child
!=
null
),
assert
(
data
!=
null
),
assert
(
data
!=
null
),
super
(
key:
key
,
curve:
curve
,
duration:
duration
);
super
(
key:
key
,
curve:
curve
,
duration:
duration
,
onEnd:
onEnd
);
/// Specifies the color and typography values for descendant widgets.
/// Specifies the color and typography values for descendant widgets.
final
ThemeData
data
;
final
ThemeData
data
;
...
...
packages/flutter/lib/src/widgets/implicit_animations.dart
View file @
d4a01644
...
@@ -276,6 +276,7 @@ abstract class ImplicitlyAnimatedWidget extends StatefulWidget {
...
@@ -276,6 +276,7 @@ abstract class ImplicitlyAnimatedWidget extends StatefulWidget {
Key
key
,
Key
key
,
this
.
curve
=
Curves
.
linear
,
this
.
curve
=
Curves
.
linear
,
@required
this
.
duration
,
@required
this
.
duration
,
this
.
onEnd
,
})
:
assert
(
curve
!=
null
),
})
:
assert
(
curve
!=
null
),
assert
(
duration
!=
null
),
assert
(
duration
!=
null
),
super
(
key:
key
);
super
(
key:
key
);
...
@@ -286,6 +287,12 @@ abstract class ImplicitlyAnimatedWidget extends StatefulWidget {
...
@@ -286,6 +287,12 @@ abstract class ImplicitlyAnimatedWidget extends StatefulWidget {
/// The duration over which to animate the parameters of this container.
/// The duration over which to animate the parameters of this container.
final
Duration
duration
;
final
Duration
duration
;
/// Called every time an animation completes.
///
/// This can be useful to trigger additional actions (e.g. another animation)
/// at the end of the current animation.
final
VoidCallback
onEnd
;
@override
@override
ImplicitlyAnimatedWidgetState
<
ImplicitlyAnimatedWidget
>
createState
();
ImplicitlyAnimatedWidgetState
<
ImplicitlyAnimatedWidget
>
createState
();
...
@@ -356,6 +363,17 @@ abstract class ImplicitlyAnimatedWidgetState<T extends ImplicitlyAnimatedWidget>
...
@@ -356,6 +363,17 @@ abstract class ImplicitlyAnimatedWidgetState<T extends ImplicitlyAnimatedWidget>
debugLabel:
kDebugMode
?
'
${widget.toStringShort()}
'
:
null
,
debugLabel:
kDebugMode
?
'
${widget.toStringShort()}
'
:
null
,
vsync:
this
,
vsync:
this
,
);
);
_controller
.
addStatusListener
((
AnimationStatus
status
)
{
switch
(
status
)
{
case
AnimationStatus
.
completed
:
if
(
widget
.
onEnd
!=
null
)
widget
.
onEnd
();
break
;
case
AnimationStatus
.
dismissed
:
case
AnimationStatus
.
forward
:
case
AnimationStatus
.
reverse
:
}
});
_updateCurve
();
_updateCurve
();
_constructTweens
();
_constructTweens
();
didUpdateTweens
();
didUpdateTweens
();
...
@@ -624,6 +642,7 @@ class AnimatedContainer extends ImplicitlyAnimatedWidget {
...
@@ -624,6 +642,7 @@ class AnimatedContainer extends ImplicitlyAnimatedWidget {
this
.
child
,
this
.
child
,
Curve
curve
=
Curves
.
linear
,
Curve
curve
=
Curves
.
linear
,
@required
Duration
duration
,
@required
Duration
duration
,
VoidCallback
onEnd
,
})
:
assert
(
margin
==
null
||
margin
.
isNonNegative
),
})
:
assert
(
margin
==
null
||
margin
.
isNonNegative
),
assert
(
padding
==
null
||
padding
.
isNonNegative
),
assert
(
padding
==
null
||
padding
.
isNonNegative
),
assert
(
decoration
==
null
||
decoration
.
debugAssertIsValid
()),
assert
(
decoration
==
null
||
decoration
.
debugAssertIsValid
()),
...
@@ -638,7 +657,7 @@ class AnimatedContainer extends ImplicitlyAnimatedWidget {
...
@@ -638,7 +657,7 @@ class AnimatedContainer extends ImplicitlyAnimatedWidget {
?
constraints
?.
tighten
(
width:
width
,
height:
height
)
?
constraints
?.
tighten
(
width:
width
,
height:
height
)
??
BoxConstraints
.
tightFor
(
width:
width
,
height:
height
)
??
BoxConstraints
.
tightFor
(
width:
width
,
height:
height
)
:
constraints
,
:
constraints
,
super
(
key:
key
,
curve:
curve
,
duration:
duration
);
super
(
key:
key
,
curve:
curve
,
duration:
duration
,
onEnd:
onEnd
);
/// The [child] contained by the container.
/// The [child] contained by the container.
///
///
...
@@ -780,9 +799,10 @@ class AnimatedPadding extends ImplicitlyAnimatedWidget {
...
@@ -780,9 +799,10 @@ class AnimatedPadding extends ImplicitlyAnimatedWidget {
this
.
child
,
this
.
child
,
Curve
curve
=
Curves
.
linear
,
Curve
curve
=
Curves
.
linear
,
@required
Duration
duration
,
@required
Duration
duration
,
VoidCallback
onEnd
,
})
:
assert
(
padding
!=
null
),
})
:
assert
(
padding
!=
null
),
assert
(
padding
.
isNonNegative
),
assert
(
padding
.
isNonNegative
),
super
(
key:
key
,
curve:
curve
,
duration:
duration
);
super
(
key:
key
,
curve:
curve
,
duration:
duration
,
onEnd:
onEnd
);
/// The amount of space by which to inset the child.
/// The amount of space by which to inset the child.
final
EdgeInsetsGeometry
padding
;
final
EdgeInsetsGeometry
padding
;
...
@@ -859,8 +879,9 @@ class AnimatedAlign extends ImplicitlyAnimatedWidget {
...
@@ -859,8 +879,9 @@ class AnimatedAlign extends ImplicitlyAnimatedWidget {
this
.
child
,
this
.
child
,
Curve
curve
=
Curves
.
linear
,
Curve
curve
=
Curves
.
linear
,
@required
Duration
duration
,
@required
Duration
duration
,
VoidCallback
onEnd
,
})
:
assert
(
alignment
!=
null
),
})
:
assert
(
alignment
!=
null
),
super
(
key:
key
,
curve:
curve
,
duration:
duration
);
super
(
key:
key
,
curve:
curve
,
duration:
duration
,
onEnd:
onEnd
);
/// How to align the child.
/// How to align the child.
///
///
...
@@ -967,9 +988,10 @@ class AnimatedPositioned extends ImplicitlyAnimatedWidget {
...
@@ -967,9 +988,10 @@ class AnimatedPositioned extends ImplicitlyAnimatedWidget {
this
.
height
,
this
.
height
,
Curve
curve
=
Curves
.
linear
,
Curve
curve
=
Curves
.
linear
,
@required
Duration
duration
,
@required
Duration
duration
,
VoidCallback
onEnd
,
})
:
assert
(
left
==
null
||
right
==
null
||
width
==
null
),
})
:
assert
(
left
==
null
||
right
==
null
||
width
==
null
),
assert
(
top
==
null
||
bottom
==
null
||
height
==
null
),
assert
(
top
==
null
||
bottom
==
null
||
height
==
null
),
super
(
key:
key
,
curve:
curve
,
duration:
duration
);
super
(
key:
key
,
curve:
curve
,
duration:
duration
,
onEnd:
onEnd
);
/// Creates a widget that animates the rectangle it occupies implicitly.
/// Creates a widget that animates the rectangle it occupies implicitly.
///
///
...
@@ -980,13 +1002,14 @@ class AnimatedPositioned extends ImplicitlyAnimatedWidget {
...
@@ -980,13 +1002,14 @@ class AnimatedPositioned extends ImplicitlyAnimatedWidget {
Rect
rect
,
Rect
rect
,
Curve
curve
=
Curves
.
linear
,
Curve
curve
=
Curves
.
linear
,
@required
Duration
duration
,
@required
Duration
duration
,
VoidCallback
onEnd
,
})
:
left
=
rect
.
left
,
})
:
left
=
rect
.
left
,
top
=
rect
.
top
,
top
=
rect
.
top
,
width
=
rect
.
width
,
width
=
rect
.
width
,
height
=
rect
.
height
,
height
=
rect
.
height
,
right
=
null
,
right
=
null
,
bottom
=
null
,
bottom
=
null
,
super
(
key:
key
,
curve:
curve
,
duration:
duration
);
super
(
key:
key
,
curve:
curve
,
duration:
duration
,
onEnd:
onEnd
);
/// The widget below this widget in the tree.
/// The widget below this widget in the tree.
///
///
...
@@ -1118,9 +1141,10 @@ class AnimatedPositionedDirectional extends ImplicitlyAnimatedWidget {
...
@@ -1118,9 +1141,10 @@ class AnimatedPositionedDirectional extends ImplicitlyAnimatedWidget {
this
.
height
,
this
.
height
,
Curve
curve
=
Curves
.
linear
,
Curve
curve
=
Curves
.
linear
,
@required
Duration
duration
,
@required
Duration
duration
,
VoidCallback
onEnd
,
})
:
assert
(
start
==
null
||
end
==
null
||
width
==
null
),
})
:
assert
(
start
==
null
||
end
==
null
||
width
==
null
),
assert
(
top
==
null
||
bottom
==
null
||
height
==
null
),
assert
(
top
==
null
||
bottom
==
null
||
height
==
null
),
super
(
key:
key
,
curve:
curve
,
duration:
duration
);
super
(
key:
key
,
curve:
curve
,
duration:
duration
,
onEnd:
onEnd
);
/// The widget below this widget in the tree.
/// The widget below this widget in the tree.
///
///
...
@@ -1274,9 +1298,10 @@ class AnimatedOpacity extends ImplicitlyAnimatedWidget {
...
@@ -1274,9 +1298,10 @@ class AnimatedOpacity extends ImplicitlyAnimatedWidget {
@required
this
.
opacity
,
@required
this
.
opacity
,
Curve
curve
=
Curves
.
linear
,
Curve
curve
=
Curves
.
linear
,
@required
Duration
duration
,
@required
Duration
duration
,
VoidCallback
onEnd
,
this
.
alwaysIncludeSemantics
=
false
,
this
.
alwaysIncludeSemantics
=
false
,
})
:
assert
(
opacity
!=
null
&&
opacity
>=
0.0
&&
opacity
<=
1.0
),
})
:
assert
(
opacity
!=
null
&&
opacity
>=
0.0
&&
opacity
<=
1.0
),
super
(
key:
key
,
curve:
curve
,
duration:
duration
);
super
(
key:
key
,
curve:
curve
,
duration:
duration
,
onEnd:
onEnd
);
/// The widget below this widget in the tree.
/// The widget below this widget in the tree.
///
///
...
@@ -1369,12 +1394,13 @@ class AnimatedDefaultTextStyle extends ImplicitlyAnimatedWidget {
...
@@ -1369,12 +1394,13 @@ class AnimatedDefaultTextStyle extends ImplicitlyAnimatedWidget {
this
.
maxLines
,
this
.
maxLines
,
Curve
curve
=
Curves
.
linear
,
Curve
curve
=
Curves
.
linear
,
@required
Duration
duration
,
@required
Duration
duration
,
VoidCallback
onEnd
,
})
:
assert
(
style
!=
null
),
})
:
assert
(
style
!=
null
),
assert
(
child
!=
null
),
assert
(
child
!=
null
),
assert
(
softWrap
!=
null
),
assert
(
softWrap
!=
null
),
assert
(
overflow
!=
null
),
assert
(
overflow
!=
null
),
assert
(
maxLines
==
null
||
maxLines
>
0
),
assert
(
maxLines
==
null
||
maxLines
>
0
),
super
(
key:
key
,
curve:
curve
,
duration:
duration
);
super
(
key:
key
,
curve:
curve
,
duration:
duration
,
onEnd:
onEnd
);
/// The widget below this widget in the tree.
/// The widget below this widget in the tree.
///
///
...
@@ -1484,6 +1510,7 @@ class AnimatedPhysicalModel extends ImplicitlyAnimatedWidget {
...
@@ -1484,6 +1510,7 @@ class AnimatedPhysicalModel extends ImplicitlyAnimatedWidget {
this
.
animateShadowColor
=
true
,
this
.
animateShadowColor
=
true
,
Curve
curve
=
Curves
.
linear
,
Curve
curve
=
Curves
.
linear
,
@required
Duration
duration
,
@required
Duration
duration
,
VoidCallback
onEnd
,
})
:
assert
(
child
!=
null
),
})
:
assert
(
child
!=
null
),
assert
(
shape
!=
null
),
assert
(
shape
!=
null
),
assert
(
clipBehavior
!=
null
),
assert
(
clipBehavior
!=
null
),
...
@@ -1493,7 +1520,7 @@ class AnimatedPhysicalModel extends ImplicitlyAnimatedWidget {
...
@@ -1493,7 +1520,7 @@ class AnimatedPhysicalModel extends ImplicitlyAnimatedWidget {
assert
(
shadowColor
!=
null
),
assert
(
shadowColor
!=
null
),
assert
(
animateColor
!=
null
),
assert
(
animateColor
!=
null
),
assert
(
animateShadowColor
!=
null
),
assert
(
animateShadowColor
!=
null
),
super
(
key:
key
,
curve:
curve
,
duration:
duration
);
super
(
key:
key
,
curve:
curve
,
duration:
duration
,
onEnd:
onEnd
);
/// The widget below this widget in the tree.
/// The widget below this widget in the tree.
///
///
...
...
packages/flutter/lib/src/widgets/tween_animation_builder.dart
View file @
d4a01644
...
@@ -127,12 +127,12 @@ class TweenAnimationBuilder<T> extends ImplicitlyAnimatedWidget {
...
@@ -127,12 +127,12 @@ class TweenAnimationBuilder<T> extends ImplicitlyAnimatedWidget {
@required
Duration
duration
,
@required
Duration
duration
,
Curve
curve
=
Curves
.
linear
,
Curve
curve
=
Curves
.
linear
,
@required
this
.
builder
,
@required
this
.
builder
,
this
.
onEnd
,
VoidCallback
onEnd
,
this
.
child
,
this
.
child
,
})
:
assert
(
tween
!=
null
),
})
:
assert
(
tween
!=
null
),
assert
(
curve
!=
null
),
assert
(
curve
!=
null
),
assert
(
builder
!=
null
),
assert
(
builder
!=
null
),
super
(
key:
key
,
duration:
duration
,
curve:
curve
);
super
(
key:
key
,
duration:
duration
,
curve:
curve
,
onEnd:
onEnd
);
/// Defines the target value for the animation.
/// Defines the target value for the animation.
///
///
...
@@ -186,12 +186,6 @@ class TweenAnimationBuilder<T> extends ImplicitlyAnimatedWidget {
...
@@ -186,12 +186,6 @@ class TweenAnimationBuilder<T> extends ImplicitlyAnimatedWidget {
/// performance significantly in some cases and is therefore a good practice.
/// performance significantly in some cases and is therefore a good practice.
final
Widget
child
;
final
Widget
child
;
/// Called every time an animation completes.
///
/// This can be useful to trigger additional actions (e.g. another animation)
/// at the end of the current animation.
final
VoidCallback
onEnd
;
@override
@override
ImplicitlyAnimatedWidgetState
<
ImplicitlyAnimatedWidget
>
createState
()
{
ImplicitlyAnimatedWidgetState
<
ImplicitlyAnimatedWidget
>
createState
()
{
return
_TweenAnimationBuilderState
<
T
>();
return
_TweenAnimationBuilderState
<
T
>();
...
@@ -206,27 +200,11 @@ class _TweenAnimationBuilderState<T> extends AnimatedWidgetBaseState<TweenAnimat
...
@@ -206,27 +200,11 @@ class _TweenAnimationBuilderState<T> extends AnimatedWidgetBaseState<TweenAnimat
_currentTween
=
widget
.
tween
;
_currentTween
=
widget
.
tween
;
_currentTween
.
begin
??=
_currentTween
.
end
;
_currentTween
.
begin
??=
_currentTween
.
end
;
super
.
initState
();
super
.
initState
();
// The statusListener is removed when the superclass disposes the controller.
controller
.
addStatusListener
(
_onAnimationStatusChanged
);
if
(
_currentTween
.
begin
!=
_currentTween
.
end
)
{
if
(
_currentTween
.
begin
!=
_currentTween
.
end
)
{
controller
.
forward
();
controller
.
forward
();
}
}
}
}
void
_onAnimationStatusChanged
(
AnimationStatus
status
)
{
switch
(
status
)
{
case
AnimationStatus
.
dismissed
:
case
AnimationStatus
.
forward
:
case
AnimationStatus
.
reverse
:
break
;
case
AnimationStatus
.
completed
:
if
(
widget
.
onEnd
!=
null
)
{
widget
.
onEnd
();
}
break
;
}
}
@override
@override
void
forEachTween
(
TweenVisitor
<
dynamic
>
visitor
)
{
void
forEachTween
(
TweenVisitor
<
dynamic
>
visitor
)
{
assert
(
assert
(
...
...
packages/flutter/test/widgets/implicit_animations_test.dart
View file @
d4a01644
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment