Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
d127f2c9
Unverified
Commit
d127f2c9
authored
Oct 08, 2020
by
Michael Goderbauer
Committed by
GitHub
Oct 08, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix nullability for some routing related stuff (#67675)
parent
4042eb97
Changes
5
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
109 additions
and
91 deletions
+109
-91
layer.dart
packages/flutter/lib/src/rendering/layer.dart
+2
-2
raw_keyboard.dart
packages/flutter/lib/src/services/raw_keyboard.dart
+1
-2
drag_target.dart
packages/flutter/lib/src/widgets/drag_target.dart
+0
-1
routes.dart
packages/flutter/lib/src/widgets/routes.dart
+2
-2
routes_test.dart
packages/flutter/test/widgets/routes_test.dart
+104
-84
No files found.
packages/flutter/lib/src/rendering/layer.dart
View file @
d127f2c9
...
...
@@ -2225,7 +2225,7 @@ class FollowerLayer extends ContainerLayer {
Matrix4
?
_invertedTransform
;
bool
_inverseDirty
=
true
;
Offset
?
_transformOffset
<
S
extends
Object
>
(
Offset
localPosition
)
{
Offset
?
_transformOffset
(
Offset
localPosition
)
{
if
(
_inverseDirty
)
{
_invertedTransform
=
Matrix4
.
tryInvert
(
getLastTransform
()!);
_inverseDirty
=
false
;
...
...
@@ -2245,7 +2245,7 @@ class FollowerLayer extends ContainerLayer {
}
return
false
;
}
final
Offset
?
transformedOffset
=
_transformOffset
<
S
>
(
localPosition
);
final
Offset
?
transformedOffset
=
_transformOffset
(
localPosition
);
if
(
transformedOffset
==
null
)
{
return
false
;
}
...
...
packages/flutter/lib/src/services/raw_keyboard.dart
View file @
d127f2c9
...
...
@@ -2,7 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import
'dart:io'
;
import
'dart:ui'
;
...
...
@@ -737,7 +736,7 @@ class RawKeyboard {
}
@immutable
class
_ModifierSidePair
extends
Object
{
class
_ModifierSidePair
{
const
_ModifierSidePair
(
this
.
modifier
,
this
.
side
);
final
ModifierKey
modifier
;
...
...
packages/flutter/lib/src/widgets/drag_target.dart
View file @
d127f2c9
...
...
@@ -131,7 +131,6 @@ class Draggable<T extends Object> extends StatefulWidget {
assert
(
maxSimultaneousDrags
==
null
||
maxSimultaneousDrags
>=
0
),
super
(
key:
key
);
/// The data that will be dropped by this draggable.
final
T
?
data
;
...
...
packages/flutter/lib/src/widgets/routes.dart
View file @
d127f2c9
...
...
@@ -881,7 +881,7 @@ abstract class ModalRoute<T> extends TransitionRoute<T> with LocalHistoryRoute<T
/// The given [BuildContext] will be rebuilt if the state of the route changes
/// while it is visible (specifically, if [isCurrent] or [canPop] change value).
@optionalTypeArgs
static
ModalRoute
<
T
>?
of
<
T
extends
Object
>(
BuildContext
context
)
{
static
ModalRoute
<
T
>?
of
<
T
extends
Object
?
>(
BuildContext
context
)
{
final
_ModalScopeStatus
?
widget
=
context
.
dependOnInheritedWidgetOfExactType
<
_ModalScopeStatus
>();
return
widget
?.
route
as
ModalRoute
<
T
>?;
}
...
...
@@ -1818,7 +1818,7 @@ class _DialogRoute<T> extends PopupRoute<T> {
///
/// * [showDialog], which displays a Material-style dialog.
/// * [showCupertinoDialog], which displays an iOS-style dialog.
Future
<
T
>
showGeneralDialog
<
T
extends
Object
>({
Future
<
T
>
showGeneralDialog
<
T
extends
Object
?
>({
required
BuildContext
context
,
required
RoutePageBuilder
pageBuilder
,
bool
barrierDismissible
=
false
,
...
...
packages/flutter/test/widgets/routes_test.dart
View file @
d127f2c9
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment