Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
cfff88b2
Unverified
Commit
cfff88b2
authored
Jul 12, 2022
by
Youssef Attia
Committed by
GitHub
Jul 12, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remerge "Fixed AnimatedSwitcher chain produced duplicates" after fixing issues with g3
This reverts commit
1d2fa285
.
parent
e6f69add
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
21 additions
and
1 deletion
+21
-1
animated_switcher.dart
packages/flutter/lib/src/widgets/animated_switcher.dart
+2
-1
animated_switcher_test.dart
packages/flutter/test/widgets/animated_switcher_test.dart
+19
-0
No files found.
packages/flutter/lib/src/widgets/animated_switcher.dart
View file @
cfff88b2
...
...
@@ -222,6 +222,7 @@ class AnimatedSwitcher extends StatefulWidget {
/// This is an [AnimatedSwitcherTransitionBuilder] function.
static
Widget
defaultTransitionBuilder
(
Widget
child
,
Animation
<
double
>
animation
)
{
return
FadeTransition
(
key:
ValueKey
<
Key
?>(
child
.
key
),
opacity:
animation
,
child:
child
,
);
...
...
@@ -394,6 +395,6 @@ class _AnimatedSwitcherState extends State<AnimatedSwitcher> with TickerProvider
@override
Widget
build
(
BuildContext
context
)
{
_rebuildOutgoingWidgetsIfNeeded
();
return
widget
.
layoutBuilder
(
_currentEntry
?.
transition
,
_outgoingWidgets
!);
return
widget
.
layoutBuilder
(
_currentEntry
?.
transition
,
_outgoingWidgets
!
.
where
((
Widget
outgoing
)
=>
outgoing
.
key
!=
_currentEntry
?.
transition
.
key
).
toSet
().
toList
()
);
}
}
packages/flutter/test/widgets/animated_switcher_test.dart
View file @
cfff88b2
...
...
@@ -415,6 +415,25 @@ void main() {
);
}
});
testWidgets
(
'AnimatedSwitcher does not duplicate animations if the same child is entered twice.'
,
(
WidgetTester
tester
)
async
{
Future
<
void
>
pumpChild
(
Widget
child
)
async
{
return
tester
.
pumpWidget
(
Directionality
(
textDirection:
TextDirection
.
ltr
,
child:
AnimatedSwitcher
(
duration:
const
Duration
(
milliseconds:
1000
),
child:
child
,
),
),
);
}
await
pumpChild
(
const
Text
(
'1'
,
key:
Key
(
'1'
)));
await
pumpChild
(
const
Text
(
'2'
,
key:
Key
(
'2'
)));
await
pumpChild
(
const
Text
(
'1'
,
key:
Key
(
'1'
)));
await
tester
.
pump
(
const
Duration
(
milliseconds:
1000
));
expect
(
find
.
text
(
'1'
),
findsOneWidget
);
});
}
class
StatefulTest
extends
StatefulWidget
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment