Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
cf744198
Unverified
Commit
cf744198
authored
Jan 24, 2019
by
Dan Field
Committed by
GitHub
Jan 24, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "Experimental flags for hot reloads (#26988)" (#27037)
This reverts commit
763bf114
.
parent
763bf114
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
2 additions
and
17 deletions
+2
-17
run.dart
packages/flutter_tools/lib/src/commands/run.dart
+0
-6
compile.dart
packages/flutter_tools/lib/src/compile.dart
+2
-9
resident_runner.dart
packages/flutter_tools/lib/src/resident_runner.dart
+0
-2
No files found.
packages/flutter_tools/lib/src/commands/run.dart
View file @
cf744198
...
...
@@ -333,11 +333,6 @@ class RunCommand extends RunCommandBase {
throwToolExit
(
'Error: --train is only allowed when running as --dynamic --profile '
'(recommended) or --debug (may include unwanted debug symbols).'
);
List
<
String
>
expFlags
=
null
;
if
(
argParser
.
options
.
containsKey
(
FlutterOptions
.
kEnableExperiment
)
&&
argResults
[
FlutterOptions
.
kEnableExperiment
]
!=
null
)
{
expFlags
=
argResults
[
FlutterOptions
.
kEnableExperiment
];
}
final
List
<
FlutterDevice
>
flutterDevices
=
devices
.
map
<
FlutterDevice
>((
Device
device
)
{
return
FlutterDevice
(
device
,
...
...
@@ -346,7 +341,6 @@ class RunCommand extends RunCommandBase {
fileSystemRoots:
argResults
[
'filesystem-root'
],
fileSystemScheme:
argResults
[
'filesystem-scheme'
],
viewFilter:
argResults
[
'isolate-filter'
],
experimentalFlags:
expFlags
,
);
}).
toList
();
...
...
packages/flutter_tools/lib/src/compile.dart
View file @
cf744198
...
...
@@ -332,8 +332,7 @@ class ResidentCompiler {
CompilerMessageConsumer
compilerMessageConsumer
=
printError
,
String
initializeFromDill
,
TargetModel
targetModel
=
TargetModel
.
flutter
,
bool
unsafePackageSerialization
,
List
<
String
>
experimentalFlags
,
bool
unsafePackageSerialization
})
:
assert
(
_sdkRoot
!=
null
),
_trackWidgetCreation
=
trackWidgetCreation
,
_packagesPath
=
packagesPath
,
...
...
@@ -343,8 +342,7 @@ class ResidentCompiler {
_stdoutHandler
=
_StdoutHandler
(
consumer:
compilerMessageConsumer
),
_controller
=
StreamController
<
_CompilationRequest
>(),
_initializeFromDill
=
initializeFromDill
,
_unsafePackageSerialization
=
unsafePackageSerialization
,
_experimentalFlags
=
experimentalFlags
{
_unsafePackageSerialization
=
unsafePackageSerialization
{
// This is a URI, not a file path, so the forward slash is correct even on Windows.
if
(!
_sdkRoot
.
endsWith
(
'/'
))
_sdkRoot
=
'
$_sdkRoot
/'
;
...
...
@@ -360,7 +358,6 @@ class ResidentCompiler {
final
_StdoutHandler
_stdoutHandler
;
String
_initializeFromDill
;
bool
_unsafePackageSerialization
;
final
List
<
String
>
_experimentalFlags
;
final
StreamController
<
_CompilationRequest
>
_controller
;
...
...
@@ -473,10 +470,6 @@ class ResidentCompiler {
if
(
_unsafePackageSerialization
==
true
)
{
command
.
add
(
'--unsafe-package-serialization'
);
}
if
(
_experimentalFlags
!=
null
)
{
var
expFlags
=
_experimentalFlags
.
join
(
","
);
command
.
add
(
'--enable-experiment=
${expFlags}
'
);
}
printTrace
(
command
.
join
(
' '
));
_server
=
await
processManager
.
start
(
command
);
_server
.
stdout
...
...
packages/flutter_tools/lib/src/resident_runner.dart
View file @
cf744198
...
...
@@ -35,7 +35,6 @@ class FlutterDevice {
this
.
fileSystemScheme
,
this
.
viewFilter
,
TargetModel
targetModel
=
TargetModel
.
flutter
,
List
<
String
>
experimentalFlags
,
ResidentCompiler
generator
,
})
:
assert
(
trackWidgetCreation
!=
null
),
generator
=
generator
??
ResidentCompiler
(
...
...
@@ -44,7 +43,6 @@ class FlutterDevice {
fileSystemRoots:
fileSystemRoots
,
fileSystemScheme:
fileSystemScheme
,
targetModel:
targetModel
,
experimentalFlags:
experimentalFlags
,
);
final
Device
device
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment