Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
cf6d4a35
Unverified
Commit
cf6d4a35
authored
Mar 30, 2021
by
Jonah Williams
Committed by
GitHub
Mar 30, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] guard L service extension in debug mode (#79173)
parent
e6920662
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
17 additions
and
1 deletion
+17
-1
resident_runner.dart
packages/flutter_tools/lib/src/resident_runner.dart
+1
-1
resident_runner_test.dart
...lutter_tools/test/general.shard/resident_runner_test.dart
+16
-0
No files found.
packages/flutter_tools/lib/src/resident_runner.dart
View file @
cf6d4a35
...
...
@@ -1009,7 +1009,7 @@ abstract class ResidentRunner {
}
Future
<
bool
>
debugDumpLayerTree
()
async
{
if
(!
supportsServiceProtocol
)
{
if
(!
supportsServiceProtocol
||
!
isRunningDebug
)
{
return
false
;
}
for
(
final
FlutterDevice
device
in
flutterDevices
)
{
...
...
packages/flutter_tools/test/general.shard/resident_runner_test.dart
View file @
cf6d4a35
...
...
@@ -1976,6 +1976,22 @@ void main() {
verifyNever
(
mockFlutterDevice
.
debugDumpLayerTree
());
}));
testUsingContext
(
'ResidentRunner debugDumpLayerTree does not call flutter device if not running in debug mode'
,
()
=>
testbed
.
run
(()
async
{
fakeVmServiceHost
=
FakeVmServiceHost
(
requests:
<
VmServiceExpectation
>[]);
residentRunner
=
HotRunner
(
<
FlutterDevice
>[
mockFlutterDevice
,
],
stayResident:
false
,
debuggingOptions:
DebuggingOptions
.
enabled
(
BuildInfo
.
profile
),
target:
'main.dart'
,
devtoolsHandler:
createNoOpHandler
,
);
expect
(
await
residentRunner
.
debugDumpLayerTree
(),
false
);
verifyNever
(
mockFlutterDevice
.
debugDumpLayerTree
());
}));
testUsingContext
(
'ResidentRunner debugDumpSemanticsTreeInTraversalOrder calls flutter device'
,
()
=>
testbed
.
run
(()
async
{
fakeVmServiceHost
=
FakeVmServiceHost
(
requests:
<
VmServiceExpectation
>[]);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment