Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
ceade39c
Unverified
Commit
ceade39c
authored
Apr 26, 2018
by
Todd Volkert
Committed by
GitHub
Apr 26, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "Extract Xxd class for iOS AOT snapshotting (#16986)" (#17003)
This reverts commit
4bb7496b
.
parent
4bb7496b
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
17 deletions
+7
-17
build_aot.dart
packages/flutter_tools/lib/src/commands/build_aot.dart
+7
-9
mac.dart
packages/flutter_tools/lib/src/ios/mac.dart
+0
-8
No files found.
packages/flutter_tools/lib/src/commands/build_aot.dart
View file @
ceade39c
...
@@ -16,7 +16,7 @@ import '../build_info.dart';
...
@@ -16,7 +16,7 @@ import '../build_info.dart';
import
'../compile.dart'
;
import
'../compile.dart'
;
import
'../dart/package_map.dart'
;
import
'../dart/package_map.dart'
;
import
'../globals.dart'
;
import
'../globals.dart'
;
import
'../ios/mac.dart'
show
xcode
,
xxd
;
import
'../ios/mac.dart'
show
xcode
;
import
'../resident_runner.dart'
;
import
'../resident_runner.dart'
;
import
'../runner/flutter_command.dart'
;
import
'../runner/flutter_command.dart'
;
import
'build.dart'
;
import
'build.dart'
;
...
@@ -422,14 +422,12 @@ Future<String> _buildAotSnapshot(
...
@@ -422,14 +422,12 @@ Future<String> _buildAotSnapshot(
await
fs
.
file
(
vmSnapshotData
).
rename
(
fs
.
path
.
join
(
outputDir
.
path
,
kVmSnapshotData
));
await
fs
.
file
(
vmSnapshotData
).
rename
(
fs
.
path
.
join
(
outputDir
.
path
,
kVmSnapshotData
));
await
fs
.
file
(
isolateSnapshotData
).
rename
(
fs
.
path
.
join
(
outputDir
.
path
,
kIsolateSnapshotData
));
await
fs
.
file
(
isolateSnapshotData
).
rename
(
fs
.
path
.
join
(
outputDir
.
path
,
kIsolateSnapshotData
));
await
xxd
.
run
(
await
runCheckedAsync
(<
String
>[
<
String
>[
'--include'
,
kVmSnapshotData
,
fs
.
path
.
basename
(
kVmSnapshotDataC
)],
'xxd'
,
'--include'
,
kVmSnapshotData
,
fs
.
path
.
basename
(
kVmSnapshotDataC
)
workingDirectory:
outputDir
.
path
,
],
workingDirectory:
outputDir
.
path
);
);
await
runCheckedAsync
(<
String
>[
await
xxd
.
run
(
'xxd'
,
'--include'
,
kIsolateSnapshotData
,
fs
.
path
.
basename
(
kIsolateSnapshotDataC
)
<
String
>[
'--include'
,
kIsolateSnapshotData
,
fs
.
path
.
basename
(
kIsolateSnapshotDataC
)],
],
workingDirectory:
outputDir
.
path
);
workingDirectory:
outputDir
.
path
,
);
await
xcode
.
cc
(
commonBuildOptions
.
toList
()..
addAll
(<
String
>[
'-c'
,
kVmSnapshotDataC
,
'-o'
,
kVmSnapshotDataO
]));
await
xcode
.
cc
(
commonBuildOptions
.
toList
()..
addAll
(<
String
>[
'-c'
,
kVmSnapshotDataC
,
'-o'
,
kVmSnapshotDataO
]));
await
xcode
.
cc
(
commonBuildOptions
.
toList
()..
addAll
(<
String
>[
'-c'
,
kIsolateSnapshotDataC
,
'-o'
,
kIsolateSnapshotDataO
]));
await
xcode
.
cc
(
commonBuildOptions
.
toList
()..
addAll
(<
String
>[
'-c'
,
kIsolateSnapshotDataC
,
'-o'
,
kIsolateSnapshotDataO
]));
...
...
packages/flutter_tools/lib/src/ios/mac.dart
View file @
ceade39c
...
@@ -39,8 +39,6 @@ IMobileDevice get iMobileDevice => context[IMobileDevice];
...
@@ -39,8 +39,6 @@ IMobileDevice get iMobileDevice => context[IMobileDevice];
Xcode
get
xcode
=>
context
[
Xcode
];
Xcode
get
xcode
=>
context
[
Xcode
];
Xxd
get
xxd
=>
context
[
Xxd
];
class
PythonModule
{
class
PythonModule
{
const
PythonModule
(
this
.
name
);
const
PythonModule
(
this
.
name
);
...
@@ -105,12 +103,6 @@ class IMobileDevice {
...
@@ -105,12 +103,6 @@ class IMobileDevice {
}
}
}
}
class
Xxd
{
Future
<
RunResult
>
run
(
List
<
String
>
args
,
{
String
workingDirectory
})
{
return
runCheckedAsync
(<
String
>[
'xxd'
]..
addAll
(
args
),
workingDirectory:
workingDirectory
);
}
}
class
Xcode
{
class
Xcode
{
bool
get
isInstalledAndMeetsVersionCheck
=>
isInstalled
&&
isVersionSatisfactory
;
bool
get
isInstalledAndMeetsVersionCheck
=>
isInstalled
&&
isVersionSatisfactory
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment