Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
ce2c708a
Unverified
Commit
ce2c708a
authored
Oct 01, 2019
by
Jonah Williams
Committed by
GitHub
Oct 01, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add more information to cannot find Chrome message (#41695)
parent
5e1f600f
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
2 deletions
+3
-2
web_validator.dart
packages/flutter_tools/lib/src/web/web_validator.dart
+2
-1
web_validator_test.dart
...tter_tools/test/general.shard/web/web_validator_test.dart
+1
-1
No files found.
packages/flutter_tools/lib/src/web/web_validator.dart
View file @
ce2c708a
...
...
@@ -22,7 +22,8 @@ class WebValidator extends DoctorValidator {
ValidationMessage
(
'
$kChromeEnvironment
=
$chrome
'
)
else
if
(!
canRunChrome
)
ValidationMessage
.
hint
(
'
$kChromeEnvironment
not set'
)
ValidationMessage
.
hint
(
'Cannot find Chrome. Try setting '
'
$kChromeEnvironment
to a Chrome executable.'
)
else
ValidationMessage
(
'Chrome at
$chrome
'
),
];
...
...
packages/flutter_tools/test/general.shard/web/web_validator_test.dart
View file @
ce2c708a
...
...
@@ -50,7 +50,7 @@ void main() {
when
(
mockProcessManager
.
canRun
(
kMacOSExecutable
)).
thenReturn
(
false
);
final
ValidationResult
result
=
await
webValidator
.
validate
();
expect
(
result
.
messages
,
<
ValidationMessage
>[
ValidationMessage
.
hint
(
'C
HROME_EXECUTABLE not set
'
),
ValidationMessage
.
hint
(
'C
annot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.
'
),
]);
expect
(
result
.
type
,
ValidationType
.
missing
);
}));
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment