Unverified Commit cded7efb authored by xster's avatar xster Committed by GitHub

Fix CupertinoSwitch accessibility (#19927)

parent dfe5b591
......@@ -26,42 +26,51 @@ class _CupertinoSwitchDemoState extends State<CupertinoSwitchDemo> {
child: new Column(
mainAxisAlignment: MainAxisAlignment.spaceAround,
children: <Widget>[
new Column(
children: <Widget>[
new CupertinoSwitch(
value: _switchValue,
onChanged: (bool value) {
setState(() {
_switchValue = value;
});
},
),
const Text(
'Active'
),
],
new Semantics(
container: true,
child: new Column(
children: <Widget>[
new CupertinoSwitch(
value: _switchValue,
onChanged: (bool value) {
setState(() {
_switchValue = value;
});
},
),
const Text(
'Active'
),
],
),
),
new Column(
children: const <Widget>[
const CupertinoSwitch(
value: true,
onChanged: null,
),
const Text(
'Disabled'
),
],
new Semantics(
container: true,
child: new Column(
children: const <Widget>[
const CupertinoSwitch(
value: true,
onChanged: null,
),
const Text(
'Disabled'
),
],
),
),
new Column(
children: const <Widget>[
const CupertinoSwitch(
value: false,
onChanged: null,
),
const Text(
'Disabled'
),
],
new Semantics(
container: true,
child: new Column(
children: const <Widget>[
const CupertinoSwitch(
value: false,
onChanged: null,
),
const Text(
'Disabled'
),
],
),
),
],
),
......
......@@ -380,10 +380,11 @@ class _RenderCupertinoSwitch extends RenderConstrainedBox {
void describeSemanticsConfiguration(SemanticsConfiguration config) {
super.describeSemanticsConfiguration(config);
config.isSemanticBoundary = isInteractive;
if (isInteractive)
config.onTap = _handleTap;
config.isChecked = _value;
config.isEnabled = isInteractive;
config.isToggled = _value;
}
final CupertinoThumbPainter _thumbPainter = new CupertinoThumbPainter();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment