Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
cdbd0f9d
Commit
cdbd0f9d
authored
Mar 19, 2019
by
Priit Lätt
Committed by
Jonah Williams
Mar 19, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use async execution for xcodebuild commands (#29048)
parent
2b7ad974
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
5 deletions
+5
-5
mac.dart
packages/flutter_tools/lib/src/ios/mac.dart
+1
-1
xcodeproj.dart
packages/flutter_tools/lib/src/ios/xcodeproj.dart
+3
-3
context.dart
packages/flutter_tools/test/src/context.dart
+1
-1
No files found.
packages/flutter_tools/lib/src/ios/mac.dart
View file @
cdbd0f9d
...
...
@@ -311,7 +311,7 @@ Future<XcodeBuildResult> buildXcodeProject({
modern:
false
,
);
final
XcodeProjectInfo
projectInfo
=
xcodeProjectInterpreter
.
getInfo
(
app
.
project
.
hostAppRoot
.
path
);
final
XcodeProjectInfo
projectInfo
=
await
xcodeProjectInterpreter
.
getInfo
(
app
.
project
.
hostAppRoot
.
path
);
if
(!
projectInfo
.
targets
.
contains
(
'Runner'
))
{
printError
(
'The Xcode project does not define target "Runner" which is needed by Flutter tooling.'
);
printError
(
'Open Xcode to fix the problem:'
);
...
...
packages/flutter_tools/lib/src/ios/xcodeproj.dart
View file @
cdbd0f9d
...
...
@@ -161,11 +161,11 @@ class XcodeProjectInterpreter {
return
parseXcodeBuildSettings
(
out
);
}
XcodeProjectInfo
getInfo
(
String
projectPath
)
{
final
String
out
=
runCheckedS
ync
(<
String
>[
Future
<
XcodeProjectInfo
>
getInfo
(
String
projectPath
)
async
{
final
RunResult
result
=
await
runCheckedAs
ync
(<
String
>[
_executable
,
'-list'
,
],
workingDirectory:
projectPath
);
return
XcodeProjectInfo
.
fromXcodeBuildOutput
(
out
);
return
XcodeProjectInfo
.
fromXcodeBuildOutput
(
result
.
toString
()
);
}
}
...
...
packages/flutter_tools/test/src/context.dart
View file @
cdbd0f9d
...
...
@@ -294,7 +294,7 @@ class MockXcodeProjectInterpreter implements XcodeProjectInterpreter {
}
@override
XcodeProjectInfo
getInfo
(
String
projectPath
)
{
Future
<
XcodeProjectInfo
>
getInfo
(
String
projectPath
)
async
{
return
XcodeProjectInfo
(
<
String
>[
'Runner'
],
<
String
>[
'Debug'
,
'Release'
],
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment