Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
cbc121e3
Unverified
Commit
cbc121e3
authored
Apr 22, 2020
by
Kate Lovett
Committed by
GitHub
Apr 22, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
ToDo Audit - Cupertino+ Library (#54798)
parent
88fd7081
Changes
6
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
13 additions
and
16 deletions
+13
-16
dartdoc.dart
dev/tools/dartdoc.dart
+1
-5
image_cache_tracing_test.dart
dev/tracing_tests/test/image_cache_tracing_test.dart
+1
-1
custom_semantics_test.dart
examples/catalog/test/custom_semantics_test.dart
+1
-4
action_sheet.dart
packages/flutter/lib/src/cupertino/action_sheet.dart
+4
-2
context_menu.dart
packages/flutter/lib/src/cupertino/context_menu.dart
+2
-2
dialog.dart
packages/flutter/lib/src/cupertino/dialog.dart
+4
-2
No files found.
dev/tools/dartdoc.dart
View file @
cbc121e3
...
@@ -50,11 +50,7 @@ Future<void> main(List<String> arguments) async {
...
@@ -50,11 +50,7 @@ Future<void> main(List<String> arguments) async {
final
StringBuffer
buf
=
StringBuffer
();
final
StringBuffer
buf
=
StringBuffer
();
buf
.
writeln
(
'name: Flutter'
);
buf
.
writeln
(
'name: Flutter'
);
buf
.
writeln
(
'homepage: https://flutter.dev'
);
buf
.
writeln
(
'homepage: https://flutter.dev'
);
// TODO(dnfield): We should make DartDoc able to avoid emitting this. If we
// TODO(dnfield): Re-factor for proper versioning, https://github.com/flutter/flutter/issues/55409
// use the real value here, every file will get marked as new instead of only
// files that have otherwise changed. Instead, we replace it dynamically using
// JavaScript so that fewer files get marked as changed.
// https://github.com/dart-lang/dartdoc/issues/1982
buf
.
writeln
(
'version: 0.0.0'
);
buf
.
writeln
(
'version: 0.0.0'
);
buf
.
writeln
(
'dependencies:'
);
buf
.
writeln
(
'dependencies:'
);
for
(
final
String
package
in
findPackageNames
())
{
for
(
final
String
package
in
findPackageNames
())
{
...
...
dev/tracing_tests/test/image_cache_tracing_test.dart
View file @
cbc121e3
...
@@ -99,7 +99,7 @@ bool _mapsEqual(Map<String, dynamic> expectedArgs, Map<String, dynamic> args) {
...
@@ -99,7 +99,7 @@ bool _mapsEqual(Map<String, dynamic> expectedArgs, Map<String, dynamic> args) {
return
true
;
return
true
;
}
}
// TODO(dnfield):
we can drop this in favor of vm_service when https://github.com/dart-lang/webdev/issues/899 is resolved.
// TODO(dnfield):
This can be removed in favor of using the vm_service package, https://github.com/flutter/flutter/issues/55411
class
TimelineObtainer
{
class
TimelineObtainer
{
WebSocket
_observatorySocket
;
WebSocket
_observatorySocket
;
int
_lastCallId
=
0
;
int
_lastCallId
=
0
;
...
...
examples/catalog/test/custom_semantics_test.dart
View file @
cbc121e3
...
@@ -18,10 +18,7 @@ void main() {
...
@@ -18,10 +18,7 @@ void main() {
await
tester
.
pump
();
await
tester
.
pump
();
// Verify it correctly exposes its semantics.
// Verify it correctly exposes its semantics.
// TODO(goderbauer): Use `SemanticsTester` after https://github.com/flutter/flutter/issues/12286.
final
SemanticsNode
semantics
=
tester
.
getSemantics
(
find
.
byType
(
AdjustableDropdownListTile
));
final
SemanticsNode
semantics
=
tester
.
renderObject
(
find
.
byType
(
AdjustableDropdownListTile
))
.
debugSemantics
;
expectAdjustable
(
semantics
,
expectAdjustable
(
semantics
,
hasIncreaseAction:
true
,
hasIncreaseAction:
true
,
...
...
packages/flutter/lib/src/cupertino/action_sheet.dart
View file @
cbc121e3
...
@@ -937,13 +937,15 @@ class _PressableActionButtonState extends State<_PressableActionButton> {
...
@@ -937,13 +937,15 @@ class _PressableActionButtonState extends State<_PressableActionButton> {
Widget
build
(
BuildContext
context
)
{
Widget
build
(
BuildContext
context
)
{
return
_ActionButtonParentDataWidget
(
return
_ActionButtonParentDataWidget
(
isPressed:
_isPressed
,
isPressed:
_isPressed
,
// TODO(mattcarroll): Button press dynamics need overhaul for iOS: https://github.com/flutter/flutter/issues/19786
// TODO(mattcarroll): Button press dynamics need overhaul for iOS:
// https://github.com/flutter/flutter/issues/19786
child:
GestureDetector
(
child:
GestureDetector
(
excludeFromSemantics:
true
,
excludeFromSemantics:
true
,
behavior:
HitTestBehavior
.
opaque
,
behavior:
HitTestBehavior
.
opaque
,
onTapDown:
(
TapDownDetails
details
)
=>
setState
(()
=>
_isPressed
=
true
),
onTapDown:
(
TapDownDetails
details
)
=>
setState
(()
=>
_isPressed
=
true
),
onTapUp:
(
TapUpDetails
details
)
=>
setState
(()
=>
_isPressed
=
false
),
onTapUp:
(
TapUpDetails
details
)
=>
setState
(()
=>
_isPressed
=
false
),
// TODO(mattcarroll): Cancel is currently triggered when user moves past slop instead of off button: https://github.com/flutter/flutter/issues/19783
// TODO(mattcarroll): Cancel is currently triggered when user moves past
// slop instead of off button: https://github.com/flutter/flutter/issues/19783
onTapCancel:
()
=>
setState
(()
=>
_isPressed
=
false
),
onTapCancel:
()
=>
setState
(()
=>
_isPressed
=
false
),
child:
widget
.
child
,
child:
widget
.
child
,
),
),
...
...
packages/flutter/lib/src/cupertino/context_menu.dart
View file @
cbc121e3
...
@@ -378,8 +378,8 @@ class _CupertinoContextMenuState extends State<CupertinoContextMenu> with Ticker
...
@@ -378,8 +378,8 @@ class _CupertinoContextMenuState extends State<CupertinoContextMenu> with Ticker
// decoy will pop on top of the AppBar if the child is partially behind it,
// decoy will pop on top of the AppBar if the child is partially behind it,
// such as a top item in a partially scrolled view. However, if we don't use
// such as a top item in a partially scrolled view. However, if we don't use
// an overlay, then the decoy will appear behind its neighboring widget when
// an overlay, then the decoy will appear behind its neighboring widget when
// it expands. This may be solv
e
able by adding a widget to Scaffold that's
// it expands. This may be solvable by adding a widget to Scaffold that's
// undernea
r
th the AppBar.
// underneath the AppBar.
_lastOverlayEntry
=
OverlayEntry
(
_lastOverlayEntry
=
OverlayEntry
(
opaque:
false
,
opaque:
false
,
builder:
(
BuildContext
context
)
{
builder:
(
BuildContext
context
)
{
...
...
packages/flutter/lib/src/cupertino/dialog.dart
View file @
cbc121e3
...
@@ -995,7 +995,8 @@ class _PressableActionButtonState extends State<_PressableActionButton> {
...
@@ -995,7 +995,8 @@ class _PressableActionButtonState extends State<_PressableActionButton> {
return
_ActionButtonParentDataWidget
(
return
_ActionButtonParentDataWidget
(
isPressed:
_isPressed
,
isPressed:
_isPressed
,
child:
MergeSemantics
(
child:
MergeSemantics
(
// TODO(mattcarroll): Button press dynamics need overhaul for iOS: https://github.com/flutter/flutter/issues/19786
// TODO(mattcarroll): Button press dynamics need overhaul for iOS:
// https://github.com/flutter/flutter/issues/19786
child:
GestureDetector
(
child:
GestureDetector
(
excludeFromSemantics:
true
,
excludeFromSemantics:
true
,
behavior:
HitTestBehavior
.
opaque
,
behavior:
HitTestBehavior
.
opaque
,
...
@@ -1005,7 +1006,8 @@ class _PressableActionButtonState extends State<_PressableActionButton> {
...
@@ -1005,7 +1006,8 @@ class _PressableActionButtonState extends State<_PressableActionButton> {
onTapUp:
(
TapUpDetails
details
)
=>
setState
(()
{
onTapUp:
(
TapUpDetails
details
)
=>
setState
(()
{
_isPressed
=
false
;
_isPressed
=
false
;
}),
}),
// TODO(mattcarroll): Cancel is currently triggered when user moves past slop instead of off button: https://github.com/flutter/flutter/issues/19783
// TODO(mattcarroll): Cancel is currently triggered when user moves
// past slop instead of off button: https://github.com/flutter/flutter/issues/19783
onTapCancel:
()
=>
setState
(()
=>
_isPressed
=
false
),
onTapCancel:
()
=>
setState
(()
=>
_isPressed
=
false
),
child:
widget
.
child
,
child:
widget
.
child
,
),
),
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment