Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
cab8242f
Unverified
Commit
cab8242f
authored
Mar 29, 2018
by
xster
Committed by
GitHub
Mar 29, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "Re-enable usage of TransformLayers with text in RenderListWheelViewport (#15625)" (#16042)
This reverts commit
1f5d9041
.
parent
45653956
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
34 deletions
+3
-34
list_wheel_viewport.dart
packages/flutter/lib/src/rendering/list_wheel_viewport.dart
+3
-1
list_wheel_scroll_view_test.dart
...ges/flutter/test/widgets/list_wheel_scroll_view_test.dart
+0
-33
No files found.
packages/flutter/lib/src/rendering/list_wheel_viewport.dart
View file @
cab8242f
...
...
@@ -562,7 +562,9 @@ class RenderListWheelViewport
);
context
.
pushTransform
(
needsCompositing
,
// Text with TransformLayers and no cullRects currently have an issue rendering
// https://github.com/flutter/flutter/issues/14224.
false
,
offset
,
_centerOriginTransform
(
transform
),
// Pre-transform painting function.
...
...
packages/flutter/test/widgets/list_wheel_scroll_view_test.dart
View file @
cab8242f
...
...
@@ -385,39 +385,6 @@ void main() {
]),
));
});
testWidgets
(
'Painting creates layers'
,
(
WidgetTester
tester
)
async
{
await
tester
.
pumpWidget
(
new
Directionality
(
textDirection:
TextDirection
.
ltr
,
child:
new
ListWheelScrollView
(
itemExtent:
100.0
,
children:
<
Widget
>[
new
Container
(
width:
200.0
,
child:
const
Center
(
child:
const
Text
(
'blah'
),
),
),
],
),
),
);
expect
(
new
List
<
TransformLayer
>.
from
(
tester
.
layers
.
where
((
Layer
layer
)
=>
layer
is
TransformLayer
)
)
.
map
((
TransformLayer
layer
)
=>
layer
.
transform
.
storage
)
.
toList
(),
contains
(
equals
(<
dynamic
>[
1.0
,
0.0
,
0.0
,
0.0
,
0.0
,
1.0
,
0.0
,
0.0
,
-
1.2
,
-
0.9
,
1.0
,
-
0.003
,
moreOrLessEquals
(
0.0
),
moreOrLessEquals
(
0.0
),
0.0
,
moreOrLessEquals
(
1.0
),
])),
);
});
});
group
(
'scroll notifications'
,
()
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment