Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
c48c428e
Unverified
Commit
c48c428e
authored
Sep 30, 2021
by
Jenn Magder
Committed by
GitHub
Sep 30, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Xcode 13 as minimum recommended version (#90906)
parent
afd84ad4
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
7 deletions
+7
-7
xcode.dart
packages/flutter_tools/lib/src/macos/xcode.dart
+1
-1
xcode_test.dart
...es/flutter_tools/test/general.shard/macos/xcode_test.dart
+4
-4
xcode_validator_test.dart
..._tools/test/general.shard/macos/xcode_validator_test.dart
+2
-2
No files found.
packages/flutter_tools/lib/src/macos/xcode.dart
View file @
c48c428e
...
@@ -22,7 +22,7 @@ Version get xcodeRequiredVersion => Version(12, 0, 1, text: '12.0.1');
...
@@ -22,7 +22,7 @@ Version get xcodeRequiredVersion => Version(12, 0, 1, text: '12.0.1');
/// Diverging this number from the minimum required version will provide a doctor
/// Diverging this number from the minimum required version will provide a doctor
/// warning, not error, that users should upgrade Xcode.
/// warning, not error, that users should upgrade Xcode.
Version
get
xcodeRecommendedVersion
=>
xcodeRequiredVersion
;
Version
get
xcodeRecommendedVersion
=>
Version
(
13
,
0
,
0
,
text:
'13.0.0'
)
;
/// SDK name passed to `xcrun --sdk`. Corresponds to undocumented Xcode
/// SDK name passed to `xcrun --sdk`. Corresponds to undocumented Xcode
/// SUPPORTED_PLATFORMS values.
/// SUPPORTED_PLATFORMS values.
...
...
packages/flutter_tools/test/general.shard/macos/xcode_test.dart
View file @
c48c428e
...
@@ -189,28 +189,28 @@ void main() {
...
@@ -189,28 +189,28 @@ void main() {
testWithoutContext
(
'isRecommendedVersionSatisfactory is true when version meets minimum'
,
()
{
testWithoutContext
(
'isRecommendedVersionSatisfactory is true when version meets minimum'
,
()
{
xcodeProjectInterpreter
.
isInstalled
=
true
;
xcodeProjectInterpreter
.
isInstalled
=
true
;
xcodeProjectInterpreter
.
version
=
Version
(
1
2
,
0
,
1
);
xcodeProjectInterpreter
.
version
=
Version
(
1
3
,
0
,
0
);
expect
(
xcode
.
isRecommendedVersionSatisfactory
,
isTrue
);
expect
(
xcode
.
isRecommendedVersionSatisfactory
,
isTrue
);
});
});
testWithoutContext
(
'isRecommendedVersionSatisfactory is true when major version exceeds minimum'
,
()
{
testWithoutContext
(
'isRecommendedVersionSatisfactory is true when major version exceeds minimum'
,
()
{
xcodeProjectInterpreter
.
isInstalled
=
true
;
xcodeProjectInterpreter
.
isInstalled
=
true
;
xcodeProjectInterpreter
.
version
=
Version
(
1
3
,
0
,
0
);
xcodeProjectInterpreter
.
version
=
Version
(
1
4
,
0
,
0
);
expect
(
xcode
.
isRecommendedVersionSatisfactory
,
isTrue
);
expect
(
xcode
.
isRecommendedVersionSatisfactory
,
isTrue
);
});
});
testWithoutContext
(
'isRecommendedVersionSatisfactory is true when minor version exceeds minimum'
,
()
{
testWithoutContext
(
'isRecommendedVersionSatisfactory is true when minor version exceeds minimum'
,
()
{
xcodeProjectInterpreter
.
isInstalled
=
true
;
xcodeProjectInterpreter
.
isInstalled
=
true
;
xcodeProjectInterpreter
.
version
=
Version
(
1
2
,
3
,
0
);
xcodeProjectInterpreter
.
version
=
Version
(
1
3
,
3
,
0
);
expect
(
xcode
.
isRecommendedVersionSatisfactory
,
isTrue
);
expect
(
xcode
.
isRecommendedVersionSatisfactory
,
isTrue
);
});
});
testWithoutContext
(
'isRecommendedVersionSatisfactory is true when patch version exceeds minimum'
,
()
{
testWithoutContext
(
'isRecommendedVersionSatisfactory is true when patch version exceeds minimum'
,
()
{
xcodeProjectInterpreter
.
isInstalled
=
true
;
xcodeProjectInterpreter
.
isInstalled
=
true
;
xcodeProjectInterpreter
.
version
=
Version
(
1
2
,
0
,
2
);
xcodeProjectInterpreter
.
version
=
Version
(
1
3
,
0
,
2
);
expect
(
xcode
.
isRecommendedVersionSatisfactory
,
isTrue
);
expect
(
xcode
.
isRecommendedVersionSatisfactory
,
isTrue
);
});
});
...
...
packages/flutter_tools/test/general.shard/macos/xcode_validator_test.dart
View file @
c48c428e
...
@@ -69,8 +69,8 @@ void main() {
...
@@ -69,8 +69,8 @@ void main() {
final
ValidationResult
result
=
await
validator
.
validate
();
final
ValidationResult
result
=
await
validator
.
validate
();
expect
(
result
.
type
,
ValidationType
.
partial
);
expect
(
result
.
type
,
ValidationType
.
partial
);
expect
(
result
.
messages
.
last
.
type
,
ValidationMessageType
.
hint
);
expect
(
result
.
messages
.
last
.
type
,
ValidationMessageType
.
hint
);
expect
(
result
.
messages
.
last
.
message
,
contains
(
'Flutter recommends a minimum Xcode version of 1
2.0.2
'
));
expect
(
result
.
messages
.
last
.
message
,
contains
(
'Flutter recommends a minimum Xcode version of 1
3.0.0
'
));
}
,
skip:
true
);
// [intended] Unskip and update when minimum and required check versions diverge.
}
);
testWithoutContext
(
'Emits partial status when Xcode EULA not signed'
,
()
async
{
testWithoutContext
(
'Emits partial status when Xcode EULA not signed'
,
()
async
{
final
ProcessManager
processManager
=
FakeProcessManager
.
list
(<
FakeCommand
>[
final
ProcessManager
processManager
=
FakeProcessManager
.
list
(<
FakeCommand
>[
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment